Re: [dpdk-dev] [PATCH] testpmd: add speed capability in device info

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 9/4/2020 7:23 AM, Sarosh Arif wrote:
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index 30bee3324..8824ad174 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -518,6 +518,7 @@ device_infos_display(const char *identifier)
>   	struct rte_device *dev;
>   	struct rte_devargs da;
>   	portid_t port_id;
> +	struct rte_eth_dev_info dev_info;
>   	char devstr[128];

This is for the testpmd command "show device info <identifier>|all",
not sure speed capabilities really fits the device info display.

"show port info <port_id>|all" command may be better fit, but before 
that is there a specific need to see the speed capabilities of a port, 
it may help figuring out right place.

>   
>   	memset(&da, 0, sizeof(da));
> @@ -569,6 +570,90 @@ device_infos_display(const char *identifier)
>   						      &mac_addr);
>   				rte_eth_dev_get_name_by_port(port_id, name);
>   				printf("\n\tDevice name: %s", name);
> +				rte_eth_dev_info_get(port_id, &dev_info);
> +				switch (dev_info.speed_capa) {
> +				case ETH_LINK_SPEED_AUTONEG:
> +					printf("\n\tDevice speed capability: %s",
> +							"Autonegotiate (all speeds)");
> +					break;
> +				case ETH_LINK_SPEED_FIXED:
> +					printf("\n\tDevice speed capability: %s",
> +							"Disable autonegotiate (fixed speed)");
> +					break;
> +				case ETH_LINK_SPEED_10M_HD ...
> +						ETH_LINK_SPEED_10M-1:

Why ranges are used, there can't be any value in between?

Also case range is not part of starndard, may be good to avoid for 
portability, like the case -pendantic is used etc..


> +					printf("\n\tDevice speed capability: %s",
> +							"10 Mbps half-duplex");
> +					break;

You should not break. 'speed_capa' is list of speeds that device 
supports, so it won't be a single value, that is why breaking after 
first hit is wrong.

Can you please confirm you intentions is not to display link speed, but 
"speed capability"? Btw, link speed is already displayed in "show port 
info ..."

> +				case ETH_LINK_SPEED_10M ...
> +						ETH_LINK_SPEED_100M_HD-1:
> +					printf("\n\tDevice speed capability: %s",
> +							"10 Mbps full-duplex");

Also no need to be this verbose, since there will be multiple values, 
this makes to much noise, instead can be an list of speeds in single line.