From: Cunming Liang <cunming.liang@intel.com> To: dev@dpdk.org Subject: [dpdk-dev] [PATCH 3/5] ixgbe: not 'DISABLE' may make confuse, change RTE_IXGBE_RX_OLFLAGS_DISABLE=n to RTE_IXGBE_RX_OLFLAGS_ENABLE=y Date: Thu, 26 Jun 2014 14:53:32 +0800 Message-ID: <87c1d5e33f82fc085da977ce7e7daece81a4dbc9.1403759017.git.cunming.liang@intel.com> (raw) In-Reply-To: <cover.1403759017.git.cunming.liang@intel.com> In-Reply-To: <cover.1403759017.git.cunming.liang@intel.com> RTE_IXGBE_RX_OLFLAGS_ENABLE gives a hint whick keeping packet type in RX ol_flags or not. By default it is set to update ol_flags in RX mbuf header. If unset it, will gain addtional performance, but will lose packet type information. Signed-off-by: Cunming Liang <cunming.liang@intel.com> Acked-by: Bruce Richardson <bruce.richardson@intel.com> Acked-by: Yong Liu <yong.liu@intel.com> Tested-by: Zhaochen Zhan <zhaochen.zhan@intel.com> --- config/common_linuxapp | 2 +- lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/config/common_linuxapp b/config/common_linuxapp index 5b896c3..b19c4d9 100644 --- a/config/common_linuxapp +++ b/config/common_linuxapp @@ -192,7 +192,7 @@ CONFIG_RTE_LIBRTE_IXGBE_PF_DISABLE_STRIP_CRC=n CONFIG_RTE_LIBRTE_IXGBE_RX_ALLOW_BULK_ALLOC=y CONFIG_RTE_LIBRTE_IXGBE_ALLOW_UNSUPPORTED_SFP=n CONFIG_RTE_IXGBE_INC_VECTOR=y -CONFIG_RTE_IXGBE_RX_OLFLAGS_DISABLE=n +CONFIG_RTE_IXGBE_RX_OLFLAGS_ENABLE=y # # Compile burst-oriented I40E PMD driver diff --git a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c index 74d1b36..09e19a3 100644 --- a/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c +++ b/lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c @@ -145,7 +145,7 @@ ixgbe_rxq_rearm(struct igb_rx_queue *rxq) * gives improved performance, at the cost of losing the offload info * in the received packet */ -#ifndef RTE_IXGBE_RX_OLFLAGS_DISABLE +#ifdef RTE_IXGBE_RX_OLFLAGS_ENABLE #define OLFLAGS_MASK ((uint16_t)(PKT_RX_VLAN_PKT | PKT_RX_IPV4_HDR |\ PKT_RX_IPV4_HDR_EXT | PKT_RX_IPV6_HDR |\ @@ -679,7 +679,7 @@ int ixgbe_rx_vec_condition_check(struct rte_eth_dev *dev) struct rte_eth_rxmode *rxmode = &dev->data->dev_conf.rxmode; struct rte_fdir_conf *fconf = &dev->data->dev_conf.fdir_conf; -#ifdef RTE_IXGBE_RX_OLFLAGS_DISABLE +#ifndef RTE_IXGBE_RX_OLFLAGS_ENABLE /* whithout rx ol_flags, no VP flag report */ if (rxmode->hw_vlan_strip != 0 || rxmode->hw_vlan_extend != 0) -- 1.8.1.4
next prev parent reply other threads:[~2014-06-26 6:53 UTC|newest] Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-06-26 6:53 [dpdk-dev] [PATCH 0/5] ixgbe: vPMD compiling issue and testpmd default value change Cunming Liang 2014-06-26 6:53 ` [dpdk-dev] [PATCH 1/5] ixgbe: avoid compiler error when RTE_IXGBE_INC_VECTOR=y and RTE_LIBRTE_IXGBE_RX_ALLOC_BULK_ALLOC=n Cunming Liang 2014-06-26 6:53 ` [dpdk-dev] [PATCH 2/5] ixgbe: fix vpmd compiling error when RTE_LIBRTE_IEEE1588=y Cunming Liang 2014-06-26 6:53 ` Cunming Liang [this message] 2014-06-26 6:53 ` [dpdk-dev] [PATCH 4/5] ixgbe: set default burst size 32 in testpmd Cunming Liang 2014-06-26 6:53 ` [dpdk-dev] [PATCH 5/5] testpmd: change some of testpmd default parameter to well tuned value Cunming Liang 2014-06-26 12:33 ` [dpdk-dev] [PATCH 0/5] ixgbe: vPMD compiling issue and testpmd default value change Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=87c1d5e33f82fc085da977ce7e7daece81a4dbc9.1403759017.git.cunming.liang@intel.com \ --to=cunming.liang@intel.com \ --cc=dev@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git