* [dpdk-dev] [PATCH] net/bnxt: fix setting the auto link speed mask
@ 2018-02-08 17:36 Ajit Khaparde
2018-02-08 17:43 ` Ferruh Yigit
0 siblings, 1 reply; 2+ messages in thread
From: Ajit Khaparde @ 2018-02-08 17:36 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit
Set the auto link speed only when force speed is not desired.
Fixes: fe017534dfd4 ("net/bnxt: fix link speed setting with autoneg off")
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
drivers/net/bnxt/bnxt_hwrm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index 4dcdf36a5..b7843afe6 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -831,7 +831,8 @@ static int bnxt_hwrm_port_phy_cfg(struct bnxt *bp, struct bnxt_link_info *conf)
HWRM_PORT_PHY_CFG_INPUT_AUTO_MODE_ALL_SPEEDS;
}
/* AutoNeg - Advertise speeds specified. */
- if (conf->auto_link_speed_mask) {
+ if (conf->auto_link_speed_mask &&
+ !(conf->phy_flags & HWRM_PORT_PHY_CFG_INPUT_FLAGS_FORCE)) {
req.auto_mode =
HWRM_PORT_PHY_CFG_INPUT_AUTO_MODE_SPEED_MASK;
req.auto_link_speed_mask =
--
2.14.3 (Apple Git-98)
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/bnxt: fix setting the auto link speed mask
2018-02-08 17:36 [dpdk-dev] [PATCH] net/bnxt: fix setting the auto link speed mask Ajit Khaparde
@ 2018-02-08 17:43 ` Ferruh Yigit
0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2018-02-08 17:43 UTC (permalink / raw)
To: Ajit Khaparde, dev
On 2/8/2018 5:36 PM, Ajit Khaparde wrote:
> Set the auto link speed only when force speed is not desired.
> Fixes: fe017534dfd4 ("net/bnxt: fix link speed setting with autoneg off")
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Squashed into relevant commit in next-net, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-08 17:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-08 17:36 [dpdk-dev] [PATCH] net/bnxt: fix setting the auto link speed mask Ajit Khaparde
2018-02-08 17:43 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).