From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2 2/7] net/txgbe: add device arguments
Date: Wed, 24 Mar 2021 10:59:18 +0000 [thread overview]
Message-ID: <9160c9a1-9b93-4fc8-6c39-5f807ea9722c@intel.com> (raw)
In-Reply-To: <20210316105149.110904-3-jiawenwu@trustnetic.com>
On 3/16/2021 10:51 AM, Jiawen Wu wrote:
> Add device arguments to support runtime options. These arguments are
> only set for backplane NICs.
>
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
<...>
> +
> +#define TXGBE_DEVARG_BP_AUTO "auto"
> +#define TXGBE_DEVARG_KR_POLL "poll"
> +#define TXGBE_DEVARG_KR_PRESENT "present"
> +#define TXGBE_DEVARG_KX_SGMII "sgmii"
> +#define TXGBE_DEVARG_FFE_SET "ffe_set"
> +#define TXGBE_DEVARG_FFE_MAIN "ffe_main"
> +#define TXGBE_DEVARG_FFE_PRE "ffe_pre"
> +#define TXGBE_DEVARG_FFE_POST "ffe_post"
> +
I just recognized that this patch is adding devargs without using them, and
later patches are using them. This separates them from the full context.
Can you please add them gradually as they are used, in the same patch they are used?
Meanwhile you can add the release notes update in next version.
Thanks,
ferruh
next prev parent reply other threads:[~2021-03-24 10:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-16 10:51 [dpdk-dev] [PATCH v2 0/7] txgbe backplane AN training Jiawen Wu
2021-03-16 10:51 ` [dpdk-dev] [PATCH v2 1/7] net/txgbe: update device ID Jiawen Wu
2021-03-16 10:51 ` [dpdk-dev] [PATCH v2 2/7] net/txgbe: add device arguments Jiawen Wu
2021-03-24 10:59 ` Ferruh Yigit [this message]
2021-03-24 11:01 ` Ferruh Yigit
2021-03-16 10:51 ` [dpdk-dev] [PATCH v2 3/7] net/txgbe: move firmware version get function to base code Jiawen Wu
2021-03-16 10:51 ` [dpdk-dev] [PATCH v2 4/7] net/txgbe: update link setup process of backplane NICs Jiawen Wu
2021-03-16 10:51 ` [dpdk-dev] [PATCH v2 5/7] net/txgbe/base: support to handle backplane AN73 flow Jiawen Wu
2021-03-16 10:51 ` [dpdk-dev] [PATCH v2 6/7] net/txgbe: handle AN interrupt and link update Jiawen Wu
2021-03-16 10:51 ` [dpdk-dev] [PATCH v2 7/7] net/txgbe: add FFE parameters for user debugging Jiawen Wu
2021-03-23 17:33 ` [dpdk-dev] [PATCH v2 0/7] txgbe backplane AN training Ferruh Yigit
2021-03-24 1:57 ` Jiawen Wu
2021-03-24 10:36 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9160c9a1-9b93-4fc8-6c39-5f807ea9722c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jiawenwu@trustnetic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).