DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] app/testpmd: fix Tx/Rx descriptor query error log
@ 2021-03-27  7:34 Min Hu (Connor)
  2021-03-29  5:49 ` Li, Xiaoyun
  2021-03-29  6:46 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
  0 siblings, 2 replies; 7+ messages in thread
From: Min Hu (Connor) @ 2021-03-27  7:34 UTC (permalink / raw)
  To: dev; +Cc: ferruh.yigit, xiaoyun.li

From: Hongbo Zheng <zhenghongbo3@huawei.com>

Currently in testpmd, if we input "show port 0 rxq 0 desc 9999 status"
and if rte_eth_rx_descriptor_status return a negative value, testpmd will
print "Invalid queueid = 0", seems user input an invalid queueid, while
the actual situation may be that 9999 is out of bounds, current
information is misleading to users.

This patch modify the Tx/Rx descriptor query error information in testpmd
by add offset information, now if we fail to query Tx/Rx descriptor,
testpmd will print "Invalid queueid = 0, offset = 9999", then we can check
our input.

Fixes: fae9aa717d6c ("app/testpmd: support checking descriptor status")
Cc: stable@dpdk.org

Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
 app/test-pmd/cmdline.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 287d7a0..1a74a61 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -16633,7 +16633,8 @@ cmd_show_rx_tx_desc_status_parsed(void *parsed_result,
 		rc = rte_eth_rx_descriptor_status(res->cmd_pid, res->cmd_qid,
 					     res->cmd_did);
 		if (rc < 0) {
-			printf("Invalid queueid = %d\n", res->cmd_qid);
+			printf("Invalid queueid = %d, offset = %d\n",
+			       res->cmd_qid, res->cmd_did);
 			return;
 		}
 		if (rc == RTE_ETH_RX_DESC_AVAIL)
@@ -16646,7 +16647,8 @@ cmd_show_rx_tx_desc_status_parsed(void *parsed_result,
 		rc = rte_eth_tx_descriptor_status(res->cmd_pid, res->cmd_qid,
 					     res->cmd_did);
 		if (rc < 0) {
-			printf("Invalid queueid = %d\n", res->cmd_qid);
+			printf("Invalid queueid = %d, offset = %d\n",
+			       res->cmd_qid, res->cmd_did);
 			return;
 		}
 		if (rc == RTE_ETH_TX_DESC_FULL)
-- 
2.7.4


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] app/testpmd: fix Tx/Rx descriptor query error log
  2021-03-27  7:34 [dpdk-dev] [PATCH] app/testpmd: fix Tx/Rx descriptor query error log Min Hu (Connor)
@ 2021-03-29  5:49 ` Li, Xiaoyun
  2021-03-29  6:47   ` Min Hu (Connor)
  2021-03-29  6:46 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
  1 sibling, 1 reply; 7+ messages in thread
From: Li, Xiaoyun @ 2021-03-29  5:49 UTC (permalink / raw)
  To: Min Hu (Connor), dev; +Cc: Yigit, Ferruh

Hi

> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Saturday, March 27, 2021 15:35
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>
> Subject: [PATCH] app/testpmd: fix Tx/Rx descriptor query error log
> 
> From: Hongbo Zheng <zhenghongbo3@huawei.com>
> 
> Currently in testpmd, if we input "show port 0 rxq 0 desc 9999 status"
> and if rte_eth_rx_descriptor_status return a negative value, testpmd will print
returns
> "Invalid queueid = 0", seems user input an invalid queueid, while the actual
Users input/ user inputs
> situation may be that 9999 is out of bounds, current information is misleading to
> users.
> 
> This patch modify the Tx/Rx descriptor query error information in testpmd by
modifies
> add offset information, now if we fail to query Tx/Rx descriptor, testpmd will
adding
> print "Invalid queueid = 0, offset = 9999", then we can check our input.

The commit log has grammar mistakes. And I think you can simply explain what the patch does like:
This patch adds more err info for Tx/Rx descriptor query command.

And the print should be "Invalid input: queue id = 0, desc id = 9999" because you still don't tell users if it's queue id err or desc id err.

BRs
Xiaoyun
> 
> Fixes: fae9aa717d6c ("app/testpmd: support checking descriptor status")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
>  app/test-pmd/cmdline.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> 287d7a0..1a74a61 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -16633,7 +16633,8 @@ cmd_show_rx_tx_desc_status_parsed(void
> *parsed_result,
>  		rc = rte_eth_rx_descriptor_status(res->cmd_pid, res->cmd_qid,
>  					     res->cmd_did);
>  		if (rc < 0) {
> -			printf("Invalid queueid = %d\n", res->cmd_qid);
> +			printf("Invalid queueid = %d, offset = %d\n",
> +			       res->cmd_qid, res->cmd_did);
>  			return;
>  		}
>  		if (rc == RTE_ETH_RX_DESC_AVAIL)
> @@ -16646,7 +16647,8 @@ cmd_show_rx_tx_desc_status_parsed(void
> *parsed_result,
>  		rc = rte_eth_tx_descriptor_status(res->cmd_pid, res->cmd_qid,
>  					     res->cmd_did);
>  		if (rc < 0) {
> -			printf("Invalid queueid = %d\n", res->cmd_qid);
> +			printf("Invalid queueid = %d, offset = %d\n",
> +			       res->cmd_qid, res->cmd_did);
>  			return;
>  		}
>  		if (rc == RTE_ETH_TX_DESC_FULL)
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dpdk-dev] [PATCH v2] app/testpmd: fix Tx/Rx descriptor query error log
  2021-03-27  7:34 [dpdk-dev] [PATCH] app/testpmd: fix Tx/Rx descriptor query error log Min Hu (Connor)
  2021-03-29  5:49 ` Li, Xiaoyun
@ 2021-03-29  6:46 ` Min Hu (Connor)
  2021-03-29  7:07   ` Li, Xiaoyun
  2021-03-30 14:29   ` Ferruh Yigit
  1 sibling, 2 replies; 7+ messages in thread
From: Min Hu (Connor) @ 2021-03-29  6:46 UTC (permalink / raw)
  To: dev; +Cc: ferruh.yigit, xiaoyun.li

From: Hongbo Zheng <zhenghongbo3@huawei.com>

This patch adds more err info for Tx/Rx descriptor query command.

Fixes: fae9aa717d6c ("app/testpmd: support checking descriptor status")
Cc: stable@dpdk.org

Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
v2:
* Fixed error log info and simply the commit info.
---
 app/test-pmd/cmdline.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 14110eb..f44116b 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -16629,7 +16629,8 @@ cmd_show_rx_tx_desc_status_parsed(void *parsed_result,
 		rc = rte_eth_rx_descriptor_status(res->cmd_pid, res->cmd_qid,
 					     res->cmd_did);
 		if (rc < 0) {
-			printf("Invalid queueid = %d\n", res->cmd_qid);
+			printf("Invalid input: queue id = %d, desc id = %d\n",
+			       res->cmd_qid, res->cmd_did);
 			return;
 		}
 		if (rc == RTE_ETH_RX_DESC_AVAIL)
@@ -16642,7 +16643,8 @@ cmd_show_rx_tx_desc_status_parsed(void *parsed_result,
 		rc = rte_eth_tx_descriptor_status(res->cmd_pid, res->cmd_qid,
 					     res->cmd_did);
 		if (rc < 0) {
-			printf("Invalid queueid = %d\n", res->cmd_qid);
+			printf("Invalid input: queue id = %d, desc id = %d\n",
+			       res->cmd_qid, res->cmd_did);
 			return;
 		}
 		if (rc == RTE_ETH_TX_DESC_FULL)
-- 
2.7.4


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH] app/testpmd: fix Tx/Rx descriptor query error log
  2021-03-29  5:49 ` Li, Xiaoyun
@ 2021-03-29  6:47   ` Min Hu (Connor)
  0 siblings, 0 replies; 7+ messages in thread
From: Min Hu (Connor) @ 2021-03-29  6:47 UTC (permalink / raw)
  To: Li, Xiaoyun, dev; +Cc: Yigit, Ferruh

Hi, xiaoyun,
	All has been done in v2, please review it, thanks.

在 2021/3/29 13:49, Li, Xiaoyun 写道:
> Hi
> 
>> -----Original Message-----
>> From: Min Hu (Connor) <humin29@huawei.com>
>> Sent: Saturday, March 27, 2021 15:35
>> To: dev@dpdk.org
>> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>
>> Subject: [PATCH] app/testpmd: fix Tx/Rx descriptor query error log
>>
>> From: Hongbo Zheng <zhenghongbo3@huawei.com>
>>
>> Currently in testpmd, if we input "show port 0 rxq 0 desc 9999 status"
>> and if rte_eth_rx_descriptor_status return a negative value, testpmd will print
> returns
>> "Invalid queueid = 0", seems user input an invalid queueid, while the actual
> Users input/ user inputs
>> situation may be that 9999 is out of bounds, current information is misleading to
>> users.
>>
>> This patch modify the Tx/Rx descriptor query error information in testpmd by
> modifies
>> add offset information, now if we fail to query Tx/Rx descriptor, testpmd will
> adding
>> print "Invalid queueid = 0, offset = 9999", then we can check our input.
> 
> The commit log has grammar mistakes. And I think you can simply explain what the patch does like:
> This patch adds more err info for Tx/Rx descriptor query command.
> 
> And the print should be "Invalid input: queue id = 0, desc id = 9999" because you still don't tell users if it's queue id err or desc id err.
> 
> BRs
> Xiaoyun
>>
>> Fixes: fae9aa717d6c ("app/testpmd: support checking descriptor status")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> ---
>>   app/test-pmd/cmdline.c | 6 ++++--
>>   1 file changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
>> 287d7a0..1a74a61 100644
>> --- a/app/test-pmd/cmdline.c
>> +++ b/app/test-pmd/cmdline.c
>> @@ -16633,7 +16633,8 @@ cmd_show_rx_tx_desc_status_parsed(void
>> *parsed_result,
>>   		rc = rte_eth_rx_descriptor_status(res->cmd_pid, res->cmd_qid,
>>   					     res->cmd_did);
>>   		if (rc < 0) {
>> -			printf("Invalid queueid = %d\n", res->cmd_qid);
>> +			printf("Invalid queueid = %d, offset = %d\n",
>> +			       res->cmd_qid, res->cmd_did);
>>   			return;
>>   		}
>>   		if (rc == RTE_ETH_RX_DESC_AVAIL)
>> @@ -16646,7 +16647,8 @@ cmd_show_rx_tx_desc_status_parsed(void
>> *parsed_result,
>>   		rc = rte_eth_tx_descriptor_status(res->cmd_pid, res->cmd_qid,
>>   					     res->cmd_did);
>>   		if (rc < 0) {
>> -			printf("Invalid queueid = %d\n", res->cmd_qid);
>> +			printf("Invalid queueid = %d, offset = %d\n",
>> +			       res->cmd_qid, res->cmd_did);
>>   			return;
>>   		}
>>   		if (rc == RTE_ETH_TX_DESC_FULL)
>> --
>> 2.7.4
> 
> .
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/testpmd: fix Tx/Rx descriptor query error log
  2021-03-29  6:46 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
@ 2021-03-29  7:07   ` Li, Xiaoyun
  2021-03-30 14:35     ` Ferruh Yigit
  2021-03-30 14:29   ` Ferruh Yigit
  1 sibling, 1 reply; 7+ messages in thread
From: Li, Xiaoyun @ 2021-03-29  7:07 UTC (permalink / raw)
  To: Min Hu (Connor), dev; +Cc: Yigit, Ferruh

Hi

> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Monday, March 29, 2021 14:47
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>
> Subject: [PATCH v2] app/testpmd: fix Tx/Rx descriptor query error log
> 
> From: Hongbo Zheng <zhenghongbo3@huawei.com>
> 
> This patch adds more err info for Tx/Rx descriptor query command.
> 
> Fixes: fae9aa717d6c ("app/testpmd: support checking descriptor status")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> v2:
> * Fixed error log info and simply the commit info.
> ---
>  app/test-pmd/cmdline.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> 14110eb..f44116b 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -16629,7 +16629,8 @@ cmd_show_rx_tx_desc_status_parsed(void
> *parsed_result,
>  		rc = rte_eth_rx_descriptor_status(res->cmd_pid, res-
> >cmd_qid,
>  					     res->cmd_did);
>  		if (rc < 0) {
> -			printf("Invalid queueid = %d\n", res->cmd_qid);
> +			printf("Invalid input: queue id = %d, desc id = %d\n",
> +			       res->cmd_qid, res->cmd_did);
>  			return;
>  		}
>  		if (rc == RTE_ETH_RX_DESC_AVAIL)
> @@ -16642,7 +16643,8 @@ cmd_show_rx_tx_desc_status_parsed(void
> *parsed_result,
>  		rc = rte_eth_tx_descriptor_status(res->cmd_pid, res-
> >cmd_qid,
>  					     res->cmd_did);
>  		if (rc < 0) {
> -			printf("Invalid queueid = %d\n", res->cmd_qid);
> +			printf("Invalid input: queue id = %d, desc id = %d\n",
> +			       res->cmd_qid, res->cmd_did);
>  			return;
>  		}
>  		if (rc == RTE_ETH_TX_DESC_FULL)
> --
> 2.7.4

Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/testpmd: fix Tx/Rx descriptor query error log
  2021-03-29  6:46 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
  2021-03-29  7:07   ` Li, Xiaoyun
@ 2021-03-30 14:29   ` Ferruh Yigit
  1 sibling, 0 replies; 7+ messages in thread
From: Ferruh Yigit @ 2021-03-30 14:29 UTC (permalink / raw)
  To: Min Hu (Connor), dev; +Cc: xiaoyun.li, techboard

On 3/29/2021 7:46 AM, Min Hu (Connor) wrote:
> From: Hongbo Zheng <zhenghongbo3@huawei.com>
> 
> This patch adds more err info for Tx/Rx descriptor query command.
> 
> Fixes: fae9aa717d6c ("app/testpmd: support checking descriptor status")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>

Off the topic.

This is the patch 90000 in patchwork!
Thanks to everyone who contributed!

https://patches.dpdk.org/api/1.2/patches/90000/

The historical numbers from DPDK patchwork:
90000 - March 29, 2021 (172 days) [ 5 months and 21 days / 24 weeks and 4 days ]
80000 - Oct.   8, 2020 (153 days)
70000 - May    8, 2020 (224 days)
60000 - Sept. 27, 2019 (248 days)
50000 - Jan.  22, 2019 (253 days)
40000 - May   14, 2018 (217 days)
30000 - Oct.   9, 2017 (258 days)
20000 - Jan.  25, 2017 (372 days)
10000 - Jan.  20, 2016 (645 days)
00001 - April 16, 2014


Another 10K of patches faster than rough average ~250 days, assuming v20.11 LTS 
workload contributed to this stat but not investigated deeply.

Thanks again to all contributors.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/testpmd: fix Tx/Rx descriptor query error log
  2021-03-29  7:07   ` Li, Xiaoyun
@ 2021-03-30 14:35     ` Ferruh Yigit
  0 siblings, 0 replies; 7+ messages in thread
From: Ferruh Yigit @ 2021-03-30 14:35 UTC (permalink / raw)
  To: Li, Xiaoyun, Min Hu (Connor), dev

On 3/29/2021 8:07 AM, Li, Xiaoyun wrote:
> Hi
> 
>> -----Original Message-----
>> From: Min Hu (Connor) <humin29@huawei.com>
>> Sent: Monday, March 29, 2021 14:47
>> To: dev@dpdk.org
>> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>
>> Subject: [PATCH v2] app/testpmd: fix Tx/Rx descriptor query error log
>>
>> From: Hongbo Zheng <zhenghongbo3@huawei.com>
>>
>> This patch adds more err info for Tx/Rx descriptor query command.
>>
>> Fixes: fae9aa717d6c ("app/testpmd: support checking descriptor status")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com> >
> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
> 

Applied to dpdk-next-net/main, thanks.

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2021-03-30 14:35 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-27  7:34 [dpdk-dev] [PATCH] app/testpmd: fix Tx/Rx descriptor query error log Min Hu (Connor)
2021-03-29  5:49 ` Li, Xiaoyun
2021-03-29  6:47   ` Min Hu (Connor)
2021-03-29  6:46 ` [dpdk-dev] [PATCH v2] " Min Hu (Connor)
2021-03-29  7:07   ` Li, Xiaoyun
2021-03-30 14:35     ` Ferruh Yigit
2021-03-30 14:29   ` Ferruh Yigit

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git