From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: remove dependency on old rxmode flags
Date: Tue, 22 May 2018 02:50:31 +0000 [thread overview]
Message-ID: <94479800C636CB44BD422CB454846E0132160E54@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20180522010120.5187-1-qi.z.zhang@intel.com>
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Tuesday, May 22, 2018 9:01 AM
> To: Yigit, Ferruh <ferruh.yigit@intel.com>
> Cc: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Subject: [PATCH] net/i40e: remove dependency on old rxmode flags
>
> Cleanup remain dependency on old rxmode flags since we move to new
> offload APIs.
>
> Fixes: c3ac7c5b0b8a ("net/i40e: convert to new Rx offloads API")
> Fixes: e0cb96204b71 ("net/i40e: add support for representor ports")
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/i40e/i40e_rxtx_vec_common.h | 4 ++--
> drivers/net/i40e/i40e_vf_representor.c | 6 ++++--
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h
> b/drivers/net/i40e/i40e_rxtx_vec_common.h
> index 3ffedcb9e..63cb17742 100644
> --- a/drivers/net/i40e/i40e_rxtx_vec_common.h
> +++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
> @@ -202,11 +202,11 @@
> i40e_rx_vec_dev_conf_condition_check_default(struct rte_eth_dev *dev)
> /* - no csum error report support
> * - no header split support
> */
> - if (rxmode->header_split == 1)
> + if (rxmode->offloads & DEV_RX_OFFLOAD_HEADER_SPLIT)
> return -1;
>
> /* no QinQ support */
> - if (rxmode->hw_vlan_extend == 1)
> + if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_EXTEND)
> return -1;
>
> return 0;
> diff --git a/drivers/net/i40e/i40e_vf_representor.c
> b/drivers/net/i40e/i40e_vf_representor.c
> index 8dc94b479..f9f131611 100644
> --- a/drivers/net/i40e/i40e_vf_representor.c
> +++ b/drivers/net/i40e/i40e_vf_representor.c
> @@ -378,7 +378,8 @@ i40e_vf_representor_vlan_offload_set(struct
> rte_eth_dev *ethdev, int mask)
>
> if (mask & ETH_VLAN_FILTER_MASK) {
> /* Enable or disable VLAN filtering offload */
> - if (ethdev->data->dev_conf.rxmode.hw_vlan_filter)
> + if (ethdev->data->dev_conf.rxmode.offloads &
> + DEV_RX_OFFLOAD_VLAN_FILTER)
> return i40e_vsi_config_vlan_filter(vsi, TRUE);
> else
> return i40e_vsi_config_vlan_filter(vsi, FALSE); @@ -
> 386,7 +387,8 @@ i40e_vf_representor_vlan_offload_set(struct rte_eth_dev
> *ethdev, int mask)
>
> if (mask & ETH_VLAN_STRIP_MASK) {
> /* Enable or disable VLAN stripping offload */
> - if (ethdev->data->dev_conf.rxmode.hw_vlan_strip)
> + if (ethdev->data->dev_conf.rxmode.offloads &
> + DEV_RX_OFFLOAD_VLAN_STRIP)
> return i40e_vsi_config_vlan_stripping(vsi, TRUE);
> else
> return i40e_vsi_config_vlan_stripping(vsi, FALSE);
> --
> 2.13.6
Acked-by: Beilei Xing <beilei.xing@intel.com>
next prev parent reply other threads:[~2018-05-22 2:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-22 1:01 Qi Zhang
2018-05-22 2:50 ` Xing, Beilei [this message]
2018-05-22 11:36 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94479800C636CB44BD422CB454846E0132160E54@SHSMSX101.ccr.corp.intel.com \
--to=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).