* [dpdk-dev] dev stop and buffer releases
@ 2016-04-12 5:19 Vithal Mohare
0 siblings, 0 replies; only message in thread
From: Vithal Mohare @ 2016-04-12 5:19 UTC (permalink / raw)
To: dev
Team,
Hit a crash while vmxnet_xmit_pkts()-->vmxnet3_tq_tx_complete() API trying to release completed buffers.
As we see in the code, there are two independent paths that clean up completed buffers: 1) vmxnet3_xmit_pkts 2) vmxnet3_dev_stop. In a multi-threaded environment potentially this can cause issues since queues/buffers not guarded with any locks. Specifically, in my case, one thread handles admin messages like port shut and hence triggers vmxnet3_dev_stop. Another thread for forwarding (vmxnet3_xmit_pkts). Isn't this a candidate for introducing locks within drivers? Any other suggestions to handle it?
Thanks,
-Vithal
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-04-12 5:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-12 5:19 [dpdk-dev] dev stop and buffer releases Vithal Mohare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).