From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Yang, Qiming" <qiming.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yang, Qiming" <qiming.yang@intel.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] net/i40e: fix VF bonded device link down
Date: Mon, 24 Oct 2016 09:50:40 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F80E293AE1@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1476338840-50003-2-git-send-email-qiming.yang@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qiming Yang
> Sent: Thursday, October 13, 2016 2:07 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>
> Subject: [dpdk-dev] [PATCH 2/2] net/i40e: fix VF bonded device link down
>
> Originally, using DPDK as host driver, when VF bonded device
> uses I40E_VIRTCHNL_OP_GET_LINK_STAT to query PF the link status,
If VF device is used as slave of a bond device, it will be polled periodically though alarm. Interrupt is involved here.
And then VF will send I40E_VIRTCHNL_OP_GET_LINK_STAT message to PF to get the status. The response is handled by interrupt callback. Interrupt is involved here again. That's what bond device cannot bring up.
> This patch uses PF to notify link status instead of VF query.
This patch changes like that remove I40E_VIRTCHNL_OP_GET_LINK_STAT message, link status in VF driver is updated when PF driver notify it, and VF stores the links status locally. VF driver just returns the local status when being required.
> Fixes: 5c9222058df7 ("i40e: move to drivers/net/")
The same comments as your previous patch. It is not exact commit introduced this issue.
Thanks
Jingjing
next prev parent reply other threads:[~2016-10-24 9:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-13 6:07 [dpdk-dev] [PATCH 1/2] net/i40e: fix link status change interrupt Qiming Yang
2016-10-13 6:07 ` [dpdk-dev] [PATCH 2/2] net/i40e: fix VF bonded device link down Qiming Yang
2016-10-24 9:50 ` Wu, Jingjing [this message]
2016-10-19 10:56 ` [dpdk-dev] [PATCH 1/2] net/i40e: fix link status change interrupt Ferruh Yigit
2016-10-24 2:21 ` Yang, Qiming
2016-10-24 9:32 ` Wu, Jingjing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F80E293AE1@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=dev@dpdk.org \
--cc=qiming.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).