From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Jastrzebski, MichalX K" <michalx.k.jastrzebski@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Jain, Deepak K" <deepak.k.jain@intel.com>,
"Kulasek, TomaszX" <tomaszx.kulasek@intel.com>,
"Chilikin, Andrey" <andrey.chilikin@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix runtime dead code
Date: Fri, 29 Sep 2017 14:25:28 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F810E83FB9@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <20170929125656.33164-1-michalx.k.jastrzebski@intel.com>
> -----Original Message-----
> From: Jastrzebski, MichalX K
> Sent: Friday, September 29, 2017 8:57 PM
> To: Wu, Jingjing <jingjing.wu@intel.com>
> Cc: dev@dpdk.org; Jain, Deepak K <deepak.k.jain@intel.com>; Kulasek, TomaszX
> <tomaszx.kulasek@intel.com>; Chilikin, Andrey <andrey.chilikin@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] app/testpmd: fix runtime dead code
>
> From: Tomasz Kulasek <tomaszx.kulasek@intel.com>
>
> Coverity reports DEADCODE, as assumes that RTE_LIBRTE_I40E_PMD
> is defined and function compiles entirely.
> The fix is about to place printf function into #else branch
> of conditional compilation, since it is known at compile
> time if i40e is supported. No need to check it at runtime.
>
> Coverity issue: 158646
> Fixes: 37a56cce7b8e ("app/testpmd: enable DDP get info feature")
> Cc: andrey.chilikin@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
Acked-by: Jingjing Wu <jingjing.wu@intel.com>
next prev parent reply other threads:[~2017-09-29 14:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-29 12:56 Michal Jastrzebski
2017-09-29 14:25 ` Wu, Jingjing [this message]
2017-10-12 19:28 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2017-10-13 1:36 ` Wu, Jingjing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F810E83FB9@SHSMSX103.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=andrey.chilikin@intel.com \
--cc=deepak.k.jain@intel.com \
--cc=dev@dpdk.org \
--cc=michalx.k.jastrzebski@intel.com \
--cc=stable@dpdk.org \
--cc=tomaszx.kulasek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).