DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH][PMD][GENERIC_FILTER] add NIC filters support for generic filter feature
Date: Tue, 20 May 2014 00:55:11 +0000	[thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F8A761EA@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <2436549.UhLCUXjEFZ@xps13>

Fine, I will split it.

-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] 
Sent: Monday, May 19, 2014 6:17 PM
To: Wu, Jingjing
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH][PMD][GENERIC_FILTER] add NIC filters support for generic filter feature

Hi Jingjing,

2014-05-17 17:35, Jingjing Wu:
> A generic filter mechanism for handling special packet is required. It 
> will allows filters  to be set in HW when available for so that 
> specific packets may be filtered by NICs to specific desriptor queues for processing.
> Currently only the Flow Director for Intel's 10GbE 82599 devices is 
> available. Other types of filter  are not supported.
> 
> This pacth adds following NIC filters used to assign different packets 
> to certain receive queues. ethertype filter/syn filter/2tuple 
> filter/flex filter for E1000(82580, i350) ethertype filter/syn 
> filter/5tuple filter for
> 10G(82599)
> 
> Signed-off-by: jingjing.wu <jingjing.wu@intel.com>
> ---
>  app/test-pmd/cmdline.c              | 905
> +++++++++++++++++++++++++++++++++++- app/test-pmd/config.c               |
> 143 ++++++
>  app/test-pmd/testpmd.h              |   6 +
>  lib/librte_ether/rte_ethdev.c       | 300 ++++++++++++
>  lib/librte_ether/rte_ethdev.h       | 429 ++++++++++++++++-
>  lib/librte_pmd_e1000/e1000_ethdev.h |  38 ++
>  lib/librte_pmd_e1000/igb_ethdev.c   | 512 ++++++++++++++++++++
>  lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 365 +++++++++++++++  
> lib/librte_pmd_ixgbe/ixgbe_ethdev.h |  33 ++
>  9 files changed, 2729 insertions(+), 2 deletions(-)

It would be really easier to review if you split it in 4 parts:
- ethdev API
- igb implementation
- ixgbe implementation
- testpmd

Thanks
--
Thomas

      reply	other threads:[~2014-05-20  0:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-17  9:35 Jingjing Wu
2014-05-19 10:17 ` Thomas Monjalon
2014-05-20  0:55   ` Wu, Jingjing [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9BB6961774997848B5B42BEC655768F8A761EA@SHSMSX104.ccr.corp.intel.com \
    --to=jingjing.wu@intel.com \
    --cc=dev@dpdk.org \
    --cc=thomas.monjalon@6wind.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).