From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: 'Thomas Monjalon' <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] llib/ibrte_net: workaround to avoid macro conflict
Date: Thu, 9 Oct 2014 05:17:31 +0000 [thread overview]
Message-ID: <9BB6961774997848B5B42BEC655768F8B04AFE@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1916931.VRG6JyPOdY@xps13>
Hi, Thomas
The reason why I didn't remover all the macros in rte_ip.h is:
netinet/in.h contains a lot of extra references to the sockets definitions, some external functions declarations, etc. These are useless some DPDK applications, such as classification.
rte_ip.h provides a more simplify way for the IP protocol layer.
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Tuesday, September 30, 2014 1:08 PM
> To: Wu, Jingjing
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] llib/ibrte_net: workaround to avoid macro conflict
>
> Hi Jingjing,
>
> 2014-09-30 10:49, Jingjing Wu:
> > Macros such as IPPROTO_TCP, IPPROTO_UDP are already defined in <netinet/in.h>.
> > If user's application includes <netinet/in.h> and rte_ip.h at the same time,
> > there will be conflict error.
> >
> > This patch uses the way "#ifndef #endif" to avoid the conflict.
>
> I still think it is not the good approach.
> see http://dpdk.org/ml/archives/dev/2014-August/005006.html
> and http://dpdk.org/ml/archives/dev/2014-August/005026.html
> Why not simply remove these definitions?
>
> --
> Thomas
next prev parent reply other threads:[~2014-10-09 5:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 2:49 Jingjing Wu
2014-09-30 5:07 ` Thomas Monjalon
2014-10-09 5:17 ` Wu, Jingjing [this message]
2014-09-30 13:09 ` Neil Horman
2014-10-09 5:20 ` Wu, Jingjing
2014-10-09 5:37 ` Matthew Hall
2014-10-09 11:29 ` Neil Horman
2014-11-03 7:41 ` Thomas Monjalon
2014-11-17 14:17 ` Neil Horman
2014-11-27 11:48 ` [dpdk-dev] [PATCH] net: fix conflict with libc Thomas Monjalon
2014-11-27 14:03 ` Ivan Boule
2014-11-27 18:13 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9BB6961774997848B5B42BEC655768F8B04AFE@SHSMSX104.ccr.corp.intel.com \
--to=jingjing.wu@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).