DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Wu, Jingjing" <jingjing.wu@intel.com>
To: "Zhang, Helin" <helin.zhang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] i40e: warnings should include i40e in some	example applications
Date: Sat, 11 Oct 2014 08:31:16 +0000
Message-ID: <9BB6961774997848B5B42BEC655768F8B07D44@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1404374093-29710-1-git-send-email-helin.zhang@intel.com>

Acked-by: Jingjing Wu <jingjing.wu@intel.com>

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Helin Zhang
> Sent: Thursday, July 3, 2014 3:55 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] i40e: warnings should include i40e in some example applications
> 
> As i40e introduced recently in DPDK, the warnings should include
> i40e when no supported NIC port found during initialization at
> least in below example applications.
> * app/testpmd
> * exception_path
> * kni
> 
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
> ---
>  app/test-pmd/testpmd.c         | 3 ++-
>  examples/exception_path/main.c | 5 +++--
>  examples/kni/main.c            | 5 +++--
>  3 files changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index e8a4b45..0c0ac77 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -1859,7 +1859,8 @@ main(int argc, char** argv)
>  							"check that "
>  			  "CONFIG_RTE_LIBRTE_IGB_PMD=y and that "
>  			  "CONFIG_RTE_LIBRTE_EM_PMD=y and that "
> -			  "CONFIG_RTE_LIBRTE_IXGBE_PMD=y in your "
> +			  "CONFIG_RTE_LIBRTE_IXGBE_PMD=y and that "
> +			  "CONFIG_RTE_LIBRTE_I40E_PMD=y in your "
>  			  "configuration file\n");
> 
>  	set_def_fwd_config();
> diff --git a/examples/exception_path/main.c b/examples/exception_path/main.c
> index 0204116..c4245a3 100644
> --- a/examples/exception_path/main.c
> +++ b/examples/exception_path/main.c
> @@ -575,8 +575,9 @@ main(int argc, char** argv)
>  	nb_sys_ports = rte_eth_dev_count();
>  	if (nb_sys_ports == 0)
>  		FATAL_ERROR("No supported Ethernet devices found - check that "
> -		            "CONFIG_RTE_LIBRTE_IGB_PMD=y and/or "
> -		            "CONFIG_RTE_LIBRTE_IXGBE_PMD=y in the config file");
> +		            "CONFIG_RTE_LIBRTE_IGB_PMD=y, "
> +		            "CONFIG_RTE_LIBRTE_IXGBE_PMD=y and/or "
> +			    "CONFIG_RTE_LIBRTE_I40E_PMD=y in the config file");
>  	/* Find highest port set in portmask */
>  	for (high_port = (sizeof(ports_mask) * 8) - 1;
>  			(high_port != 0) && !(ports_mask & (1 << high_port));
> diff --git a/examples/kni/main.c b/examples/kni/main.c
> index 7df1b36..f3666e2 100644
> --- a/examples/kni/main.c
> +++ b/examples/kni/main.c
> @@ -898,8 +898,9 @@ main(int argc, char** argv)
>  	nb_sys_ports = rte_eth_dev_count();
>  	if (nb_sys_ports == 0)
>  		rte_exit(EXIT_FAILURE, "No supported Ethernet devices found - "
> -			"check that CONFIG_RTE_LIBRTE_IGB_PMD=y and/or "
> -			"CONFIG_RTE_LIBRTE_IXGBE_PMD=y in the config file\n");
> +			"check that CONFIG_RTE_LIBRTE_IGB_PMD=y, "
> +			"CONFIG_RTE_LIBRTE_IXGBE_PMD=y and/or "
> +			"CONFIG_RTE_LIBRTE_I40E_PMD=y in the config file\n");
> 
>  	/* Check if the configured port ID is valid */
>  	for (i = 0; i < RTE_MAX_ETHPORTS; i++)
> --
> 1.8.1.4

  reply	other threads:[~2014-10-11  8:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-03  7:54 Helin Zhang
2014-10-11  8:31 ` Wu, Jingjing [this message]
2014-11-07 12:48 ` Thomas Monjalon
2014-11-07 12:48 ` [dpdk-dev] [PATCH] app, examples: remove references to drivers config Thomas Monjalon
2014-11-07 23:26   ` Zhang, Helin
2014-11-10  9:11     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9BB6961774997848B5B42BEC655768F8B07D44@SHSMSX104.ccr.corp.intel.com \
    --to=jingjing.wu@intel.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git