Re: [dpdk-dev] [PATCH v2 0/6] cfgfile: config file parsing extension

["Gajdzica, MaciejX T" <maciejx.t.gajdzica@intel.com>]

> -----Original Message-----
> From: Gajdzica, MaciejX T
> Sent: Wednesday, June 17, 2015 4:49 PM
> To: dev@dpdk.org
> Cc: Gajdzica, MaciejX T
> Subject: [PATCH v2 0/6] cfgfile: config file parsing extension
> 
> Added new implementation of section parsing in config file. Refactored existing
> code by spliting it to smaller functions. Changed section allocation scheme and
> added new features  - variable length entry value and line continue character '\'.
> 
> Pawel Wodkowski (6):
>   librte_cfgfile: fix code formating in header file
>   librte_compat: fix macro definition
>   cfgfile: split rte_cfgfile_load to smaller functions
>   cfgfile: added line continue character '\' to make multiline values
>       possible
>   cfgfile: fixed calling free for each section in rte_cfgfile_close
>   cfgfile: added new implementation of section parsing
> 
>  lib/librte_cfgfile/Makefile                |    2 +-
>  lib/librte_cfgfile/rte_cfgfile.c           |  793 +++++++++++++++++++++-------
>  lib/librte_cfgfile/rte_cfgfile.h           |   52 +-
>  lib/librte_cfgfile/rte_cfgfile_version.map |    8 +
>  lib/librte_compat/rte_compat.h             |    8 +-
>  5 files changed, 653 insertions(+), 210 deletions(-)
> 
> --
> 1.7.9.5

NACK - After reviewing this patchset, we decided that those changes are not acceptable in current form.
New section allocation scheme doesn't add much value. Also new implementation of rte_cfgfile_entry with
static string for name and dynamic for value may cause confusion. We will go back to cfgfile improvements in 2.2.

Best Regards
Maciek