* [dpdk-dev] [PATCH] net/e1000: fix checksum valid flags error
@ 2017-05-02 2:46 Wei Zhao
2017-05-02 8:13 ` Lu, Wenzhuo
2017-05-02 8:42 ` [dpdk-dev] [PATCH v2] " Wei Zhao
0 siblings, 2 replies; 7+ messages in thread
From: Wei Zhao @ 2017-05-02 2:46 UTC (permalink / raw)
To: dev; +Cc: wenzhuo.lu, Wei Zhao
This problem is caused by a missing set of E1000_RXCSUM_CRCOFL
in eth_igb_rx_init(), it should be set to enable SCTP packet
L4 checksum.If it is not set, the printf message in cksum fwd
about L4 SCTP cksum flag is error.
Fixes: d15fcf76c8b7 ("net/e1000: move to drivers/net/")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
drivers/net/e1000/igb_rxtx.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c
index b3b601b..6c2749b 100644
--- a/drivers/net/e1000/igb_rxtx.c
+++ b/drivers/net/e1000/igb_rxtx.c
@@ -2402,10 +2402,11 @@ eth_igb_rx_init(struct rte_eth_dev *dev)
/* Enable both L3/L4 rx checksum offload */
if (dev->data->dev_conf.rxmode.hw_ip_checksum)
- rxcsum |= (E1000_RXCSUM_IPOFL | E1000_RXCSUM_TUOFL);
+ rxcsum |= (E1000_RXCSUM_IPOFL | E1000_RXCSUM_TUOFL |
+ E1000_RXCSUM_CRCOFL);
else
- rxcsum &= ~(E1000_RXCSUM_IPOFL | E1000_RXCSUM_TUOFL);
- E1000_WRITE_REG(hw, E1000_RXCSUM, rxcsum);
+ rxcsum &= ~(E1000_RXCSUM_IPOFL | E1000_RXCSUM_TUOFL |
+ E1000_RXCSUM_CRCOFL);
/* Setup the Receive Control Register. */
if (dev->data->dev_conf.rxmode.hw_strip_crc) {
--
2.9.3
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH] net/e1000: fix checksum valid flags error
2017-05-02 2:46 [dpdk-dev] [PATCH] net/e1000: fix checksum valid flags error Wei Zhao
@ 2017-05-02 8:13 ` Lu, Wenzhuo
2017-05-02 8:40 ` Zhao1, Wei
2017-05-02 8:42 ` [dpdk-dev] [PATCH v2] " Wei Zhao
1 sibling, 1 reply; 7+ messages in thread
From: Lu, Wenzhuo @ 2017-05-02 8:13 UTC (permalink / raw)
To: Zhao1, Wei, dev
Hi Wei,
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Tuesday, May 2, 2017 10:46 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo; Zhao1, Wei
> Subject: [PATCH] net/e1000: fix checksum valid flags error
>
> This problem is caused by a missing set of E1000_RXCSUM_CRCOFL in
> eth_igb_rx_init(), it should be set to enable SCTP packet
> L4 checksum.If it is not set, the printf message in cksum fwd about L4 SCTP
> cksum flag is error.
It's not quite clear what's the issue. Would you like to add more details? Thanks.
>
> Fixes: d15fcf76c8b7 ("net/e1000: move to drivers/net/")
Seems it's not the right patch. Suppose this patch only moves the files.
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
> drivers/net/e1000/igb_rxtx.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c index
> b3b601b..6c2749b 100644
> --- a/drivers/net/e1000/igb_rxtx.c
> +++ b/drivers/net/e1000/igb_rxtx.c
> @@ -2402,10 +2402,11 @@ eth_igb_rx_init(struct rte_eth_dev *dev)
>
> /* Enable both L3/L4 rx checksum offload */
> if (dev->data->dev_conf.rxmode.hw_ip_checksum)
> - rxcsum |= (E1000_RXCSUM_IPOFL | E1000_RXCSUM_TUOFL);
> + rxcsum |= (E1000_RXCSUM_IPOFL | E1000_RXCSUM_TUOFL |
> + E1000_RXCSUM_CRCOFL);
> else
> - rxcsum &= ~(E1000_RXCSUM_IPOFL | E1000_RXCSUM_TUOFL);
> - E1000_WRITE_REG(hw, E1000_RXCSUM, rxcsum);
> + rxcsum &= ~(E1000_RXCSUM_IPOFL | E1000_RXCSUM_TUOFL
> |
> + E1000_RXCSUM_CRCOFL);
>
> /* Setup the Receive Control Register. */
> if (dev->data->dev_conf.rxmode.hw_strip_crc) {
> --
> 2.9.3
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH] net/e1000: fix checksum valid flags error
2017-05-02 8:13 ` Lu, Wenzhuo
@ 2017-05-02 8:40 ` Zhao1, Wei
0 siblings, 0 replies; 7+ messages in thread
From: Zhao1, Wei @ 2017-05-02 8:40 UTC (permalink / raw)
To: Lu, Wenzhuo, dev
Hi, wenzhuo
> -----Original Message-----
> From: Lu, Wenzhuo
> Sent: Tuesday, May 2, 2017 4:14 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Subject: RE: [PATCH] net/e1000: fix checksum valid flags error
>
> Hi Wei,
>
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Tuesday, May 2, 2017 10:46 AM
> > To: dev@dpdk.org
> > Cc: Lu, Wenzhuo; Zhao1, Wei
> > Subject: [PATCH] net/e1000: fix checksum valid flags error
> >
> > This problem is caused by a missing set of E1000_RXCSUM_CRCOFL in
> > eth_igb_rx_init(), it should be set to enable SCTP packet
> > L4 checksum.If it is not set, the printf message in cksum fwd about L4
> > SCTP cksum flag is error.
> It's not quite clear what's the issue. Would you like to add more details?
> Thanks.
>
> >
> > Fixes: d15fcf76c8b7 ("net/e1000: move to drivers/net/")
> Seems it's not the right patch. Suppose this patch only moves the files.
I will fix it in v2.
>
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> > drivers/net/e1000/igb_rxtx.c | 7 ++++---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/e1000/igb_rxtx.c
> > b/drivers/net/e1000/igb_rxtx.c index b3b601b..6c2749b 100644
> > --- a/drivers/net/e1000/igb_rxtx.c
> > +++ b/drivers/net/e1000/igb_rxtx.c
> > @@ -2402,10 +2402,11 @@ eth_igb_rx_init(struct rte_eth_dev *dev)
> >
> > /* Enable both L3/L4 rx checksum offload */
> > if (dev->data->dev_conf.rxmode.hw_ip_checksum)
> > - rxcsum |= (E1000_RXCSUM_IPOFL |
> E1000_RXCSUM_TUOFL);
> > + rxcsum |= (E1000_RXCSUM_IPOFL | E1000_RXCSUM_TUOFL
> |
> > + E1000_RXCSUM_CRCOFL);
> > else
> > - rxcsum &= ~(E1000_RXCSUM_IPOFL |
> E1000_RXCSUM_TUOFL);
> > - E1000_WRITE_REG(hw, E1000_RXCSUM, rxcsum);
> > + rxcsum &= ~(E1000_RXCSUM_IPOFL |
> E1000_RXCSUM_TUOFL
> > |
> > + E1000_RXCSUM_CRCOFL);
> >
> > /* Setup the Receive Control Register. */
> > if (dev->data->dev_conf.rxmode.hw_strip_crc) {
> > --
> > 2.9.3
^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-dev] [PATCH v2] net/e1000: fix checksum valid flags error
2017-05-02 2:46 [dpdk-dev] [PATCH] net/e1000: fix checksum valid flags error Wei Zhao
2017-05-02 8:13 ` Lu, Wenzhuo
@ 2017-05-02 8:42 ` Wei Zhao
2017-05-31 3:03 ` [dpdk-dev] [PATCH v3] " Wei Zhao
1 sibling, 1 reply; 7+ messages in thread
From: Wei Zhao @ 2017-05-02 8:42 UTC (permalink / raw)
To: dev; +Cc: wenzhuo.lu, Wei Zhao
This problem is caused by a missing set of E1000_RXCSUM_CRCOFL
in eth_igb_rx_init(), it should be set to enable SCTP packet
L4 checksum.If it is not set, the printf message in cksum fwd
about L4 SCTP cksum flag is error.
Fixes: af75078fece3 ("first public release")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
Changes in v2:
fix patch log error in fixes information.
---
drivers/net/e1000/igb_rxtx.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c
index b3b601b..6c2749b 100644
--- a/drivers/net/e1000/igb_rxtx.c
+++ b/drivers/net/e1000/igb_rxtx.c
@@ -2402,10 +2402,11 @@ eth_igb_rx_init(struct rte_eth_dev *dev)
/* Enable both L3/L4 rx checksum offload */
if (dev->data->dev_conf.rxmode.hw_ip_checksum)
- rxcsum |= (E1000_RXCSUM_IPOFL | E1000_RXCSUM_TUOFL);
+ rxcsum |= (E1000_RXCSUM_IPOFL | E1000_RXCSUM_TUOFL |
+ E1000_RXCSUM_CRCOFL);
else
- rxcsum &= ~(E1000_RXCSUM_IPOFL | E1000_RXCSUM_TUOFL);
- E1000_WRITE_REG(hw, E1000_RXCSUM, rxcsum);
+ rxcsum &= ~(E1000_RXCSUM_IPOFL | E1000_RXCSUM_TUOFL |
+ E1000_RXCSUM_CRCOFL);
/* Setup the Receive Control Register. */
if (dev->data->dev_conf.rxmode.hw_strip_crc) {
--
2.9.3
^ permalink raw reply [flat|nested] 7+ messages in thread* [dpdk-dev] [PATCH v3] net/e1000: fix checksum valid flags error
2017-05-02 8:42 ` [dpdk-dev] [PATCH v2] " Wei Zhao
@ 2017-05-31 3:03 ` Wei Zhao
2017-05-31 3:35 ` Lu, Wenzhuo
0 siblings, 1 reply; 7+ messages in thread
From: Wei Zhao @ 2017-05-31 3:03 UTC (permalink / raw)
To: dev; +Cc: wenzhuo.lu, Wei Zhao
This problem is caused by a missing set of E1000_RXCSUM_CRCOFL
in eth_igb_rx_init(), it should be set to enable SCTP packet
L4 checksum.If it is not set, the printf message in cksum fwd
about L4 SCTP cksum flag is error.for example, even if the sctp
packet is not do L4 checksum, the print message is always
PKT_RX_L4_CKSUM_GOOD.
Fixes: af75078fece3 ("first public release")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
Changes in v2:
add more log for details.
Changes in v3:
fix a typo error.
---
drivers/net/e1000/igb_rxtx.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c
index b3b601b..1c80a2a 100644
--- a/drivers/net/e1000/igb_rxtx.c
+++ b/drivers/net/e1000/igb_rxtx.c
@@ -2402,9 +2402,11 @@ eth_igb_rx_init(struct rte_eth_dev *dev)
/* Enable both L3/L4 rx checksum offload */
if (dev->data->dev_conf.rxmode.hw_ip_checksum)
- rxcsum |= (E1000_RXCSUM_IPOFL | E1000_RXCSUM_TUOFL);
+ rxcsum |= (E1000_RXCSUM_IPOFL | E1000_RXCSUM_TUOFL |
+ E1000_RXCSUM_CRCOFL);
else
- rxcsum &= ~(E1000_RXCSUM_IPOFL | E1000_RXCSUM_TUOFL);
+ rxcsum &= ~(E1000_RXCSUM_IPOFL | E1000_RXCSUM_TUOFL |
+ E1000_RXCSUM_CRCOFL);
E1000_WRITE_REG(hw, E1000_RXCSUM, rxcsum);
/* Setup the Receive Control Register. */
--
2.7.4
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH v3] net/e1000: fix checksum valid flags error
2017-05-31 3:03 ` [dpdk-dev] [PATCH v3] " Wei Zhao
@ 2017-05-31 3:35 ` Lu, Wenzhuo
2017-06-01 11:08 ` Ferruh Yigit
0 siblings, 1 reply; 7+ messages in thread
From: Lu, Wenzhuo @ 2017-05-31 3:35 UTC (permalink / raw)
To: Zhao1, Wei, dev
Hi,
> -----Original Message-----
> From: Zhao1, Wei
> Sent: Wednesday, May 31, 2017 11:03 AM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo; Zhao1, Wei
> Subject: [PATCH v3] net/e1000: fix checksum valid flags error
>
> This problem is caused by a missing set of E1000_RXCSUM_CRCOFL in
> eth_igb_rx_init(), it should be set to enable SCTP packet
> L4 checksum.If it is not set, the printf message in cksum fwd about L4 SCTP
> cksum flag is error.for example, even if the sctp packet is not do L4 checksum,
> the print message is always PKT_RX_L4_CKSUM_GOOD.
>
> Fixes: af75078fece3 ("first public release")
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH v3] net/e1000: fix checksum valid flags error
2017-05-31 3:35 ` Lu, Wenzhuo
@ 2017-06-01 11:08 ` Ferruh Yigit
0 siblings, 0 replies; 7+ messages in thread
From: Ferruh Yigit @ 2017-06-01 11:08 UTC (permalink / raw)
To: Lu, Wenzhuo, Zhao1, Wei, dev
On 5/31/2017 4:35 AM, Lu, Wenzhuo wrote:
> Hi,
>
>
>> -----Original Message-----
>> From: Zhao1, Wei
>> Sent: Wednesday, May 31, 2017 11:03 AM
>> To: dev@dpdk.org
>> Cc: Lu, Wenzhuo; Zhao1, Wei
>> Subject: [PATCH v3] net/e1000: fix checksum valid flags error
>>
>> This problem is caused by a missing set of E1000_RXCSUM_CRCOFL in
>> eth_igb_rx_init(), it should be set to enable SCTP packet
>> L4 checksum.If it is not set, the printf message in cksum fwd about L4 SCTP
>> cksum flag is error.for example, even if the sctp packet is not do L4 checksum,
>> the print message is always PKT_RX_L4_CKSUM_GOOD.
>>
>> Fixes: af75078fece3 ("first public release")
>>
>> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-06-01 11:08 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-05-02 2:46 [dpdk-dev] [PATCH] net/e1000: fix checksum valid flags error Wei Zhao
2017-05-02 8:13 ` Lu, Wenzhuo
2017-05-02 8:40 ` Zhao1, Wei
2017-05-02 8:42 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2017-05-31 3:03 ` [dpdk-dev] [PATCH v3] " Wei Zhao
2017-05-31 3:35 ` Lu, Wenzhuo
2017-06-01 11:08 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).