From: "Zhao1, Wei" <wei.zhao1@intel.com>
To: "Iremonger, Bernard" <bernard.iremonger@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Peng, Yuan" <yuan.peng@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support more types for flow RSS
Date: Tue, 23 Oct 2018 09:37:52 +0000 [thread overview]
Message-ID: <A2573D2ACFCADC41BB3BE09C6DE313CA07E52DC5@PGSMSX103.gar.corp.intel.com> (raw)
In-Reply-To: <8CEF83825BEC744B83065625E567D7C260D14A10@IRSMSX107.ger.corp.intel.com>
Hi, Iremonger Bernard
> -----Original Message-----
> From: Iremonger, Bernard
> Sent: Monday, October 22, 2018 6:45 PM
> To: Zhao1, Wei <wei.zhao1@intel.com>; dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org; Peng, Yuan
> <yuan.peng@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] app/testpmd: support more types for flow
> RSS
>
> Hi Zhao,
>
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao
> > Sent: Monday, October 22, 2018 8:49 AM
> > To: dev@dpdk.org
> > Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org; Peng, Yuan
> > <yuan.peng@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> > Subject: [dpdk-dev] [PATCH] app/testpmd: support more types for flow
> > RSS
> >
> > Some user and tester require flow RSS to support more types, so and
> > "all" and
>
> typo in commit message "and "all" " should be "add "all""
Yes, I will commit v2 for that.
Thank you!
>
> > "none" to make configuration more easy for users.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > ---
> > app/test-pmd/config.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index
> > bf3cd0a..f068da1 100644
> > --- a/app/test-pmd/config.c
> > +++ b/app/test-pmd/config.c
> > @@ -74,6 +74,10 @@ static const struct { };
> >
> > const struct rss_type_info rss_type_table[] = {
> > + { "all", ETH_RSS_IP | ETH_RSS_TCP |
> > + ETH_RSS_UDP | ETH_RSS_SCTP |
> > + ETH_RSS_L2_PAYLOAD },
> > + { "none", 0 },
> > { "ipv4", ETH_RSS_IPV4 },
> > { "ipv4-frag", ETH_RSS_FRAG_IPV4 },
> > { "ipv4-tcp", ETH_RSS_NONFRAG_IPV4_TCP },
> > --
> > 2.7.5
>
> The "all" and "none" options are already documented in testpmd.
> This looks like a fix, if so should there be a fixes line?
>
Not a fix, this is used by rte_flow command line, not old CLI.
> Regards,
>
> Bernard.
>
next prev parent reply other threads:[~2018-10-23 9:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-22 7:49 Wei Zhao
2018-10-22 10:44 ` Iremonger, Bernard
2018-10-23 9:37 ` Zhao1, Wei [this message]
2018-10-23 6:20 ` Peng, Yuan
2018-10-23 9:20 ` [dpdk-dev] [PATCH v2] " Wei Zhao
2018-10-23 9:50 ` Zhao1, Wei
2018-10-23 10:11 ` Iremonger, Bernard
2018-10-23 14:13 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A2573D2ACFCADC41BB3BE09C6DE313CA07E52DC5@PGSMSX103.gar.corp.intel.com \
--to=wei.zhao1@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=yuan.peng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).