From: "Chilikin, Andrey" <andrey.chilikin@intel.com> To: "Liu, Jijiang" <jijiang.liu@intel.com>, "dev@dpdk.org" <dev@dpdk.org> Subject: Re: [dpdk-dev] [PATCH v6 5/9] librte_ether:add data structures of VxLAN filter Date: Thu, 23 Oct 2014 09:06:30 +0000 Message-ID: <AAC06825A3B29643AF5372F5E0DDF0533500D140@IRSMSX106.ger.corp.intel.com> (raw) In-Reply-To: <1ED644BD7E0A5F4091CF203DAFB8E4CC01D829F1@SHSMSX101.ccr.corp.intel.com> For me these defines make perfect sense - tunnelling filters require combinations of different tunnel components, but not all combinations are valid. So defining valid combinations separately helps. Regards, Andrey > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Wednesday, October 22, 2014 5:31 PM > To: Liu, Jijiang > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v6 5/9] librte_ether:add data > structures of VxLAN filter > > 2014-10-22 02:25, Liu, Jijiang: > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > 2014-10-21 16:46, Jijiang Liu: > > > > +#define RTE_TUNNEL_FILTER_IMAC_IVLAN (ETH_TUNNEL_FILTER_IMAC > | \ > > > > + ETH_TUNNEL_FILTER_IVLAN) > > > > +#define RTE_TUNNEL_FILTER_IMAC_IVLAN_TENID > (ETH_TUNNEL_FILTER_IMAC | \ > > > > + ETH_TUNNEL_FILTER_IVLAN | \ > > > > + ETH_TUNNEL_FILTER_TENID) > > > > +#define RTE_TUNNEL_FILTER_IMAC_TENID (ETH_TUNNEL_FILTER_IMAC > | \ > > > > + ETH_TUNNEL_FILTER_TENID) > > > > +#define RTE_TUNNEL_FILTER_OMAC_TENID_IMAC > (ETH_TUNNEL_FILTER_OMAC | \ > > > > + ETH_TUNNEL_FILTER_TENID | \ > > > > + ETH_TUNNEL_FILTER_IMAC) > > > > > > I thought you agree that these definitions are useless? > > > > Sorry, this MAY be some misunderstanding, I don't think these > > definition are useless. I just thought change "uint16_t filter_type" > > is better than define "enum filter_type". > > > > Let me explain here again. > > The filter condition are: > > 1. inner MAC + inner VLAN > > 2. inner MAC + IVLAN + tenant ID > > .. > > 5. outer MAC + tenant ID + inner MAC > > > > For each filter condition, we need to check if the mandatory > > parameters are valid by checking corresponding bit MASK. > > Checking bit mask doesn't imply to define all combinations of bit masks. > There's probably something obvious that one of us is missing. Anybody else have comments on this? > > An pseudo code example: > > > > Switch (filter_type) > > Case 1: //inner MAC + inner VLAN > > If (filter_type & ETH_TUNNEL_FILTER_IMAC ) > > if (IMAC==NULL) > > return -1; > > > > case 5: // outer MAC + tenant ID + inner MAC > > If (filter_type & ETH_TUNNEL_FILTER_IMAC ) > > if (IMAC==NULL) > > return -1; > > > > If (filter_type & ETH_TUNNEL_FILTER_OMAC ) > > if (IMAC==NULL) > > return -1; > > ......
next prev parent reply other threads:[~2014-10-23 8:59 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-10-21 8:45 [dpdk-dev] [PATCH v6 0/9] Support VxLAN on Fortville Jijiang Liu 2014-10-21 8:46 ` [dpdk-dev] [PATCH v6 1/9] librte_mbuf:the rte_mbuf structure changes Jijiang Liu 2014-10-21 10:26 ` Thomas Monjalon 2014-10-21 14:14 ` Liu, Jijiang 2014-10-22 8:45 ` Thomas Monjalon 2014-10-22 8:53 ` Liu, Jijiang 2014-10-23 2:23 ` Zhang, Helin 2014-11-12 13:26 ` Thomas Monjalon 2014-11-12 14:31 ` Zhang, Helin 2014-11-12 15:23 ` Thomas Monjalon 2014-11-13 3:17 ` Liu, Jijiang 2014-11-13 8:53 ` Thomas Monjalon 2014-11-13 11:24 ` Liu, Jijiang 2014-11-13 11:35 ` Thomas Monjalon 2014-10-21 8:46 ` [dpdk-dev] [PATCH v6 2/9] librte_ether:add VxLAN packet identification API in librte_ether Jijiang Liu 2014-10-21 10:51 ` Thomas Monjalon 2014-10-21 13:48 ` Liu, Jijiang 2014-10-21 21:19 ` Thomas Monjalon 2014-10-22 1:46 ` Liu, Jijiang 2014-10-22 9:52 ` Thomas Monjalon 2014-10-22 12:47 ` Liu, Jijiang 2014-10-22 13:25 ` Thomas Monjalon 2014-10-22 5:21 ` Liu, Jijiang 2014-10-21 8:46 ` [dpdk-dev] [PATCH v6 3/9] i40e:support VxLAN packet identification in librte_pmd_i40e Jijiang Liu 2014-10-21 8:46 ` [dpdk-dev] [PATCH v6 4/9] app/test-pmd:test VxLAN packet identification Jijiang Liu 2014-10-21 8:46 ` [dpdk-dev] [PATCH v6 5/9] librte_ether:add data structures of VxLAN filter Jijiang Liu 2014-10-21 15:13 ` Thomas Monjalon 2014-10-22 2:25 ` Liu, Jijiang 2014-10-22 9:31 ` Thomas Monjalon 2014-10-22 11:03 ` Liu, Jijiang 2014-10-23 9:06 ` Chilikin, Andrey [this message] 2014-10-22 6:45 ` Liu, Jijiang 2014-10-22 9:25 ` Thomas Monjalon 2014-10-22 13:54 ` Liu, Jijiang 2014-10-21 8:46 ` [dpdk-dev] [PATCH v6 6/9] i40e:implement API of VxLAN packet filter in librte_pmd_i40e Jijiang Liu 2014-10-21 8:46 ` [dpdk-dev] [PATCH v6 7/9] app/testpmd:test VxLAN packet filter Jijiang Liu 2014-10-21 8:46 ` [dpdk-dev] [PATCH v6 8/9] i40e:support VxLAN Tx checksum offload Jijiang Liu 2014-10-21 8:46 ` [dpdk-dev] [PATCH v6 9/9] app/testpmd:test " Jijiang Liu 2014-10-21 14:54 ` [dpdk-dev] [PATCH v6 0/9] Support VxLAN on Fortville Liu, Yong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AAC06825A3B29643AF5372F5E0DDF0533500D140@IRSMSX106.ger.corp.intel.com \ --to=andrey.chilikin@intel.com \ --cc=dev@dpdk.org \ --cc=jijiang.liu@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git