From: Shahaf Shuler <shahafs@mellanox.com>
To: Rami Rosen <ramirose@gmail.com>, Thomas Monjalon <thomas@monjalon.net>
Cc: Yongseok Koh <yskoh@mellanox.com>, dev <dev@dpdk.org>,
Ophir Munk <ophirmu@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: call generic strlcpy
Date: Thu, 7 Mar 2019 08:35:57 +0000 [thread overview]
Message-ID: <AM0PR0502MB37955587204D82FD203C5CA8C34C0@AM0PR0502MB3795.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <CAHLOa7SAfEWJn3LoKwOVAEbdhHYEe-3xvOac6ZJOSWFxHSyC-g@mail.gmail.com>
Applied to next-net-mlx, thanks.
From: Rami Rosen <ramirose@gmail.com>
Sent: Monday, February 25, 2019 8:26 AM
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Shahaf Shuler <shahafs@mellanox.com>; Yongseok Koh <yskoh@mellanox.com>; dev <dev@dpdk.org>; Ophir Munk <ophirmu@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: call generic strlcpy
Checked on Fedora 28
Reviewed-by: Rami Rosen <ramirose at gmail.com<https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgmail.com&data=02%7C01%7Cshahafs%40mellanox.com%7Ca6471d19ffc94a63e8f308d69aea31bf%7Ca652971c7d2e4d9ba6a4d149256f461b%7C0%7C0%7C636866727983375321&sdata=JE%2BULD6LG98IBEf6D%2F3bW98LivPLm2QD7xlshkdQDdc%3D&reserved=0>>
On Mon, Feb 25, 2019 at 12:42 AM Thomas Monjalon <thomas@monjalon.net<mailto:thomas@monjalon.net>> wrote:
The call to strlcpy uses either libc, libbsd or internal rte_strlcpy.
No need to call the DPDK flavor explictly.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net<mailto:thomas@monjalon.net>>
---
drivers/net/mlx5/mlx5.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c
index df71707ccb..bda909eaa5 100644
--- a/drivers/net/mlx5/mlx5.c
+++ b/drivers/net/mlx5/mlx5.c
@@ -785,7 +785,7 @@ mlx5_dev_spawn(struct rte_device *dpdk_dev,
}
/* Build device name. */
if (!switch_info->representor)
- rte_strlcpy(name, dpdk_dev->name, sizeof(name));
+ strlcpy(name, dpdk_dev->name, sizeof(name));
else
snprintf(name, sizeof(name), "%s_representor_%u",
dpdk_dev->name, switch_info->port_name);
--
2.20.1
--
regards,
Rami Rosen
prev parent reply other threads:[~2019-03-07 8:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-24 22:42 Thomas Monjalon
2019-02-25 6:26 ` Rami Rosen
2019-03-07 8:35 ` Shahaf Shuler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR0502MB37955587204D82FD203C5CA8C34C0@AM0PR0502MB3795.eurprd05.prod.outlook.com \
--to=shahafs@mellanox.com \
--cc=dev@dpdk.org \
--cc=ophirmu@mellanox.com \
--cc=ramirose@gmail.com \
--cc=thomas@monjalon.net \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).