DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/mlx4: fix creation of flow rule w/o ETH spec
@ 2019-01-17 12:12 Dekel Peled
  2019-01-21  7:33 ` Shahaf Shuler
  0 siblings, 1 reply; 2+ messages in thread
From: Dekel Peled @ 2019-01-17 12:12 UTC (permalink / raw)
  To: matan, shahafs; +Cc: dev, orika, dekelp

The original commit enabled the creation of flow rule with empty
ETH address and with specific VLAN.
It works fine on PF, but such flow rule is still rejected on VF due
to kernel limitation, which blocks MAC address of all zeroes.

This patch complements the original commit.
It sets byte 0 of MAC address to 0xFF.

Fixes: c0d239263156 ("net/mlx4: support flow w/o ETH spec and with VLAN")
Cc: dekelp@mellanox.com

Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
 drivers/net/mlx4/mlx4_flow.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c
index 6c927a6..3abde30 100644
--- a/drivers/net/mlx4/mlx4_flow.c
+++ b/drivers/net/mlx4/mlx4_flow.c
@@ -248,6 +248,7 @@ struct mlx4_drop {
 		.size = sizeof(*eth),
 	};
 	if (!mask) {
+		eth->val.dst_mac[0] = 0xff;
 		flow->ibv_attr->type = IBV_FLOW_ATTR_ALL_DEFAULT;
 		return 0;
 	}
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx4: fix creation of flow rule w/o ETH spec
  2019-01-17 12:12 [dpdk-dev] [PATCH] net/mlx4: fix creation of flow rule w/o ETH spec Dekel Peled
@ 2019-01-21  7:33 ` Shahaf Shuler
  0 siblings, 0 replies; 2+ messages in thread
From: Shahaf Shuler @ 2019-01-21  7:33 UTC (permalink / raw)
  To: Dekel Peled, Matan Azrad; +Cc: dev, Ori Kam, Dekel Peled

Thursday, January 17, 2019 2:12 PM, Dekel Peled:
> Subject: [dpdk-dev] [PATCH] net/mlx4: fix creation of flow rule w/o ETH spec
> 
> The original commit enabled the creation of flow rule with empty ETH
> address and with specific VLAN.
> It works fine on PF, but such flow rule is still rejected on VF due to kernel
> limitation, which blocks MAC address of all zeroes.
> 
> This patch complements the original commit.
> It sets byte 0 of MAC address to 0xFF.
> 
> Fixes: c0d239263156 ("net/mlx4: support flow w/o ETH spec and with VLAN")
> Cc: dekelp@mellanox.com
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>

Applied to next-net-mlx, thanks. 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-01-21  7:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-17 12:12 [dpdk-dev] [PATCH] net/mlx4: fix creation of flow rule w/o ETH spec Dekel Peled
2019-01-21  7:33 ` Shahaf Shuler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).