From: "Xueming(Steven) Li" <xuemingl@mellanox.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, "Asaf@dpdk.org" <Asaf@dpdk.org>,
Maxime Coquelin <maxime.coquelin@redhat.com>
Subject: Re: [dpdk-dev] [v2] vdpa/mlx5: fix event queue number query
Date: Tue, 28 Jul 2020 12:26:22 +0000 [thread overview]
Message-ID: <AM0PR05MB5204E1EEB5452FA4E794C45BAC730@AM0PR05MB5204.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8ykV4-3h_QV4gJzZL9xMjHWSouguRh8RTLhLtQXmdhdmQ@mail.gmail.com>
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Tuesday, July 28, 2020 8:05 PM
> To: Xueming(Steven) Li <xuemingl@mellanox.com>
> Cc: dev <dev@dpdk.org>; Asaf@dpdk.org; Maxime Coquelin
> <maxime.coquelin@redhat.com>
> Subject: Re: [dpdk-dev] [v2] vdpa/mlx5: fix event queue number query
>
> On Tue, Jul 28, 2020 at 11:23 AM Xueming Li <xuemingl@mellanox.com> wrote:
> >
> > With latest rte api, vdpa example failed on vq setup, the api to get
> > event queue of specified core failed.
> >
> > After
> > commit 67ae5936c4fc36 ("eal: fix lcore accessors for non-EAL
> > threads"), code of "vhost-event" thread to get current cpu id returns -1.
> >
>
> This is how you figured this problem, but the first part of the commitlog gives
> the impression there is a regression in the EAL.
> I would prefer it is removed (maybe simply when applying?).
NP, sorry for the confusing.
>
>
> > On the other hand, internal api devx_query_eqn expects index of event
> > queue vectors, no need to use cpu id. As the doorbell handling thread
> > is per device, it's sufficient to use default event queue.
> >
> > This patch uses the default id(0) as event queue index.
> >
> > Fixes: 8395927cdfaf ("vdpa/mlx5: prepare HW queues")
> >
> > Signed-off-by: Xueming Li <xuemingl@mellanox.com>
> > Acked-by: Matan Azrad <matan@mellanox.com>
>
>
> Thanks.
>
> --
> David Marchand
next prev parent reply other threads:[~2020-07-28 12:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 6:11 [dpdk-dev] [PATCH] vdpa/mlx5: use master core Id for vhost thread Xueming Li
2020-07-28 6:22 ` [dpdk-dev] [v1] vdpa/mlx5: use control " Xueming Li
2020-07-28 7:08 ` [dpdk-dev] [PATCH] vdpa/mlx5: use master " David Marchand
2020-07-28 7:19 ` Matan Azrad
2020-07-28 7:25 ` David Marchand
2020-07-28 7:30 ` Matan Azrad
2020-07-28 7:53 ` David Marchand
2020-07-28 8:06 ` Xueming(Steven) Li
2020-07-28 8:27 ` Matan Azrad
2020-07-28 8:30 ` David Marchand
2020-07-28 8:24 ` Xueming(Steven) Li
2020-07-28 9:22 ` [dpdk-dev] [v2] vdpa/mlx5: fix event queue number query Xueming Li
2020-07-28 12:05 ` David Marchand
2020-07-28 12:26 ` Xueming(Steven) Li [this message]
2020-07-28 12:32 ` [dpdk-dev] [v3] " Xueming Li
2020-07-28 14:04 ` Maxime Coquelin
2020-07-28 15:55 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR05MB5204E1EEB5452FA4E794C45BAC730@AM0PR05MB5204.eurprd05.prod.outlook.com \
--to=xuemingl@mellanox.com \
--cc=Asaf@dpdk.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).