From: Raslan Darawsheh <rasland@mellanox.com>
To: Bing Zhao <bingz@mellanox.com>,
"john.mcnamara@intel.com" <john.mcnamara@intel.com>,
"marko.kovacevic@intel.com" <marko.kovacevic@intel.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>,
Ori Kam <orika@mellanox.com>, Matan Azrad <matan@mellanox.com>
Cc: Shahaf Shuler <shahafs@mellanox.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v4] doc: update hairpin data buffer size config
Date: Tue, 5 May 2020 08:55:40 +0000 [thread overview]
Message-ID: <AM0PR05MB67075B516C2686CBADAB3B17C2A70@AM0PR05MB6707.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <1587525080-239250-1-git-send-email-bingz@mellanox.com>
Hi,
> -----Original Message-----
> From: Bing Zhao <bingz@mellanox.com>
> Sent: Wednesday, April 22, 2020 6:11 AM
> To: john.mcnamara@intel.com; marko.kovacevic@intel.com; Slava Ovsiienko
> <viacheslavo@mellanox.com>; Ori Kam <orika@mellanox.com>; Matan
> Azrad <matan@mellanox.com>
> Cc: Shahaf Shuler <shahafs@mellanox.com>; Raslan Darawsheh
> <rasland@mellanox.com>; dev@dpdk.org; Thomas Monjalon
> <thomas@monjalon.net>
> Subject: [PATCH v4] doc: update hairpin data buffer size config
>
> This patch updates the MLX5 PMD and release notes documentations.
> Adding the guideline for hairpin data buffer size configuration.
>
> Signed-off-by: Bing Zhao <bingz@mellanox.com>
> Acked-by: Ori Kam <orika@mellanox.com>
> ---
> v2: update the range description of hairpin data buffer size
> v3: correct the minimum value of the range
> v4: correct some typos and grammatical errors
> ---
> doc/guides/nics/mlx5.rst | 16 ++++++++++++++++
> doc/guides/rel_notes/release_20_05.rst | 1 +
> 2 files changed, 17 insertions(+)
>
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
> index 759d0ac..51b5d47 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -99,6 +99,7 @@ Features
> - Support for multiple rte_flow groups.
> - Per packet no-inline hint flag to disable packet data copying into Tx
> descriptors.
> - Hardware LRO.
> +- Hairpin.
>
> Limitations
> -----------
> @@ -786,6 +787,21 @@ Run-time configuration
> If this parameter is not specified, by default PMD will set
> the smallest value supported by HW.
>
> +- ``hp_buf_log_sz`` parameter [int]
> +
> + The total data buffer size of a hairpin queue (logarithmic form), in bytes.
> + PMD will set the data buffer size to 2 ** ``hp_buf_log_sz``, both for RX &
> TX.
> + The capacity of the value is specified by the firmware and the initialization
> + will get a failure if it is out of scope.
> + The range of the value is from 11 to 19 right now, and the supported frame
> + size of a single packet for hairpin is from 512B to 128KB. It might change if
> + different firmware release is being used. By using a small value, it could
> + reduce memory consumption but not work with a large frame. If the value
> is
> + too large, the memory consumption will be high and some potential
> performance
> + degradation will be introduced.
> + By default, the PMD will set this value to 16, which means that 9KB jumbo
> + frames will be supported.
> +
> .. _mlx5_firmware_config:
>
> Firmware configuration
> diff --git a/doc/guides/rel_notes/release_20_05.rst
> b/doc/guides/rel_notes/release_20_05.rst
> index 1e5304d..d43aa2e 100644
> --- a/doc/guides/rel_notes/release_20_05.rst
> +++ b/doc/guides/rel_notes/release_20_05.rst
> @@ -78,6 +78,7 @@ New Features
>
> * Added support for matching on IPv4 Time To Live and IPv6 Hop Limit.
> * Added support for creating Relaxed Ordering Memory Regions.
> + * Added support for configuring Hairpin queue data buffer size.
> * Added support for jumbo frame size (9K MTU) in Multi-Packet RQ mode.
> * Optimized the memory consumption of flow.
>
> --
> 1.8.3.1
Patch rebased and applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2020-05-05 8:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 15:50 [dpdk-dev] [PATCH] " Bing Zhao
2020-04-20 9:57 ` Ori Kam
2020-04-21 5:32 ` [dpdk-dev] [PATCH v2] " Bing Zhao
2020-04-21 6:38 ` Ori Kam
2020-04-21 7:29 ` [dpdk-dev] [PATCH v3] " Bing Zhao
2020-04-22 2:13 ` Thomas Monjalon
2020-04-22 3:14 ` Bing Zhao
2020-04-22 3:11 ` [dpdk-dev] [PATCH v4] " Bing Zhao
2020-05-05 8:55 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR05MB67075B516C2686CBADAB3B17C2A70@AM0PR05MB6707.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=bingz@mellanox.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=matan@mellanox.com \
--cc=orika@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).