DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/mlx5: fix an ineffective calculation in hairpin splitter
@ 2020-07-21 12:00 Michael Baum
  2020-07-22 15:30 ` Raslan Darawsheh
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Baum @ 2020-07-21 12:00 UTC (permalink / raw)
  To: dev; +Cc: matan, viacheslavo, stable

The flow_hairpin_split function defines a pointer called addr that
points to the list of items.
When the function wants to progress in the list, it adds the size of an
item to the pointer.

At the end of the function, it precedes the pointer one more time even
though it is not used afterwards. In fact, this line is unaffected and
the operation of the function would have been no different without it.

Remove the line where the pointer is preceded unnecessarily.

Fixes: d85c7b5ea59f ("net/mlx5: split hairpin flows")
Cc: stable@dpdk.org

Signed-off-by: Michael Baum <michaelba@mellanox.com>
Acked-by: Matan Azrad <matan@mellanox.com>
---
 drivers/net/mlx5/mlx5_flow.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index aba8f41..cf7052b 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -3518,7 +3518,6 @@ struct mlx5_flow_tunnel_info {
 	tag_item->data = UINT32_MAX;
 	tag_item->id = UINT16_MAX;
 	item->mask = tag_item;
-	addr += sizeof(struct mlx5_rte_flow_item_tag);
 	item->last = NULL;
 	item++;
 	item->type = RTE_FLOW_ITEM_TYPE_END;
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix an ineffective calculation in hairpin splitter
  2020-07-21 12:00 [dpdk-dev] [PATCH] net/mlx5: fix an ineffective calculation in hairpin splitter Michael Baum
@ 2020-07-22 15:30 ` Raslan Darawsheh
  0 siblings, 0 replies; 2+ messages in thread
From: Raslan Darawsheh @ 2020-07-22 15:30 UTC (permalink / raw)
  To: Michael Baum, dev; +Cc: Matan Azrad, Slava Ovsiienko, stable

Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Michael Baum
> Sent: Tuesday, July 21, 2020 3:00 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix an ineffective calculation in hairpin
> splitter
> 
> The flow_hairpin_split function defines a pointer called addr that
> points to the list of items.
> When the function wants to progress in the list, it adds the size of an
> item to the pointer.
> 
> At the end of the function, it precedes the pointer one more time even
> though it is not used afterwards. In fact, this line is unaffected and
> the operation of the function would have been no different without it.
> 
> Remove the line where the pointer is preceded unnecessarily.
> 
> Fixes: d85c7b5ea59f ("net/mlx5: split hairpin flows")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Michael Baum <michaelba@mellanox.com>
> Acked-by: Matan Azrad <matan@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_flow.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index aba8f41..cf7052b 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -3518,7 +3518,6 @@ struct mlx5_flow_tunnel_info {
>  	tag_item->data = UINT32_MAX;
>  	tag_item->id = UINT16_MAX;
>  	item->mask = tag_item;
> -	addr += sizeof(struct mlx5_rte_flow_item_tag);
>  	item->last = NULL;
>  	item++;
>  	item->type = RTE_FLOW_ITEM_TYPE_END;
> --
> 1.8.3.1


Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-07-22 15:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21 12:00 [dpdk-dev] [PATCH] net/mlx5: fix an ineffective calculation in hairpin splitter Michael Baum
2020-07-22 15:30 ` Raslan Darawsheh

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).