From: Raslan Darawsheh <rasland@mellanox.com>
To: Thomas Monjalon <thomas@monjalon.net>, "dev@dpdk.org" <dev@dpdk.org>
Cc: Ophir Munk <ophirmu@mellanox.com>,
Matan Azrad <matan@mellanox.com>,
Shahaf Shuler <shahafs@mellanox.com>,
Slava Ovsiienko <viacheslavo@mellanox.com>
Subject: Re: [dpdk-dev] [PATCH] common/mlx5: fix link with ibverbs glue dlopen option
Date: Sat, 18 Jul 2020 13:34:32 +0000 [thread overview]
Message-ID: <AM0PR05MB6707C58210EA55C85D65A5E6C27D0@AM0PR05MB6707.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <20200713153710.807451-1-thomas@monjalon.net>
Him
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, July 13, 2020 6:37 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@mellanox.com>; Ophir Munk
> <ophirmu@mellanox.com>; Matan Azrad <matan@mellanox.com>; Shahaf
> Shuler <shahafs@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>
> Subject: [PATCH] common/mlx5: fix link with ibverbs glue dlopen option
>
> In case the ibverbs glue is a separate library to dlopen,
> the PMD library must allocate a glue structure to be filled by dlopen.
>
> The glue management was in mlx5_common.c and moved to
> mlx5_common_os.c,
> but the variable allocation was not removed from the original file.
> The consequence was a link failure, if ibverbs dlopen option is enabled,
> because of the redefinition of the variable (with GCC 10):
> multiple definition of 'mlx5_glue'
>
> The original definition is removed to keep only the one moved
> in the Linux sub-directory.
>
> Fixes: 79aa430721b1 ("common/mlx5: split common file under Linux
> directory")
> Cc: ophirmu@mellanox.com
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> drivers/common/mlx5/mlx5_common.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/common/mlx5/mlx5_common.c
> b/drivers/common/mlx5/mlx5_common.c
> index 693e2c68c8..341239d164 100644
> --- a/drivers/common/mlx5/mlx5_common.c
> +++ b/drivers/common/mlx5/mlx5_common.c
> @@ -16,10 +16,6 @@
>
> int mlx5_common_logtype;
>
> -#ifdef MLX5_GLUE
> -const struct mlx5_glue *mlx5_glue;
> -#endif
> -
> uint8_t haswell_broadwell_cpu;
>
> static int
> --
> 2.27.0
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
prev parent reply other threads:[~2020-07-18 13:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 15:37 Thomas Monjalon
2020-07-14 5:02 ` Matan Azrad
2020-07-18 13:34 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM0PR05MB6707C58210EA55C85D65A5E6C27D0@AM0PR05MB6707.eurprd05.prod.outlook.com \
--to=rasland@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).