From: Hemant Agrawal <hemant.agrawal@nxp.com>
To: Santosh Shukla <santosh.shukla@caviumnetworks.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "thomas@monjalon.net" <thomas@monjalon.net>,
"jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
Subject: [dpdk-dev] Shared compilation issue - mempool/octeontx: add build and log infrastructure
Date: Sat, 14 Oct 2017 06:07:39 +0000 [thread overview]
Message-ID: <AM2PR04MB075314916204A5B2C9AB62DF89490@AM2PR04MB0753.eurprd04.prod.outlook.com> (raw)
Santosh/jerin,
Your patch "mempool/octeontx: add build and log infrastructure" is causing shared build failure for NXP's patch "event/dpaa2: support event eth adapter", which is still under review.
http://dpdk.org/dev/patchwork/patch/30248/
In your patch, you have added mempool to be dependent on event, which is not correct.
"+DEPDIRS-mempool := bus event"
Ideally, if you have common code, you should put that in bus or mempool . This way you can make event, net or sec etc dependent on bus or mempool and not the otherway around.
With the addition of ethernet adapter in the eventdev, eventdev drivers have dependency on the net driver.
e.g dpaa2 event dev is dependent on dpaa2 net driver, but your patch causes cyclic dependency.
You may also face this issue, once you implement the ethernet adapter support in eventdev.
Please look into this issue.
I suggest you to move the common code to mempool itself or to bus.
Regards,
Hemant
diff --git a/drivers/Makefile b/drivers/Makefile
index 7fef66d..bc2d082 100644
--- a/drivers/Makefile
+++ b/drivers/Makefile
@@ -32,13 +32,13 @@
include $(RTE_SDK)/mk/rte.vars.mk
DIRS-y += bus
+DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event
+DEPDIRS-event := bus
DIRS-y += mempool
-DEPDIRS-mempool := bus
+DEPDIRS-mempool := bus event
DIRS-y += net
DEPDIRS-net := bus mempool
DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto
DEPDIRS-crypto := mempool
-DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event
-DEPDIRS-event := bus
next reply other threads:[~2017-10-14 6:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-14 6:07 Hemant Agrawal [this message]
2017-10-14 15:27 ` santosh
2017-10-16 6:48 ` Hemant Agrawal
2017-10-16 6:50 ` santosh
2017-10-16 13:47 ` santosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM2PR04MB075314916204A5B2C9AB62DF89490@AM2PR04MB0753.eurprd04.prod.outlook.com \
--to=hemant.agrawal@nxp.com \
--cc=dev@dpdk.org \
--cc=jerin.jacob@caviumnetworks.com \
--cc=olivier.matz@6wind.com \
--cc=santosh.shukla@caviumnetworks.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).