[dpdk-dev] bus/fslmc: add QBMAN driver to bus patch problem

[dpdk-dev] bus/fslmc: add QBMAN driver to bus patch problem

[Rybalchenko, Kirill]

Hello Hemant,
I found that a number of patches submitted for 18.05 release fail in compilation:

Failed Build #1:
OS: CentOS7_64
Target: x86_64-native-linuxapp-clang
In file included from /home/patchWorkOrg/compilation/drivers/bus/fslmc/qbman/qbman_portal.c:7:
In file included from /home/patchWorkOrg/compilation/drivers/bus/fslmc/qbman/qbman_portal.h:7:
In file included from /home/patchWorkOrg/compilation/drivers/bus/fslmc/qbman/qbman_sys.h:21:
In file included from /home/patchWorkOrg/compilation/drivers/bus/fslmc/qbman/qbman_sys_decl.h:7:
/home/patchWorkOrg/compilation/drivers/bus/fslmc/qbman/include/fsl_qbman_base.h:9:19: error: redefinition of typedef 'dma_addr_t' is a C11 feature [-Werror,-Wtypedef-redefinition]
typedef uint64_t  dma_addr_t;
                  ^
/home/patchWorkOrg/compilation/drivers/bus/fslmc/qbman/include/compat.h:35:18: note: previous definition is here
typedef uint64_t        dma_addr_t;

This failure caused by patch "bus/fslmc: add QBMAN driver to bus"
commit 
531b17a780dc5f486e8be8d82d1ccd077ea25f14
from Apr 11 2017

Could you please have a look to your patch?

Thanks, 
Kirill Rybalchenko.

Re: [dpdk-dev] bus/fslmc: add QBMAN driver to bus patch problem

[Maxime Coquelin]

Hi Hemant

On 03/29/2018 01:48 PM, Rybalchenko, Kirill wrote:
> Hello Hemant,
> I found that a number of patches submitted for 18.05 release fail in compilation:
> 
> Failed Build #1:
> OS: CentOS7_64
> Target: x86_64-native-linuxapp-clang
> In file included from /home/patchWorkOrg/compilation/drivers/bus/fslmc/qbman/qbman_portal.c:7:
> In file included from /home/patchWorkOrg/compilation/drivers/bus/fslmc/qbman/qbman_portal.h:7:
> In file included from /home/patchWorkOrg/compilation/drivers/bus/fslmc/qbman/qbman_sys.h:21:
> In file included from /home/patchWorkOrg/compilation/drivers/bus/fslmc/qbman/qbman_sys_decl.h:7:
> /home/patchWorkOrg/compilation/drivers/bus/fslmc/qbman/include/fsl_qbman_base.h:9:19: error: redefinition of typedef 'dma_addr_t' is a C11 feature [-Werror,-Wtypedef-redefinition]
> typedef uint64_t  dma_addr_t;
>                    ^
> /home/patchWorkOrg/compilation/drivers/bus/fslmc/qbman/include/compat.h:35:18: note: previous definition is here
> typedef uint64_t        dma_addr_t;
> 
> This failure caused by patch "bus/fslmc: add QBMAN driver to bus"
> commit
> 531b17a780dc5f486e8be8d82d1ccd077ea25f14
> from Apr 11 2017
> 
> Could you please have a look to your patch?

Did you find time to have a look at it?
It breaks automated clang builds, so this is quite annoying.
My clang version:

clang version 3.4.2 (tags/RELEASE_34/dot2-final)

Thanks in advance,
Maxime
> Thanks,
> Kirill Rybalchenko.
> 
> 

Re: [dpdk-dev] bus/fslmc: add QBMAN driver to bus patch problem

[Hemant Agrawal]

I missed it. We will check it asap.

Sent from my Android phone using TouchDown (www.symantec.com)

-----Original Message-----
From: Maxime Coquelin [maxime.coquelin@redhat.com]
Received: Tuesday, 17 Apr 2018, 5:43PM
To: Rybalchenko, Kirill [kirill.rybalchenko@intel.com]; Hemant Agrawal [hemant.agrawal@nxp.com]
CC: dev@dpdk.org [dev@dpdk.org]
Subject: Re: [dpdk-dev] bus/fslmc: add QBMAN driver to bus patch problem

Hi Hemant

On 03/29/2018 01:48 PM, Rybalchenko, Kirill wrote:
> Hello Hemant,
> I found that a number of patches submitted for 18.05 release fail in compilation:
>
> Failed Build #1:
> OS: CentOS7_64
> Target: x86_64-native-linuxapp-clang
> In file included from /home/patchWorkOrg/compilation/drivers/bus/fslmc/qbman/qbman_portal.c:7:
> In file included from /home/patchWorkOrg/compilation/drivers/bus/fslmc/qbman/qbman_portal.h:7:
> In file included from /home/patchWorkOrg/compilation/drivers/bus/fslmc/qbman/qbman_sys.h:21:
> In file included from /home/patchWorkOrg/compilation/drivers/bus/fslmc/qbman/qbman_sys_decl.h:7:
> /home/patchWorkOrg/compilation/drivers/bus/fslmc/qbman/include/fsl_qbman_base.h:9:19: error: redefinition of typedef 'dma_addr_t' is a C11 feature [-Werror,-Wtypedef-redefinition]
> typedef uint64_t  dma_addr_t;
>                    ^
> /home/patchWorkOrg/compilation/drivers/bus/fslmc/qbman/include/compat.h:35:18: note: previous definition is here
> typedef uint64_t        dma_addr_t;
>
> This failure caused by patch "bus/fslmc: add QBMAN driver to bus"
> commit
> 531b17a780dc5f486e8be8d82d1ccd077ea25f14
> from Apr 11 2017
>
> Could you please have a look to your patch?

Did you find time to have a look at it?
It breaks automated clang builds, so this is quite annoying.
My clang version:

clang version 3.4.2 (tags/RELEASE_34/dot2-final)

Thanks in advance,
Maxime
> Thanks,
> Kirill Rybalchenko.
>
>