* [dpdk-dev] [PATCH] event/dpaa: remove dead code
@ 2020-07-17 11:31 wangyunjian
2020-07-17 12:13 ` Hemant Agrawal
0 siblings, 1 reply; 3+ messages in thread
From: wangyunjian @ 2020-07-17 11:31 UTC (permalink / raw)
To: dev
Cc: hemant.agrawal, nipun.gupta, jerry.lilijun, xudingke,
Yunjian Wang, stable
From: Yunjian Wang <wangyunjian@huawei.com>
This patch fixes (Logically dead code) coverity issue.
Coverity issue: 323495
Fixes: 77b5311d0ece ("event/dpaa: support select based event")
Cc: stable@dpdk.org
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
drivers/event/dpaa/dpaa_eventdev.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa_eventdev.c
index a3c138b7a..b5ae87a4e 100644
--- a/drivers/event/dpaa/dpaa_eventdev.c
+++ b/drivers/event/dpaa/dpaa_eventdev.c
@@ -174,7 +174,7 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[],
int ret;
u16 ch_id;
void *buffers[8];
- u32 num_frames, i, irq = 0;
+ u32 num_frames, i;
uint64_t cur_ticks = 0, wait_time_ticks = 0;
struct dpaa_port *portal = (struct dpaa_port *)port;
struct rte_mbuf *mbuf;
@@ -223,8 +223,6 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[],
do {
/* Lets dequeue the frames */
num_frames = qman_portal_dequeue(ev, nb_events, buffers);
- if (irq)
- irq = 0;
if (num_frames)
break;
cur_ticks = rte_get_timer_cycles();
--
2.23.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] event/dpaa: remove dead code
2020-07-17 11:31 [dpdk-dev] [PATCH] event/dpaa: remove dead code wangyunjian
@ 2020-07-17 12:13 ` Hemant Agrawal
2020-07-21 17:47 ` Jerin Jacob
0 siblings, 1 reply; 3+ messages in thread
From: Hemant Agrawal @ 2020-07-17 12:13 UTC (permalink / raw)
To: wangyunjian, dev; +Cc: Nipun Gupta, jerry.lilijun, xudingke, stable
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
-----Original Message-----
From: dev <dev-bounces@dpdk.org> On Behalf Of wangyunjian
Sent: Friday, July 17, 2020 5:02 PM
To: dev@dpdk.org
Cc: Hemant Agrawal <hemant.agrawal@nxp.com>; Nipun Gupta <nipun.gupta@nxp.com>; jerry.lilijun@huawei.com; xudingke@huawei.com; Yunjian Wang <wangyunjian@huawei.com>; stable@dpdk.org
Subject: [dpdk-dev] [PATCH] event/dpaa: remove dead code
From: Yunjian Wang <wangyunjian@huawei.com>
This patch fixes (Logically dead code) coverity issue.
Coverity issue: 323495
Fixes: 77b5311d0ece ("event/dpaa: support select based event")
Cc: stable@dpdk.org
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
drivers/event/dpaa/dpaa_eventdev.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa_eventdev.c
index a3c138b7a..b5ae87a4e 100644
--- a/drivers/event/dpaa/dpaa_eventdev.c
+++ b/drivers/event/dpaa/dpaa_eventdev.c
@@ -174,7 +174,7 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[],
int ret;
u16 ch_id;
void *buffers[8];
- u32 num_frames, i, irq = 0;
+ u32 num_frames, i;
uint64_t cur_ticks = 0, wait_time_ticks = 0;
struct dpaa_port *portal = (struct dpaa_port *)port;
struct rte_mbuf *mbuf;
@@ -223,8 +223,6 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[],
do {
/* Lets dequeue the frames */
num_frames = qman_portal_dequeue(ev, nb_events, buffers);
- if (irq)
- irq = 0;
if (num_frames)
break;
cur_ticks = rte_get_timer_cycles();
--
2.23.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] event/dpaa: remove dead code
2020-07-17 12:13 ` Hemant Agrawal
@ 2020-07-21 17:47 ` Jerin Jacob
0 siblings, 0 replies; 3+ messages in thread
From: Jerin Jacob @ 2020-07-21 17:47 UTC (permalink / raw)
To: Hemant Agrawal
Cc: wangyunjian, dev, Nipun Gupta, jerry.lilijun, xudingke, stable
On Fri, Jul 17, 2020 at 5:43 PM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
>
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of wangyunjian
> Sent: Friday, July 17, 2020 5:02 PM
> To: dev@dpdk.org
> Cc: Hemant Agrawal <hemant.agrawal@nxp.com>; Nipun Gupta <nipun.gupta@nxp.com>; jerry.lilijun@huawei.com; xudingke@huawei.com; Yunjian Wang <wangyunjian@huawei.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] event/dpaa: remove dead code
>
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> This patch fixes (Logically dead code) coverity issue.
>
> Coverity issue: 323495
> Fixes: 77b5311d0ece ("event/dpaa: support select based event")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
Applied to dpdk-next-eventdev/master. Thanks.
> ---
> drivers/event/dpaa/dpaa_eventdev.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa_eventdev.c
> index a3c138b7a..b5ae87a4e 100644
> --- a/drivers/event/dpaa/dpaa_eventdev.c
> +++ b/drivers/event/dpaa/dpaa_eventdev.c
> @@ -174,7 +174,7 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[],
> int ret;
> u16 ch_id;
> void *buffers[8];
> - u32 num_frames, i, irq = 0;
> + u32 num_frames, i;
> uint64_t cur_ticks = 0, wait_time_ticks = 0;
> struct dpaa_port *portal = (struct dpaa_port *)port;
> struct rte_mbuf *mbuf;
> @@ -223,8 +223,6 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[],
> do {
> /* Lets dequeue the frames */
> num_frames = qman_portal_dequeue(ev, nb_events, buffers);
> - if (irq)
> - irq = 0;
> if (num_frames)
> break;
> cur_ticks = rte_get_timer_cycles();
> --
> 2.23.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-21 17:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-17 11:31 [dpdk-dev] [PATCH] event/dpaa: remove dead code wangyunjian
2020-07-17 12:13 ` Hemant Agrawal
2020-07-21 17:47 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).