RE: [PATCH v3] config/arm: add Phytium FT-2000+

[Ruifeng Wang <Ruifeng.Wang@arm.com>]

> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, July 5, 2022 9:31 PM
> To: dev@dpdk.org
> Cc: luzhipeng <luzhipeng@cestc.cn>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>; Jan Viktorin <viktorin@rehivetech.com>; Bruce
> Richardson <bruce.richardson@intel.com>
> Subject: [PATCH v3] config/arm: add Phytium FT-2000+
> 
> From: luzhipeng <luzhipeng@cestc.cn>
> 
> Here adds configs for Phytium server.
> 
> Signed-off-by: luzhipeng <luzhipeng@cestc.cn>
> Reviewed-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> I did some changes in this v3:
> - PHYTIUM -> Phytium (as on the website)
> - ft2000plus -> FT-2000+ (as found online)
> - alphabetical ordering
> - extra commas for future extensions
> - g++ as cpp Meson command
> 
> Please tell how to write your name with spaces and capitals in the order [first
> name] [family name], thanks.
> ---

<snip>

>  implementer_qualcomm = {
>      'description': 'Qualcomm',
>      'flags': [
> @@ -214,7 +228,7 @@ implementer_qualcomm = {
>          '0xc00': {
>              'march': 'armv8-a',
>              'march_features': ['crc']
> -        }
> +        },

Unintentional change?
The change is valid, but not related to this patch.

Otherwise looks good to me.
Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>

>      }
>  }
> 
> @@ -225,7 +239,8 @@ implementers = {
>      '0x43': implementer_cavium,
>      '0x48': implementer_hisilicon,
>      '0x50': implementer_ampere,
> -    '0x51': implementer_qualcomm
> +    '0x51': implementer_qualcomm,
> +    '0x70': implementer_phytium,
>  }
> 
>  # SoC specific armv8 flags have the highest priority @@ -304,6 +319,13 @@
> soc_emag = {
>      'part_number': '0x0'
>  }
> 
> +soc_ft2000plus = {
> +    'description': 'Phytium FT-2000+',
> +    'implementer': '0x70',
> +    'part_number': '0x662',
> +    'numa': true
> +}
> +
>  soc_graviton2 = {
>      'description': 'AWS Graviton2',
>      'implementer': '0x41',
> @@ -389,6 +411,7 @@ cn9k:            Marvell OCTEON 9
>  cn10k:           Marvell OCTEON 10
>  dpaa:            NXP DPAA
>  emag:            Ampere eMAG
> +ft2000plus:      Phytium FT-2000+
>  graviton2:       AWS Graviton2
>  kunpeng920:      HiSilicon Kunpeng 920
>  kunpeng930:      HiSilicon Kunpeng 930
> @@ -412,6 +435,7 @@ socs = {
>      'cn10k' : soc_cn10k,
>      'dpaa': soc_dpaa,
>      'emag': soc_emag,
> +    'ft2000plus': soc_ft2000plus,
>      'graviton2': soc_graviton2,
>      'kunpeng920': soc_kunpeng920,
>      'kunpeng930': soc_kunpeng930,
> --
> 2.36.1