DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] Add build switches for all DPDK applications. This makes it possible to skip building applications (and build only libraries or kernel drivers).
@ 2015-10-30 14:27 Francesco Montorsi
  2015-10-30 16:39 ` Mcnamara, John
  0 siblings, 1 reply; 2+ messages in thread
From: Francesco Montorsi @ 2015-10-30 14:27 UTC (permalink / raw)
  To: dev; +Cc: Francesco Montorsi

---
 app/Makefile           |  8 ++++----
 config/common_linuxapp | 21 +++++++++++++++++++++
 2 files changed, 25 insertions(+), 4 deletions(-)

diff --git a/app/Makefile b/app/Makefile
index 88c0bad..0b266b5 100644
--- a/app/Makefile
+++ b/app/Makefile
@@ -32,10 +32,10 @@
 include $(RTE_SDK)/mk/rte.vars.mk
 
 DIRS-$(CONFIG_RTE_APP_TEST) += test
-DIRS-$(CONFIG_RTE_LIBRTE_ACL) += test-acl
-DIRS-$(CONFIG_RTE_LIBRTE_PIPELINE) += test-pipeline
+DIRS-$(CONFIG_RTE_APP_ACL_TEST) += test-acl
+DIRS-$(CONFIG_RTE_APP_PIPELINE_TEST) += test-pipeline
 DIRS-$(CONFIG_RTE_TEST_PMD) += test-pmd
-DIRS-$(CONFIG_RTE_LIBRTE_CMDLINE) += cmdline_test
-DIRS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += proc_info
+DIRS-$(CONFIG_RTE_APP_CMDLINE_TEST) += cmdline_test
+DIRS-$(CONFIG_RTE_APP_PROC_INFO) += proc_info
 
 include $(RTE_SDK)/mk/rte.subdir.mk
diff --git a/config/common_linuxapp b/config/common_linuxapp
index 0de43d5..b6703b1 100644
--- a/config/common_linuxapp
+++ b/config/common_linuxapp
@@ -466,3 +466,24 @@ CONFIG_RTE_APP_TEST=y
 CONFIG_RTE_TEST_PMD=y
 CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES=n
 CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS=n
+
+#
+# Compile the ACL test application
+#
+CONFIG_RTE_APP_ACL_TEST=y
+
+#
+# Compile the pipeline test application
+#
+CONFIG_RTE_APP_PIPELINE_TEST=y
+
+#
+# Compile the ACL test application
+#
+CONFIG_RTE_APP_CMDLINE_TEST=y
+
+#
+# Compile the proc_info test application
+#
+CONFIG_RTE_APP_PROC_INFO=y
+
-- 
2.5.3.windows.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] Add build switches for all DPDK applications. This makes it possible to skip building applications (and build only libraries or kernel drivers).
  2015-10-30 14:27 [dpdk-dev] [PATCH] Add build switches for all DPDK applications. This makes it possible to skip building applications (and build only libraries or kernel drivers) Francesco Montorsi
@ 2015-10-30 16:39 ` Mcnamara, John
  0 siblings, 0 replies; 2+ messages in thread
From: Mcnamara, John @ 2015-10-30 16:39 UTC (permalink / raw)
  To: Francesco Montorsi, dev

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Francesco Montorsi
> Sent: Friday, October 30, 2015 2:28 PM
> To: dev@dpdk.org
> Cc: Francesco Montorsi
> Subject: [dpdk-dev] [PATCH] Add build switches for all DPDK applications.
> This makes it possible to skip building applications (and build only
> libraries or kernel drivers).

Hi,

Thanks for the patch.

The patch needs to signed and the title is too long (part of it should be in the body). See the following contributing guidelines:

    http://dpdk.org/dev/patchwork/patch/7935/

I don't know if people will want to add more compile time options. In general we are trying to remove them.

I do like the idea of being able to turn off building app/test which can a long time (even with -j).

Maybe it should only be built when you run "make test".

John.
-- 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-10-30 16:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-30 14:27 [dpdk-dev] [PATCH] Add build switches for all DPDK applications. This makes it possible to skip building applications (and build only libraries or kernel drivers) Francesco Montorsi
2015-10-30 16:39 ` Mcnamara, John

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).