[dpdk-dev] [PATCH v1 0/2] Fix various Coverity warnings

[dpdk-dev] [PATCH v1 0/2] Fix various Coverity warnings

[Remy Horton]

Remy Horton (2):
  examples/ethtool: Fix uninitialised variable in structure
  examples/l2fwd-keepalive: Fix integer overflow

 examples/ethtool/ethtool-app/ethapp.c | 3 +++
 examples/l2fwd-keepalive/main.c       | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

-- 
1.9.3

[dpdk-dev] [PATCH v1 1/2] examples/ethtool: Fix uninitialised variable

[Remy Horton]

Fix Coverity warning with uninitialised field in structure being used.
Zero out all the other unused ones.

>>> CID 120413 (#1 of 1): Uninitialized scalar variable (UNINIT)

Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")

Signed-off-by: Remy Horton <remy.horton@intel.com>
---
 examples/ethtool/ethtool-app/ethapp.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/examples/ethtool/ethtool-app/ethapp.c b/examples/ethtool/ethtool-app/ethapp.c
index 3863b02..2ed4796 100644
--- a/examples/ethtool/ethtool-app/ethapp.c
+++ b/examples/ethtool/ethtool-app/ethapp.c
@@ -339,6 +339,7 @@ pcmd_pause_callback(void *ptr_params,
 	if (ptr_data != NULL) {
 		stat = rte_ethtool_get_pauseparam(params->port, &info);
 	} else {
+		memset(&info, 0, sizeof(info));
 		if (strcasecmp("all", params->opt) == 0) {
 			info.tx_pause = 1;
 			info.rx_pause = 1;
@@ -352,6 +353,8 @@ pcmd_pause_callback(void *ptr_params,
 			info.tx_pause = 0;
 			info.rx_pause = 0;
 		}
+		/* Assume auto-negotiation wanted */
+		info.autoneg = 1;
 		stat = rte_ethtool_set_pauseparam(params->port, &info);
 	}
 	if (stat == 0) {
-- 
1.9.3

[dpdk-dev] [PATCH v1 2/2] examples/l2fwd-keepalive: Fix integer overflow

[Remy Horton]

Fix Coverity warning with potential 32-bit integer multiplication overflow
where final result is expected to be 64-bit.

>>> CID 120144 (#1 of 1): Unintentional integer overflow (OVERFLOW_BEFORE_WIDEN)

Fixes: e64833f2273a ("examples/l2fwd-keepalive: add sample application")

Signed-off-by: Remy Horton <remy.horton@intel.com>
---
 examples/l2fwd-keepalive/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/l2fwd-keepalive/main.c b/examples/l2fwd-keepalive/main.c
index 8d7b09e..f4d52f2 100644
--- a/examples/l2fwd-keepalive/main.c
+++ b/examples/l2fwd-keepalive/main.c
@@ -471,7 +471,7 @@ l2fwd_parse_args(int argc, char **argv)
 		/* timer period */
 		case 'T':
 			timer_period = l2fwd_parse_timer_period(optarg)
-				* 1000 * TIMER_MILLISECOND;
+				* (int64_t)(1000 * TIMER_MILLISECOND);
 			if (timer_period < 0) {
 				printf("invalid timer period\n");
 				l2fwd_usage(prgname);
-- 
1.9.3

Re: [dpdk-dev] [PATCH v1 1/2] examples/ethtool: Fix uninitialised variable

[Mcnamara, John]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Remy Horton
> Sent: Thursday, December 10, 2015 9:50 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v1 1/2] examples/ethtool: Fix uninitialised
> variable
> 
> Fix Coverity warning with uninitialised field in structure being used.
> Zero out all the other unused ones.
> 
> >>> CID 120413 (#1 of 1): Uninitialized scalar variable (UNINIT)
> 
> Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample
> application")
> 
> Signed-off-by: Remy Horton <remy.horton@intel.com>

Acked-by: John McNamara <john.mcnamara@intel.com>

Re: [dpdk-dev] [PATCH v1 2/2] examples/l2fwd-keepalive: Fix integer overflow

[Mcnamara, John]

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Remy Horton
> Sent: Thursday, December 10, 2015 9:50 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH v1 2/2] examples/l2fwd-keepalive: Fix integer
> overflow
> 
> Fix Coverity warning with potential 32-bit integer multiplication overflow
> where final result is expected to be 64-bit.
> 
> >>> CID 120144 (#1 of 1): Unintentional integer overflow
> >>> (OVERFLOW_BEFORE_WIDEN)
> 
> Fixes: e64833f2273a ("examples/l2fwd-keepalive: add sample application")
> 
> Signed-off-by: Remy Horton <remy.horton@intel.com>

Acked-by: John McNamara <john.mcnamara@intel.com>

Re: [dpdk-dev] [PATCH v1 0/2] Fix various Coverity warnings

[Thomas Monjalon]

2015-12-10 09:50, Remy Horton:
> Remy Horton (2):
>   examples/ethtool: Fix uninitialised variable in structure
>   examples/l2fwd-keepalive: Fix integer overflow

Applied, thanks