DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Mcnamara, John" <john.mcnamara@intel.com>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	"Kovacevic, Marko" <marko.kovacevic@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Varghese, Vipin" <vipin.varghese@intel.com>,
	"Glynn, Michael J" <michael.j.glynn@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc: update pcap documentation
Date: Wed, 17 Jan 2018 16:35:24 +0000	[thread overview]
Message-ID: <B27915DBBA3421428155699D51E4CFE23EE7547B@IRSMSX103.ger.corp.intel.com> (raw)
In-Reply-To: <20180116184528.5498-1-ferruh.yigit@intel.com>



> -----Original Message-----
> From: Yigit, Ferruh
> Sent: Tuesday, January 16, 2018 6:45 PM
> To: Richardson, Bruce <bruce.richardson@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Kovacevic, Marko <marko.kovacevic@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Varghese, Vipin
> <vipin.varghese@intel.com>; Glynn, Michael J <michael.j.glynn@intel.com>
> Subject: [PATCH] doc: update pcap documentation
> 
> Add note about PMD expects the network interfaces provided to be up,
> documented behavior to set expectations right.
> 
> Also added minor fix.
> 
>...
> 
> +Notes
> +^^^^^
> +
> +The network interface provided to the PMD should be up, PMD will return
> +an error if interface is down, and PMD itself won't change the status of
> the external network interface.

It would probably be a little better as an RST note directive, as used elsewhere
in the doc. Like this:

.. note::

   The network interface provided to the PMD should be up. The PMD will return
   an error if interface is down, and the PMD itself won't change the status
   of the external network interface.

But it isn't a big issue so:

Acked-by: John McNamara <john.mcnamara@intel.com>

  reply	other threads:[~2018-01-17 16:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-16 18:45 Ferruh Yigit
2018-01-17 16:35 ` Mcnamara, John [this message]
2018-01-17 18:30 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2018-01-17 19:26   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=B27915DBBA3421428155699D51E4CFE23EE7547B@IRSMSX103.ger.corp.intel.com \
    --to=john.mcnamara@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=michael.j.glynn@intel.com \
    --cc=vipin.varghese@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).