DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] doc: deprecation notice to add callback data to rte_event_fp_ops
@ 2023-07-12 17:30 Sivaprasad Tummala
  2023-07-13  8:51 ` Jerin Jacob
  2023-07-17 11:24 ` [PATCH v1] " Sivaprasad Tummala
  0 siblings, 2 replies; 12+ messages in thread
From: Sivaprasad Tummala @ 2023-07-12 17:30 UTC (permalink / raw)
  To: dev; +Cc: ferruh.yigit, bruce.richardson, david.marchand, thomas

Deprecation notice to add "rte_eventdev_port_data" field to
``rte_event_fp_ops`` for callback support.

Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 8e1cdd677a..2c69338818 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -133,6 +133,10 @@ Deprecation Notices
   ``rte_cryptodev_get_auth_algo_string``, ``rte_cryptodev_get_aead_algo_string`` and
   ``rte_cryptodev_asym_get_xform_string`` respectively.
 
+* eventdev: The struct rte_event_fp_ops will be updated with a new element
+  rte_eventdev_port_data to support optional callbacks in DPDK 23.11. This changes
+  the size of rte_event_fp_ops and result in ABI change.
+
 * flow_classify: The flow_classify library and example have no maintainer.
   The library is experimental and, as such, it could be removed from DPDK.
   Its removal has been postponed to let potential users report interest
-- 
2.34.1


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] doc: deprecation notice to add callback data to rte_event_fp_ops
  2023-07-12 17:30 [PATCH] doc: deprecation notice to add callback data to rte_event_fp_ops Sivaprasad Tummala
@ 2023-07-13  8:51 ` Jerin Jacob
  2023-07-13 10:38   ` Tummala, Sivaprasad
  2023-07-17 11:24 ` [PATCH v1] " Sivaprasad Tummala
  1 sibling, 1 reply; 12+ messages in thread
From: Jerin Jacob @ 2023-07-13  8:51 UTC (permalink / raw)
  To: Sivaprasad Tummala
  Cc: dev, ferruh.yigit, bruce.richardson, david.marchand, thomas

On Wed, Jul 12, 2023 at 11:01 PM Sivaprasad Tummala
<sivaprasad.tummala@amd.com> wrote:
>
> Deprecation notice to add "rte_eventdev_port_data" field to

Could you share the rational for why rte_eventdev_port_data needs to be added?


> ``rte_event_fp_ops`` for callback support.
>
> Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 8e1cdd677a..2c69338818 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -133,6 +133,10 @@ Deprecation Notices
>    ``rte_cryptodev_get_auth_algo_string``, ``rte_cryptodev_get_aead_algo_string`` and
>    ``rte_cryptodev_asym_get_xform_string`` respectively.
>
> +* eventdev: The struct rte_event_fp_ops will be updated with a new element
> +  rte_eventdev_port_data to support optional callbacks in DPDK 23.11. This changes
> +  the size of rte_event_fp_ops and result in ABI change.
> +
>  * flow_classify: The flow_classify library and example have no maintainer.
>    The library is experimental and, as such, it could be removed from DPDK.
>    Its removal has been postponed to let potential users report interest
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: [PATCH] doc: deprecation notice to add callback data to rte_event_fp_ops
  2023-07-13  8:51 ` Jerin Jacob
@ 2023-07-13 10:38   ` Tummala, Sivaprasad
  2023-07-13 10:40     ` Jerin Jacob
  0 siblings, 1 reply; 12+ messages in thread
From: Tummala, Sivaprasad @ 2023-07-13 10:38 UTC (permalink / raw)
  To: Jerin Jacob; +Cc: dev, Yigit, Ferruh, bruce.richardson, david.marchand, thomas

[AMD Official Use Only - General]

Hi Jerin,

> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Thursday, July 13, 2023 2:22 PM
> To: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <Ferruh.Yigit@amd.com>;
> bruce.richardson@intel.com; david.marchand@redhat.com; thomas@monjalon.net
> Subject: Re: [PATCH] doc: deprecation notice to add callback data to
> rte_event_fp_ops
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On Wed, Jul 12, 2023 at 11:01 PM Sivaprasad Tummala
> <sivaprasad.tummala@amd.com> wrote:
> >
> > Deprecation notice to add "rte_eventdev_port_data" field to
>
> Could you share the rational for why rte_eventdev_port_data needs to be added?

"rte_eventdev_port_data" is used to hold callbacks registered optionally per event device port and associated callback data.
By adding "rte_eventdev_port_data" to "rte_event_fp_ops", allows to fetch this data for fastpath eventdev inline functions in advance.

>
>
> > ``rte_event_fp_ops`` for callback support.
> >
> > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> > ---
> >  doc/guides/rel_notes/deprecation.rst | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index 8e1cdd677a..2c69338818 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -133,6 +133,10 @@ Deprecation Notices
> >    ``rte_cryptodev_get_auth_algo_string``,
> ``rte_cryptodev_get_aead_algo_string`` and
> >    ``rte_cryptodev_asym_get_xform_string`` respectively.
> >
> > +* eventdev: The struct rte_event_fp_ops will be updated with a new
> > +element
> > +  rte_eventdev_port_data to support optional callbacks in DPDK 23.11.
> > +This changes
> > +  the size of rte_event_fp_ops and result in ABI change.
> > +
> >  * flow_classify: The flow_classify library and example have no maintainer.
> >    The library is experimental and, as such, it could be removed from DPDK.
> >    Its removal has been postponed to let potential users report
> > interest
> > --
> > 2.34.1
> >

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH] doc: deprecation notice to add callback data to rte_event_fp_ops
  2023-07-13 10:38   ` Tummala, Sivaprasad
@ 2023-07-13 10:40     ` Jerin Jacob
  2023-07-14 11:32       ` Tummala, Sivaprasad
  0 siblings, 1 reply; 12+ messages in thread
From: Jerin Jacob @ 2023-07-13 10:40 UTC (permalink / raw)
  To: Tummala, Sivaprasad
  Cc: dev, Yigit, Ferruh, bruce.richardson, david.marchand, thomas

On Thu, Jul 13, 2023 at 4:08 PM Tummala, Sivaprasad
<Sivaprasad.Tummala@amd.com> wrote:
>
> [AMD Official Use Only - General]
>
> Hi Jerin,
>
> > -----Original Message-----
> > From: Jerin Jacob <jerinjacobk@gmail.com>
> > Sent: Thursday, July 13, 2023 2:22 PM
> > To: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>
> > Cc: dev@dpdk.org; Yigit, Ferruh <Ferruh.Yigit@amd.com>;
> > bruce.richardson@intel.com; david.marchand@redhat.com; thomas@monjalon.net
> > Subject: Re: [PATCH] doc: deprecation notice to add callback data to
> > rte_event_fp_ops
> >
> > Caution: This message originated from an External Source. Use proper caution
> > when opening attachments, clicking links, or responding.
> >
> >
> > On Wed, Jul 12, 2023 at 11:01 PM Sivaprasad Tummala
> > <sivaprasad.tummala@amd.com> wrote:
> > >
> > > Deprecation notice to add "rte_eventdev_port_data" field to
> >
> > Could you share the rational for why rte_eventdev_port_data needs to be added?
>
> "rte_eventdev_port_data" is used to hold callbacks registered optionally per event device port and associated callback data.
> By adding "rte_eventdev_port_data" to "rte_event_fp_ops", allows to fetch this data for fastpath eventdev inline functions in advance.

Please add above info in the release notes for next version.

>
> >
> >
> > > ``rte_event_fp_ops`` for callback support.
> > >
> > > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> > > ---
> > >  doc/guides/rel_notes/deprecation.rst | 4 ++++
> > >  1 file changed, 4 insertions(+)
> > >
> > > diff --git a/doc/guides/rel_notes/deprecation.rst
> > > b/doc/guides/rel_notes/deprecation.rst
> > > index 8e1cdd677a..2c69338818 100644
> > > --- a/doc/guides/rel_notes/deprecation.rst
> > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > @@ -133,6 +133,10 @@ Deprecation Notices
> > >    ``rte_cryptodev_get_auth_algo_string``,
> > ``rte_cryptodev_get_aead_algo_string`` and
> > >    ``rte_cryptodev_asym_get_xform_string`` respectively.
> > >
> > > +* eventdev: The struct rte_event_fp_ops will be updated with a new
> > > +element
> > > +  rte_eventdev_port_data to support optional callbacks in DPDK 23.11.
> > > +This changes
> > > +  the size of rte_event_fp_ops and result in ABI change.
> > > +
> > >  * flow_classify: The flow_classify library and example have no maintainer.
> > >    The library is experimental and, as such, it could be removed from DPDK.
> > >    Its removal has been postponed to let potential users report
> > > interest
> > > --
> > > 2.34.1
> > >

^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: [PATCH] doc: deprecation notice to add callback data to rte_event_fp_ops
  2023-07-13 10:40     ` Jerin Jacob
@ 2023-07-14 11:32       ` Tummala, Sivaprasad
  0 siblings, 0 replies; 12+ messages in thread
From: Tummala, Sivaprasad @ 2023-07-14 11:32 UTC (permalink / raw)
  To: Jerin Jacob; +Cc: dev, Yigit, Ferruh, bruce.richardson, david.marchand, thomas

[AMD Official Use Only - General]

> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Thursday, July 13, 2023 4:11 PM
> To: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <Ferruh.Yigit@amd.com>;
> bruce.richardson@intel.com; david.marchand@redhat.com; thomas@monjalon.net
> Subject: Re: [PATCH] doc: deprecation notice to add callback data to
> rte_event_fp_ops
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> On Thu, Jul 13, 2023 at 4:08 PM Tummala, Sivaprasad
> <Sivaprasad.Tummala@amd.com> wrote:
> >
> > [AMD Official Use Only - General]
> >
> > Hi Jerin,
> >
> > > -----Original Message-----
> > > From: Jerin Jacob <jerinjacobk@gmail.com>
> > > Sent: Thursday, July 13, 2023 2:22 PM
> > > To: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com>
> > > Cc: dev@dpdk.org; Yigit, Ferruh <Ferruh.Yigit@amd.com>;
> > > bruce.richardson@intel.com; david.marchand@redhat.com;
> > > thomas@monjalon.net
> > > Subject: Re: [PATCH] doc: deprecation notice to add callback data to
> > > rte_event_fp_ops
> > >
> > > Caution: This message originated from an External Source. Use proper
> > > caution when opening attachments, clicking links, or responding.
> > >
> > >
> > > On Wed, Jul 12, 2023 at 11:01 PM Sivaprasad Tummala
> > > <sivaprasad.tummala@amd.com> wrote:
> > > >
> > > > Deprecation notice to add "rte_eventdev_port_data" field to
> > >
> > > Could you share the rational for why rte_eventdev_port_data needs to be
> added?
> >
> > "rte_eventdev_port_data" is used to hold callbacks registered optionally per
> event device port and associated callback data.
> > By adding "rte_eventdev_port_data" to "rte_event_fp_ops", allows to fetch this
> data for fastpath eventdev inline functions in advance.
>
> Please add above info in the release notes for next version.
Sure, will do the same.
>
> >
> > >
> > >
> > > > ``rte_event_fp_ops`` for callback support.
> > > >
> > > > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> > > > ---
> > > >  doc/guides/rel_notes/deprecation.rst | 4 ++++
> > > >  1 file changed, 4 insertions(+)
> > > >
> > > > diff --git a/doc/guides/rel_notes/deprecation.rst
> > > > b/doc/guides/rel_notes/deprecation.rst
> > > > index 8e1cdd677a..2c69338818 100644
> > > > --- a/doc/guides/rel_notes/deprecation.rst
> > > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > > @@ -133,6 +133,10 @@ Deprecation Notices
> > > >    ``rte_cryptodev_get_auth_algo_string``,
> > > ``rte_cryptodev_get_aead_algo_string`` and
> > > >    ``rte_cryptodev_asym_get_xform_string`` respectively.
> > > >
> > > > +* eventdev: The struct rte_event_fp_ops will be updated with a
> > > > +new element
> > > > +  rte_eventdev_port_data to support optional callbacks in DPDK 23.11.
> > > > +This changes
> > > > +  the size of rte_event_fp_ops and result in ABI change.
> > > > +
> > > >  * flow_classify: The flow_classify library and example have no maintainer.
> > > >    The library is experimental and, as such, it could be removed from DPDK.
> > > >    Its removal has been postponed to let potential users report
> > > > interest
> > > > --
> > > > 2.34.1
> > > >

^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH v1] doc: deprecation notice to add callback data to rte_event_fp_ops
  2023-07-12 17:30 [PATCH] doc: deprecation notice to add callback data to rte_event_fp_ops Sivaprasad Tummala
  2023-07-13  8:51 ` Jerin Jacob
@ 2023-07-17 11:24 ` Sivaprasad Tummala
  2023-07-17 11:43   ` Jerin Jacob
  2023-07-25  8:40   ` Ferruh Yigit
  1 sibling, 2 replies; 12+ messages in thread
From: Sivaprasad Tummala @ 2023-07-17 11:24 UTC (permalink / raw)
  To: dev; +Cc: ferruh.yigit, bruce.richardson, david.marchand, thomas, jerinjacobk

Deprecation notice to add "rte_eventdev_port_data" field to
``rte_event_fp_ops`` for callback support.

Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
---
 doc/guides/rel_notes/deprecation.rst | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index fb771a0305..057f97ce5a 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -130,6 +130,13 @@ Deprecation Notices
   ``rte_cryptodev_get_auth_algo_string``, ``rte_cryptodev_get_aead_algo_string`` and
   ``rte_cryptodev_asym_get_xform_string`` respectively.
 
+* eventdev: The struct rte_event_fp_ops will be updated with a new element
+  rte_eventdev_port_data to support optional callbacks in DPDK 23.11.
+  rte_eventdev_port_data is used to hold callbacks registered optionally
+  per event device port and associated callback data. By adding rte_eventdev_port_data
+  to rte_event_fp_ops, allows to fetch this data for fastpath eventdev inline functions
+  in advance. This changes the size of rte_event_fp_ops and result in ABI change.
+
 * security: Hide structures ``rte_security_ops`` and ``rte_security_ctx``
   as these are internal to DPDK library and drivers.
 
-- 
2.34.1


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v1] doc: deprecation notice to add callback data to rte_event_fp_ops
  2023-07-17 11:24 ` [PATCH v1] " Sivaprasad Tummala
@ 2023-07-17 11:43   ` Jerin Jacob
  2023-07-17 12:42     ` Ferruh Yigit
  2023-07-25  8:40   ` Ferruh Yigit
  1 sibling, 1 reply; 12+ messages in thread
From: Jerin Jacob @ 2023-07-17 11:43 UTC (permalink / raw)
  To: Sivaprasad Tummala
  Cc: dev, ferruh.yigit, bruce.richardson, david.marchand, thomas

On Mon, Jul 17, 2023 at 4:54 PM Sivaprasad Tummala
<sivaprasad.tummala@amd.com> wrote:
>
> Deprecation notice to add "rte_eventdev_port_data" field to
> ``rte_event_fp_ops`` for callback support.
>
> Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>


> ---
>  doc/guides/rel_notes/deprecation.rst | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index fb771a0305..057f97ce5a 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -130,6 +130,13 @@ Deprecation Notices
>    ``rte_cryptodev_get_auth_algo_string``, ``rte_cryptodev_get_aead_algo_string`` and
>    ``rte_cryptodev_asym_get_xform_string`` respectively.
>
> +* eventdev: The struct rte_event_fp_ops will be updated with a new element
> +  rte_eventdev_port_data to support optional callbacks in DPDK 23.11.
> +  rte_eventdev_port_data is used to hold callbacks registered optionally
> +  per event device port and associated callback data. By adding rte_eventdev_port_data
> +  to rte_event_fp_ops, allows to fetch this data for fastpath eventdev inline functions
> +  in advance. This changes the size of rte_event_fp_ops and result in ABI change.
> +
>  * security: Hide structures ``rte_security_ops`` and ``rte_security_ctx``
>    as these are internal to DPDK library and drivers.
>
> --
> 2.34.1
>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v1] doc: deprecation notice to add callback data to rte_event_fp_ops
  2023-07-17 11:43   ` Jerin Jacob
@ 2023-07-17 12:42     ` Ferruh Yigit
  0 siblings, 0 replies; 12+ messages in thread
From: Ferruh Yigit @ 2023-07-17 12:42 UTC (permalink / raw)
  To: Jerin Jacob, Sivaprasad Tummala
  Cc: dev, bruce.richardson, david.marchand, thomas

On 7/17/2023 12:43 PM, Jerin Jacob wrote:
> On Mon, Jul 17, 2023 at 4:54 PM Sivaprasad Tummala
> <sivaprasad.tummala@amd.com> wrote:
>>
>> Deprecation notice to add "rte_eventdev_port_data" field to
>> ``rte_event_fp_ops`` for callback support.
>>
>> Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> 
> Acked-by: Jerin Jacob <jerinj@marvell.com>
> 

Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>

> 
>> ---
>>  doc/guides/rel_notes/deprecation.rst | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
>> index fb771a0305..057f97ce5a 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -130,6 +130,13 @@ Deprecation Notices
>>    ``rte_cryptodev_get_auth_algo_string``, ``rte_cryptodev_get_aead_algo_string`` and
>>    ``rte_cryptodev_asym_get_xform_string`` respectively.
>>
>> +* eventdev: The struct rte_event_fp_ops will be updated with a new element
>> +  rte_eventdev_port_data to support optional callbacks in DPDK 23.11.
>> +  rte_eventdev_port_data is used to hold callbacks registered optionally
>> +  per event device port and associated callback data. By adding rte_eventdev_port_data
>> +  to rte_event_fp_ops, allows to fetch this data for fastpath eventdev inline functions
>> +  in advance. This changes the size of rte_event_fp_ops and result in ABI change.
>> +
>>  * security: Hide structures ``rte_security_ops`` and ``rte_security_ctx``
>>    as these are internal to DPDK library and drivers.
>>
>> --
>> 2.34.1
>>


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v1] doc: deprecation notice to add callback data to rte_event_fp_ops
  2023-07-17 11:24 ` [PATCH v1] " Sivaprasad Tummala
  2023-07-17 11:43   ` Jerin Jacob
@ 2023-07-25  8:40   ` Ferruh Yigit
  2023-07-25 16:46     ` Hemant Agrawal
  2023-07-28 15:42     ` Thomas Monjalon
  1 sibling, 2 replies; 12+ messages in thread
From: Ferruh Yigit @ 2023-07-25  8:40 UTC (permalink / raw)
  To: Sivaprasad Tummala, dev
  Cc: bruce.richardson, david.marchand, thomas, jerinjacobk, techboard

On 7/17/2023 12:24 PM, Sivaprasad Tummala wrote:
> Deprecation notice to add "rte_eventdev_port_data" field to
> ``rte_event_fp_ops`` for callback support.
> 
> Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index fb771a0305..057f97ce5a 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -130,6 +130,13 @@ Deprecation Notices
>    ``rte_cryptodev_get_auth_algo_string``, ``rte_cryptodev_get_aead_algo_string`` and
>    ``rte_cryptodev_asym_get_xform_string`` respectively.
>  
> +* eventdev: The struct rte_event_fp_ops will be updated with a new element
> +  rte_eventdev_port_data to support optional callbacks in DPDK 23.11.
> +  rte_eventdev_port_data is used to hold callbacks registered optionally
> +  per event device port and associated callback data. By adding rte_eventdev_port_data
> +  to rte_event_fp_ops, allows to fetch this data for fastpath eventdev inline functions
> +  in advance. This changes the size of rte_event_fp_ops and result in ABI change.
> +
>  * security: Hide structures ``rte_security_ops`` and ``rte_security_ctx``
>    as these are internal to DPDK library and drivers.
>  

+techboard,

Request for review/ack, patch is to extend eventdev to support callbacks
per packet.

^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: [PATCH v1] doc: deprecation notice to add callback data to rte_event_fp_ops
  2023-07-25  8:40   ` Ferruh Yigit
@ 2023-07-25 16:46     ` Hemant Agrawal
  2023-07-25 18:44       ` Pavan Nikhilesh Bhagavatula
  2023-07-28 15:42     ` Thomas Monjalon
  1 sibling, 1 reply; 12+ messages in thread
From: Hemant Agrawal @ 2023-07-25 16:46 UTC (permalink / raw)
  To: Ferruh Yigit, Sivaprasad Tummala, dev
  Cc: bruce.richardson, david.marchand, thomas, jerinjacobk, techboard

> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@amd.com>
> Sent: Tuesday, July 25, 2023 2:11 PM
> To: Sivaprasad Tummala <sivaprasad.tummala@amd.com>; dev@dpdk.org
> Cc: bruce.richardson@intel.com; david.marchand@redhat.com;
> thomas@monjalon.net; jerinjacobk@gmail.com; techboard@dpdk.org
> Subject: Re: [PATCH v1] doc: deprecation notice to add callback data to
> rte_event_fp_ops
> 
> On 7/17/2023 12:24 PM, Sivaprasad Tummala wrote:
> > Deprecation notice to add "rte_eventdev_port_data" field to
> > ``rte_event_fp_ops`` for callback support.
> >
> > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> > ---
> >  doc/guides/rel_notes/deprecation.rst | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index fb771a0305..057f97ce5a 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -130,6 +130,13 @@ Deprecation Notices
> >    ``rte_cryptodev_get_auth_algo_string``,
> ``rte_cryptodev_get_aead_algo_string`` and
> >    ``rte_cryptodev_asym_get_xform_string`` respectively.
> >
> > +* eventdev: The struct rte_event_fp_ops will be updated with a new
> > +element
> > +  rte_eventdev_port_data to support optional callbacks in DPDK 23.11.
> > +  rte_eventdev_port_data is used to hold callbacks registered
> > +optionally
> > +  per event device port and associated callback data. By adding
> > +rte_eventdev_port_data
> > +  to rte_event_fp_ops, allows to fetch this data for fastpath
> > +eventdev inline functions
> > +  in advance. This changes the size of rte_event_fp_ops and result in ABI
> change.
> > +
> >  * security: Hide structures ``rte_security_ops`` and ``rte_security_ctx``
> >    as these are internal to DPDK library and drivers.
> >
> 
> +techboard,
> 
> Request for review/ack, patch is to extend eventdev to support callbacks per
> packet.
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: [PATCH v1] doc: deprecation notice to add callback data to rte_event_fp_ops
  2023-07-25 16:46     ` Hemant Agrawal
@ 2023-07-25 18:44       ` Pavan Nikhilesh Bhagavatula
  0 siblings, 0 replies; 12+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2023-07-25 18:44 UTC (permalink / raw)
  To: Hemant Agrawal, Ferruh Yigit, Sivaprasad Tummala, dev
  Cc: bruce.richardson, david.marchand, thomas, jerinjacobk, techboard

> > -----Original Message-----
> > From: Ferruh Yigit <ferruh.yigit@amd.com>
> > Sent: Tuesday, July 25, 2023 2:11 PM
> > To: Sivaprasad Tummala <sivaprasad.tummala@amd.com>; dev@dpdk.org
> > Cc: bruce.richardson@intel.com; david.marchand@redhat.com;
> > thomas@monjalon.net; jerinjacobk@gmail.com; techboard@dpdk.org
> > Subject: Re: [PATCH v1] doc: deprecation notice to add callback data to
> > rte_event_fp_ops
> >
> > On 7/17/2023 12:24 PM, Sivaprasad Tummala wrote:
> > > Deprecation notice to add "rte_eventdev_port_data" field to
> > > ``rte_event_fp_ops`` for callback support.
> > >
> > > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> > > ---
> > >  doc/guides/rel_notes/deprecation.rst | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > >
> > > diff --git a/doc/guides/rel_notes/deprecation.rst
> > > b/doc/guides/rel_notes/deprecation.rst
> > > index fb771a0305..057f97ce5a 100644
> > > --- a/doc/guides/rel_notes/deprecation.rst
> > > +++ b/doc/guides/rel_notes/deprecation.rst
> > > @@ -130,6 +130,13 @@ Deprecation Notices
> > >    ``rte_cryptodev_get_auth_algo_string``,
> > ``rte_cryptodev_get_aead_algo_string`` and
> > >    ``rte_cryptodev_asym_get_xform_string`` respectively.
> > >
> > > +* eventdev: The struct rte_event_fp_ops will be updated with a new
> > > +element
> > > +  rte_eventdev_port_data to support optional callbacks in DPDK 23.11.
> > > +  rte_eventdev_port_data is used to hold callbacks registered
> > > +optionally
> > > +  per event device port and associated callback data. By adding
> > > +rte_eventdev_port_data
> > > +  to rte_event_fp_ops, allows to fetch this data for fastpath
> > > +eventdev inline functions
> > > +  in advance. This changes the size of rte_event_fp_ops and result in ABI
> > change.
> > > +
> > >  * security: Hide structures ``rte_security_ops`` and ``rte_security_ctx``
> > >    as these are internal to DPDK library and drivers.
> > >
> >
> > +techboard,
> >
> > Request for review/ack, patch is to extend eventdev to support callbacks
> per
> > packet.
> Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH v1] doc: deprecation notice to add callback data to rte_event_fp_ops
  2023-07-25  8:40   ` Ferruh Yigit
  2023-07-25 16:46     ` Hemant Agrawal
@ 2023-07-28 15:42     ` Thomas Monjalon
  1 sibling, 0 replies; 12+ messages in thread
From: Thomas Monjalon @ 2023-07-28 15:42 UTC (permalink / raw)
  To: Sivaprasad Tummala
  Cc: dev, bruce.richardson, david.marchand, jerinjacobk, techboard,
	Ferruh Yigit

25/07/2023 10:40, Ferruh Yigit:
> On 7/17/2023 12:24 PM, Sivaprasad Tummala wrote:
> > Deprecation notice to add "rte_eventdev_port_data" field to
> > ``rte_event_fp_ops`` for callback support.
> > 
> > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> > ---
> >  doc/guides/rel_notes/deprecation.rst | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> > index fb771a0305..057f97ce5a 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -130,6 +130,13 @@ Deprecation Notices
> >    ``rte_cryptodev_get_auth_algo_string``, ``rte_cryptodev_get_aead_algo_string`` and
> >    ``rte_cryptodev_asym_get_xform_string`` respectively.
> >  
> > +* eventdev: The struct rte_event_fp_ops will be updated with a new element
> > +  rte_eventdev_port_data to support optional callbacks in DPDK 23.11.
> > +  rte_eventdev_port_data is used to hold callbacks registered optionally
> > +  per event device port and associated callback data. By adding rte_eventdev_port_data
> > +  to rte_event_fp_ops, allows to fetch this data for fastpath eventdev inline functions
> > +  in advance. This changes the size of rte_event_fp_ops and result in ABI change.
> > +
> >  * security: Hide structures ``rte_security_ops`` and ``rte_security_ctx``
> >    as these are internal to DPDK library and drivers.
> >  
> 
> +techboard,
> 
> Request for review/ack, patch is to extend eventdev to support callbacks
> per packet.


It does not look necessary to announce adding new fields.
The ABI compatibility breakage should be covered by this patch:
https://patches.dpdk.org/project/dpdk/patch/20230728152052.1204486-1-thomas@monjalon.net/

Marking as superseded.



^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2023-07-28 15:42 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-12 17:30 [PATCH] doc: deprecation notice to add callback data to rte_event_fp_ops Sivaprasad Tummala
2023-07-13  8:51 ` Jerin Jacob
2023-07-13 10:38   ` Tummala, Sivaprasad
2023-07-13 10:40     ` Jerin Jacob
2023-07-14 11:32       ` Tummala, Sivaprasad
2023-07-17 11:24 ` [PATCH v1] " Sivaprasad Tummala
2023-07-17 11:43   ` Jerin Jacob
2023-07-17 12:42     ` Ferruh Yigit
2023-07-25  8:40   ` Ferruh Yigit
2023-07-25 16:46     ` Hemant Agrawal
2023-07-25 18:44       ` Pavan Nikhilesh Bhagavatula
2023-07-28 15:42     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).