From: Raslan Darawsheh <rasland@nvidia.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Bing Zhao <bingz@nvidia.com>,
"viacheslavo@mellanox.com" <viacheslavo@mellanox.com>,
"matan@mellanox.com" <matan@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, Ori Kam <orika@nvidia.com>,
"Andrey Vesnovaty" <andreyv@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix bit field compiling error
Date: Sun, 1 Nov 2020 07:36:41 +0000 [thread overview]
Message-ID: <BN7PR12MB2737B500641C49A989E49E03CF130@BN7PR12MB2737.namprd12.prod.outlook.com> (raw)
In-Reply-To: <0ec66de5-406f-1ca6-dfac-902af888eb60@intel.com>
Hi,
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Thursday, October 29, 2020 4:28 PM
> To: Raslan Darawsheh <rasland@nvidia.com>; Bing Zhao
> <bingz@nvidia.com>; viacheslavo@mellanox.com; matan@mellanox.com
> Cc: dev@dpdk.org; Ori Kam <orika@nvidia.com>; Andrey Vesnovaty
> <andreyv@nvidia.com>
> Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix bit field compiling error
>
> On 10/26/2020 6:07 PM, Raslan Darawsheh wrote:
> > Hi,
> >
> >
> >> -----Original Message-----
> >> From: Bing Zhao <bingz@nvidia.com>
> >> Sent: Monday, October 26, 2020 7:25 PM
> >> To: viacheslavo@mellanox.com; matan@mellanox.com
> >> Cc: dev@dpdk.org; Ori Kam <orika@nvidia.com>; Raslan Darawsheh
> >> <rasland@nvidia.com>; Andrey Vesnovaty <andreyv@nvidia.com>
> >> Subject: [PATCH] net/mlx5: fix bit field compiling error
> >>
> >> Some old compilers and old specification will not support bit field
> >> with other types except integer or unsigned integer.
> >> Since the next and previous items are 64b and/or 32b aligned, bit
> >> field with "unsigned char" type will not save any space and the
> >> compiler will complain.
> >> Changing it to "unsigned int" type bit field will solve the issue.
> >>
> >> Fixes: f711b60d400b ("net/mlx5: modify hash Rx queue objects")
> >> Cc: andreyv@nvidia.com
> >>
> >> Signed-off-by: Bing Zhao <bingz@nvidia.com>
> >> ---
> >> drivers/net/mlx5/mlx5.h | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
> >> index c537af9..e5640c1 100644
> >> --- a/drivers/net/mlx5/mlx5.h
> >> +++ b/drivers/net/mlx5/mlx5.h
> >> @@ -733,7 +733,7 @@ struct mlx5_ind_table_obj {
> >> struct mlx5_hrxq {
> >> ILIST_ENTRY(uint32_t)next; /* Index to the next element. */
> >> rte_atomic32_t refcnt; /* Reference counter. */
> >> - uint8_t shared:1; /* This object used in shared action. */
> >> + uint32_t shared:1; /* This object used in shared action. */
> >> struct mlx5_ind_table_obj *ind_table; /* Indirection table. */
> >> RTE_STD_C11
> >> union {
> >> --
> >> 1.8.3.1
> >
> > Patch squashed into relevant commit in next-net-mlx,
> >
>
> Hi Raslan,
>
> Updating patches that has been pulled by next-net makes very hard to pull
> your tree.
>
> Can you please squash only ones that are still only in the mlx tree, for others
> I can update in the next-net which is easier than resolving conflicts on merge.
>
Sure, and that's what I usually do not sure what happened and caused a squash for some pulled patches already.
> Thanks,
> Ferruh
Kindest regards
Raslan Darawsheh
prev parent reply other threads:[~2020-11-01 7:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 17:24 Bing Zhao
2020-10-26 18:07 ` Raslan Darawsheh
2020-10-29 14:28 ` Ferruh Yigit
2020-11-01 7:36 ` Raslan Darawsheh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BN7PR12MB2737B500641C49A989E49E03CF130@BN7PR12MB2737.namprd12.prod.outlook.com \
--to=rasland@nvidia.com \
--cc=andreyv@nvidia.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=matan@mellanox.com \
--cc=orika@nvidia.com \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).