Re: [dpdk-dev] [PATCH v2 3/3] drivers: align log names

["Wang, Xiao W" <xiao.w.wang@intel.com>]

Hi Thomas,

I agree with the "ifcvf" name, as there might be more than one driver in a single driver dir.

Thanks,
Xiao

> -----Original Message-----
> From: Xu, Rosen <rosen.xu@intel.com>
> Sent: Tuesday, April 6, 2021 5:48 PM
> To: Thomas Monjalon <thomas@monjalon.net>; Wang, Xiao W
> <xiao.w.wang@intel.com>
> Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>;
> Hemant Agrawal <hemant.agrawal@nxp.com>; Ajit Khaparde
> <ajit.khaparde@broadcom.com>; Griffin, John <john.griffin@intel.com>;
> Trahe, Fiona <fiona.trahe@intel.com>; Jain, Deepak K
> <deepak.k.jain@intel.com>; Raveendra Padasalagi
> <raveendra.padasalagi@broadcom.com>; Vikas Gupta
> <vikas.gupta@broadcom.com>; John W. Linville <linville@tuxdriver.com>;
> Chas Williams <chas3@att.com>; Min Hu (Connor)
> <humin29@huawei.com>; Zhang, Tianfei <tianfei.zhang@intel.com>; Nipun
> Gupta <nipun.gupta@nxp.com>; david.marchand@redhat.com
> Subject: RE: [PATCH v2 3/3] drivers: align log names
> 
> HI Thomas,
> 
> I'm ok, if you replace pmd.afu.ipn3ke with pmd.net.ipn3ke. Thanks your
> reminder.
> 
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Tuesday, April 06, 2021 17:31
> > To: Xu, Rosen <rosen.xu@intel.com>; Wang, Xiao W
> > <xiao.w.wang@intel.com>
> > Cc: dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>;
> > Hemant Agrawal <hemant.agrawal@nxp.com>; Ajit Khaparde
> > <ajit.khaparde@broadcom.com>; Griffin, John <john.griffin@intel.com>;
> > Trahe, Fiona <fiona.trahe@intel.com>; Jain, Deepak K
> > <deepak.k.jain@intel.com>; Raveendra Padasalagi
> > <raveendra.padasalagi@broadcom.com>; Vikas Gupta
> > <vikas.gupta@broadcom.com>; John W. Linville <linville@tuxdriver.com>;
> > Chas Williams <chas3@att.com>; Min Hu (Connor)
> <humin29@huawei.com>;
> > Zhang, Tianfei <tianfei.zhang@intel.com>; Nipun Gupta
> > <nipun.gupta@nxp.com>; david.marchand@redhat.com
> > Subject: Re: [PATCH v2 3/3] drivers: align log names
> >
> > Hi Rosen,
> >
> > You already gave your ack in previous version, no need to re-ack.
> > Instead, please give your opinion and explanation as requested below.
> > We want to replace pmd.afu.ipn3ke with pmd.net.ipn3ke.
> > The use of AFU in the driver is not clear.
> >
> > Xiao, we need your opinion as well about ifcvf vs ifc name.
> >
> >
> > > > The log levels are configured by using the name of the logs.
> > > > Some drivers are aligned to follow a common log name standard:
> > > > 	pmd.class.driver[.sub]
> > > > Some "common" drivers skip the "class" part:
> > > > 	pmd.driver.sub
> > > >
> > > > Two drivers have exceptions to be clarified:
> > > > 	pmd.vdpa.ifcvf instead of pmd.vdpa.ifc
> > > > 	pmd.afu.ipn3ke instead of pmd.net.ipn3ke
> > > >
> > > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > > > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> > > > Acked-by: Rosen Xu <rosen.xu@intel.com>
> > > > Acked-by: Xiao Wang <xiao.w.wang@intel.com>
> > > > Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > > > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> > [...]
> > > Acked-by: Rosen Xu <rosen.xu@intel.com>
> >
> >