From: Gregory Etelson <getelson@nvidia.com>
To: "andrew.rybchenko@oktetlabs.ru" <andrew.rybchenko@oktetlabs.ru>,
"dev@dpdk.org" <dev@dpdk.org>,
Raslan Darawsheh <rasland@nvidia.com>
Cc: Slava Ovsiienko <viacheslavo@nvidia.com>,
Ori Kam <orika@nvidia.com>, Xiaoyun Li <xiaoyun.li@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: add flow item to match on IPv4 version_ihl field
Date: Sun, 11 Jul 2021 10:25:57 +0000 [thread overview]
Message-ID: <BY5PR12MB48343A2DB5D07B05FAE70F39A5169@BY5PR12MB4834.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20210705115217.4768-1-getelson@nvidia.com>
Hello Andrew,
Can you estimate when that patch will be merged ?
Regards,
Gregory
> -----Original Message-----
> From: Gregory Etelson <getelson@nvidia.com>
> Sent: Monday, July 5, 2021 14:52
> To: dev@dpdk.org
> Cc: Gregory Etelson <getelson@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Xiaoyun Li
> <xiaoyun.li@intel.com>
> Subject: [PATCH] app/testpmd: add flow item to match on IPv4 version_ihl
> field
>
> The new item allows PMD to offload IPv4 IHL field for matching, if hardware
> supports that operation.
>
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> ---
> app/test-pmd/cmdline_flow.c | 12 +++++++++++-
> doc/guides/testpmd_app_ug/testpmd_funcs.rst | 1 +
> 2 files changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 1c587bb7b8..c1c7b9a9f9 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -173,6 +173,7 @@ enum index {
> ITEM_VLAN_INNER_TYPE,
> ITEM_VLAN_HAS_MORE_VLAN,
> ITEM_IPV4,
> + ITEM_IPV4_VER_IHL,
> ITEM_IPV4_TOS,
> ITEM_IPV4_ID,
> ITEM_IPV4_FRAGMENT_OFFSET,
> @@ -1071,6 +1072,7 @@ static const enum index item_vlan[] = { };
>
> static const enum index item_ipv4[] = {
> + ITEM_IPV4_VER_IHL,
> ITEM_IPV4_TOS,
> ITEM_IPV4_ID,
> ITEM_IPV4_FRAGMENT_OFFSET,
> @@ -2567,6 +2569,13 @@ static const struct token token_list[] = {
> .next = NEXT(item_ipv4),
> .call = parse_vc,
> },
> + [ITEM_IPV4_VER_IHL] = {
> + .name = "version_ihl",
> + .help = "match header length",
> + .next = NEXT(item_ipv4, NEXT_ENTRY(UNSIGNED),
> item_param),
> + .args = ARGS(ARGS_ENTRY(struct rte_flow_item_ipv4,
> + hdr.version_ihl)),
> + },
> [ITEM_IPV4_TOS] = {
> .name = "tos",
> .help = "type of service",
> @@ -8123,7 +8132,8 @@ update_fields(uint8_t *buf, struct rte_flow_item
> *item, uint16_t next_proto)
> break;
> case RTE_FLOW_ITEM_TYPE_IPV4:
> ipv4 = (struct rte_ipv4_hdr *)buf;
> - ipv4->version_ihl = 0x45;
> + if (!ipv4->version_ihl)
> + ipv4->version_ihl = RTE_IPV4_VHL_DEF;
> if (next_proto && ipv4->next_proto_id == 0)
> ipv4->next_proto_id = (uint8_t)next_proto;
> break;
> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> index 33857acf54..ab7e91ad6c 100644
> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> @@ -3654,6 +3654,7 @@ This section lists supported pattern items and
> their attributes, if any.
>
> - ``ipv4``: match IPv4 header.
>
> + - ``version_ihl {unsigned}``: IPv4 version and IP header length.
> - ``tos {unsigned}``: type of service.
> - ``ttl {unsigned}``: time to live.
> - ``proto {unsigned}``: next protocol ID.
> --
> 2.31.1
next prev parent reply other threads:[~2021-07-11 10:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-05 11:52 Gregory Etelson
2021-07-11 10:25 ` Gregory Etelson [this message]
2021-07-13 7:29 ` [dpdk-dev] [PATCH v2] " Gregory Etelson
2021-07-13 8:07 ` Andrew Rybchenko
2021-07-13 8:54 ` Gregory Etelson
2021-07-13 10:04 ` Andrew Rybchenko
2021-07-13 11:11 ` Slava Ovsiienko
2021-07-13 11:17 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR12MB48343A2DB5D07B05FAE70F39A5169@BY5PR12MB4834.namprd12.prod.outlook.com \
--to=getelson@nvidia.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=viacheslavo@nvidia.com \
--cc=xiaoyun.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).