From: "Mody, Rasesh" <Rasesh.Mody@cavium.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Dept-Eng DPDK Dev <Dept-EngDPDKDev@cavium.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] net/bnx2x: bump version to 1.0.7.1
Date: Mon, 19 Nov 2018 18:48:02 +0000 [thread overview]
Message-ID: <BYAPR07MB5365B714C97933F592B9BE1F9FD80@BYAPR07MB5365.namprd07.prod.outlook.com> (raw)
In-Reply-To: <ccce511d-8c79-4415-dc4d-4839b4518081@intel.com>
Hi Ferruh,
>From: Ferruh Yigit <ferruh.yigit@intel.com>
>Sent: Monday, November 19, 2018 5:28 AM
>
>On 11/17/2018 9:37 AM, Mody, Rasesh wrote:
>> Signed-off-by: Rasesh Mody <rasesh.mody@cavium.com>
>
>Hi Rasesh,
>
>18.11-rc4 is out and this patchset was late for it, I suggest postponing previous
>patch, `cleanup info logs`, in to next release (v19.02)
As `cleanup info logs` is non-critical patch it is ok to push it out to v19.02 and then pull it in v18.11 stable.
>
>But not sure about this patch, I guess this is to mark the changes in this
>release, it looks like there is no API using this information so applications don't
>require version information but it is just for logging.
>Can you please advise on to get or postpone this version update patch
>(without getting other patch in the series) ?
Yes, the version information is for logging and mark changes in current release. Can you please apply this patch to v18.11 release?
Thanks!
-Rasesh
>
>> ---
>> drivers/net/bnx2x/bnx2x.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c
>> index c80f84c..4c775c1 100644
>> --- a/drivers/net/bnx2x/bnx2x.c
>> +++ b/drivers/net/bnx2x/bnx2x.c
>> @@ -29,7 +29,7 @@
>> #define BNX2X_PMD_VER_PREFIX "BNX2X PMD"
>> #define BNX2X_PMD_VERSION_MAJOR 1
>> #define BNX2X_PMD_VERSION_MINOR 0
>> -#define BNX2X_PMD_VERSION_REVISION 6
>> +#define BNX2X_PMD_VERSION_REVISION 7
>> #define BNX2X_PMD_VERSION_PATCH 1
>>
>> static inline const char *
>>
next prev parent reply other threads:[~2018-11-19 18:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 18:17 [dpdk-dev] [PATCH 1/2] net/bnx2x: cleanup info logs Mody, Rasesh
2018-11-14 18:17 ` [dpdk-dev] [PATCH 2/2] net/bnx2x: bump version to 1.0.7.1 Mody, Rasesh
2018-11-16 11:26 ` [dpdk-dev] [PATCH 1/2] net/bnx2x: cleanup info logs Ferruh Yigit
2018-11-17 9:38 ` Mody, Rasesh
2018-11-17 9:37 ` [dpdk-dev] [PATCH v2 " Mody, Rasesh
2018-11-27 15:30 ` Ferruh Yigit
2018-11-17 9:37 ` [dpdk-dev] [PATCH v2 2/2] net/bnx2x: bump version to 1.0.7.1 Mody, Rasesh
2018-11-19 13:27 ` Ferruh Yigit
2018-11-19 18:48 ` Mody, Rasesh [this message]
2018-11-20 9:22 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR07MB5365B714C97933F592B9BE1F9FD80@BYAPR07MB5365.namprd07.prod.outlook.com \
--to=rasesh.mody@cavium.com \
--cc=Dept-EngDPDKDev@cavium.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).