DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Liu, Lingyu" <lingyu.liu@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Olivier Matz <olivier.matz@6wind.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [dpdk-dev] [PATCH v2] mbuf: support eCPRI hardware packet type
Date: Thu, 22 Apr 2021 11:09:34 +0000
Message-ID: <BYAPR11MB30471EE2BE32C637BDE41DF091469@BYAPR11MB3047.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1960280.AK4zKTLmrX@thomas>

> 20/04/2021 04:17, Liu, Lingyu:
> > Hi Olivier,
> >
> > This new packet type will be used by iavf driver to map ECPRI hardware
> packet.
> > This is the patch which will use this new hardware packet type.
> > http://patchwork.dpdk.org/project/dpdk/patch/20210420083817.10741-3-
> li
> > ngyu.liu@intel.com/
> 
> I think it does not reply Olivier's question about how it will be used.
> Why is it important to report this packet type in mbuf?
> 
> PS: please do not top-post
> 
In current implementation(w/o this patch), when receiving a eCPRI packet, testpmd prints like this:
"port 2/queue 0: received 1 packets
  src=00:00:00:00:00:00 - dst=00:11:22:33:44:77 - type=0x0800 - length=60 - nb_segs=1 - hw ptype: L2_ETHER L3_IPV4_EXT_UNKNOWN L4_UDP  - sw ptype: L2_ETHER L3_IPV4 L4_UDP  - l2_len=14 - l3_len=20 - l4_len=8 - Receive queue=0x0
  ol_flags: PKT_RX_L4_CKSUM_GOOD PKT_RX_IP_CKSUM_GOOD PKT_RX_OUTER_L4_CKSUM_UNKNOWN"
We can't know the hw ptype.

After adding this patch, when receiving an eCPRI packet, testpmd can print like this:
" port 1/queue 0: received 1 packets
  src=00:00:00:00:00:00 - dst=00:11:22:33:44:11 - type=0x0800 - length=60 - nb_segs=1 - hw ptype: L2_ETHER L3_IPV4_EXT_UNKNOWN L4_UDP TUNNEL_ECPRI  - sw ptype: L2_ETHER L3_IPV4 L4_UDP  - l2_len=14 - l3_len=20 - l4_len=8 - ECPRI packet: packet type =58001, Destination UDP port =20771 - Receive queue=0x0
  ol_flags: PKT_RX_L4_CKSUM_GOOD PKT_RX_IP_CKSUM_GOOD PKT_RX_OUTER_L4_CKSUM_UNKNOWN
"
Then apps can recognize the packet type using hw ptype. This supports more complete packet types and protocols.

> 
> > > From: Olivier Matz <olivier.matz@6wind.com>
> > >
> > > Hi Lingyu,
> > >
> > > On Sat, Apr 17, 2021 at 09:25:31AM +0000, Lingyu Liu wrote:
> > > > Add L2_ETHER_ECPRI and L4_UDP_TUNNEL_ECPRI in RTE_PTYPE.
> > > >
> > > > Signed-off-by: Lingyu Liu <lingyu.liu@intel.com>
> > > > Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> > >
> > > The number of available packet types for tunnels is quite low
> > > (already mentionned in this thread [1]).
> > >
> > > [1]
> > > https://patches.dpdk.org/project/dpdk/patch/20210408081720.23314-3-
> > > ktejasree@marvell.com
> > >
> > > Can you give some details about how it will be used? For instance,
> > > which driver will set it, which kind of application will use it.
> > >
> > > Thanks,
> > > Olivier
> 
> 


  parent reply	other threads:[~2021-04-22 11:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-17  9:04 [dpdk-dev] [PATCH v1] mbuf: support eCPRI hardware packet type Add L2_ETHER_ECPRI and L4_UDP_TUNNEL_ECPRI in RTE_PTYPE Lingyu Liu
2021-04-17  9:25 ` [dpdk-dev] [PATCH v2] mbuf: support eCPRI hardware packet type Lingyu Liu
2021-04-19 14:24   ` Olivier Matz
2021-04-20  2:17     ` Liu, Lingyu
2021-04-20  7:51       ` Thomas Monjalon
2021-04-20 10:06         ` Andrew Rybchenko
2021-04-22 11:09         ` Liu, Lingyu [this message]
2021-04-20 13:01       ` Bing Zhao
2021-04-20  8:38   ` [dpdk-dev] [PATCH V3 0/2] mbuf:add eCPRI hardware packet type mapping Lingyu Liu
2021-04-20  8:38     ` [dpdk-dev] [PATCH V3 1/2] mbuf: support eCPRI hardware packet type Lingyu Liu
2021-04-20  9:57       ` Andrew Rybchenko
2021-04-20  8:38     ` [dpdk-dev] [PATCH V3 2/2] net/iavf: update PTYPE mapping for eCPRI Lingyu Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR11MB30471EE2BE32C637BDE41DF091469@BYAPR11MB3047.namprd11.prod.outlook.com \
    --to=lingyu.liu@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=olivier.matz@6wind.com \
    --cc=qi.z.zhang@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git