From: "Wang, ShougangX" <shougangx.wang@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>,
"Sun, GuinanX" <guinanx.sun@intel.com>,
"Guo, Jia" <jia.guo@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Sun, GuinanX" <guinanx.sun@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix link status
Date: Fri, 31 Jul 2020 02:37:46 +0000 [thread overview]
Message-ID: <BYAPR11MB3477F891DDB86DBDE44E3D1C884E0@BYAPR11MB3477.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MN2PR11MB3807DBB017D1C927B40A6D8CF74E0@MN2PR11MB3807.namprd11.prod.outlook.com>
Hi Beilei
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Xing, Beilei
> Sent: Friday, July 31, 2020 10:30 AM
> To: Sun, GuinanX <guinanx.sun@intel.com>; Guo, Jia <jia.guo@intel.com>;
> dev@dpdk.org
> Cc: Sun, GuinanX <guinanx.sun@intel.com>; stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix link status
>
>
>
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Guinan Sun
> > Sent: Thursday, July 30, 2020 6:25 PM
> > To: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia
> > <jia.guo@intel.com>; dev@dpdk.org
> > Cc: Sun, GuinanX <guinanx.sun@intel.com>; stable@dpdk.org
> > Subject: [dpdk-dev] [PATCH v2] net/i40e: fix link status
> >
> > If the PF driver supports the new speed reporting capabilities then
> > use link_event_adv instead of link_event to get the speed.
> >
> > Fixes: 2a73125b7041 ("i40evf: fix link info update")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> > ---
> > v2:
> > * Modify commit log.
> > * Add code comments.
> > * Delete useless codes.
> > ---
> > drivers/net/i40e/base/virtchnl.h | 16 +++++++++++-
> > drivers/net/i40e/i40e_ethdev_vf.c | 42
> +++++++++++++++++++++++++++++--
> > 2 files changed, 55 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/net/i40e/base/virtchnl.h
> > b/drivers/net/i40e/base/virtchnl.h
> > index 4f498ca45..9c64fd469 100644
> > --- a/drivers/net/i40e/base/virtchnl.h
> > +++ b/drivers/net/i40e/base/virtchnl.h
> > @@ -240,7 +240,8 @@ VIRTCHNL_CHECK_STRUCT_LEN(16,
> > virtchnl_vsi_resource);
> > #define VIRTCHNL_VF_OFFLOAD_ENCAP 0X00100000
> > #define VIRTCHNL_VF_OFFLOAD_ENCAP_CSUM 0X00200000
> > #define VIRTCHNL_VF_OFFLOAD_RX_ENCAP_CSUM 0X00400000
> > -
> > +/* Define below the capability flags that are not offloads */
> > +#define VIRTCHNL_VF_CAP_ADV_LINK_SPEED 0x00000080
>
> You defined the new capability VIRTCHNL_VF_CAP_ADV_LINK_SPEED in the
> patch, but didn't request the capability for i40evf?
This capability is given by i40e kernel pf if VIRTCHNL_VF_CAP_ADV_LINK_SPEED is defined. So vf doesn't need to request it.
Thanks.
Shougang
next prev parent reply other threads:[~2020-07-31 2:37 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-30 8:25 [dpdk-dev] [PATCH] " Guinan Sun
2020-07-30 9:12 ` Jeff Guo
2020-07-30 9:26 ` Sun, GuinanX
2020-07-30 10:25 ` [dpdk-dev] [PATCH v2] " Guinan Sun
2020-07-30 10:51 ` Wang, ShougangX
2020-07-30 10:57 ` Jeff Guo
2020-07-31 2:29 ` Xing, Beilei
2020-07-31 2:37 ` Wang, ShougangX [this message]
2020-07-31 3:50 ` Xing, Beilei
2020-07-31 4:09 ` Sun, GuinanX
2020-08-06 8:16 ` [dpdk-dev] [PATCH v3] " Guinan Sun
2020-08-06 9:46 ` Wang, ShougangX
2020-08-06 10:08 ` Xing, Beilei
2020-08-07 2:09 ` Jeff Guo
2020-08-31 0:52 ` Zhang, Qi Z
2020-08-31 13:24 ` [dpdk-dev] [dpdk-stable] " Ferruh Yigit
2020-09-01 8:52 ` Sun, GuinanX
2020-09-02 8:06 ` [dpdk-dev] [PATCH v4] " Guinan Sun
2020-09-03 8:38 ` Jeff Guo
2020-09-03 8:43 ` Min, JiaqiX
2020-09-04 6:21 ` [dpdk-dev] [PATCH v5] " Guinan Sun
2020-09-07 5:04 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR11MB3477F891DDB86DBDE44E3D1C884E0@BYAPR11MB3477.namprd11.prod.outlook.com \
--to=shougangx.wang@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=guinanx.sun@intel.com \
--cc=jia.guo@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).