From: "Xie, Huawei" <huawei.xie@intel.com> To: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>, "dev@dpdk.org" <dev@dpdk.org> Cc: Hayato Momma <h-momma@ce.jp.nec.com> Subject: Re: [dpdk-dev] [PATCH] rte_memory.h: include stdio.h for FILE Date: Tue, 17 Jun 2014 03:48:23 +0000 Message-ID: <C37D651A908B024F974696C65296B57B0F210465@SHSMSX101.ccr.corp.intel.com> (raw) In-Reply-To: <7F861DC0615E0C47A872E6F3C5FCDDBD0110E6A2@BPXM14GP.gisp.nec.co.jp> Hi Shimamoto: At least rte_tailq.h, rte_mbuf.h should also include stdio.h. -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hiroshi Shimamoto Sent: Thursday, June 12, 2014 4:11 PM To: dev@dpdk.org Cc: Hayato Momma Subject: [dpdk-dev] [PATCH] rte_memory.h: include stdio.h for FILE From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> The below commit requires stdio FILE structure. commit 591a9d7985c1230652d9f7ea1f9221e8c66ec188 Author: Stephen Hemminger <stephen@networkplumber.org> Date: Fri May 2 16:42:56 2014 -0700 add FILE argument to debug functions Application which includes rte_memory.h without stdio.h will be hit compilation failure. /path/to/include/rte_memory.h:146:30: error: unknown type name 'FILE' void rte_dump_physmem_layout(FILE *f); Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> Reviewed-by: Hayato Momma <h-momma@ce.jp.nec.com> --- lib/librte_eal/common/include/rte_memory.h | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/librte_eal/common/include/rte_memory.h b/lib/librte_eal/common/include/rte_memory.h index 7f21244..4cf8ea9 100644 --- a/lib/librte_eal/common/include/rte_memory.h +++ b/lib/librte_eal/common/include/rte_memory.h @@ -42,6 +42,7 @@ #include <stdint.h> #include <stddef.h> +#include <stdio.h> #ifdef RTE_EXEC_ENV_LINUXAPP #include <exec-env/rte_dom0_common.h> -- 1.9.1
next prev parent reply other threads:[~2014-06-17 3:48 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-06-12 8:10 Hiroshi Shimamoto 2014-06-17 3:48 ` Xie, Huawei [this message] 2014-06-25 9:51 ` Thomas Monjalon 2014-06-27 0:11 ` Thomas Monjalon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=C37D651A908B024F974696C65296B57B0F210465@SHSMSX101.ccr.corp.intel.com \ --to=huawei.xie@intel.com \ --cc=dev@dpdk.org \ --cc=h-momma@ce.jp.nec.com \ --cc=h-shimamoto@ct.jp.nec.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git