* [dpdk-dev] [PATCH] app/compress-perf: call generic strlcpy
@ 2019-02-24 22:42 Thomas Monjalon
2019-02-25 6:22 ` Rami Rosen
2019-03-13 13:21 ` Jozwiak, TomaszX
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Monjalon @ 2019-02-24 22:42 UTC (permalink / raw)
To: Pablo De Lara Guarch; +Cc: dev, tomaszx.jozwiak
The call to strlcpy uses either libc, libbsd or internal rte_strlcpy.
No need to call the DPDK flavor explictly.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
app/test-compress-perf/comp_perf_options_parse.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/app/test-compress-perf/comp_perf_options_parse.c b/app/test-compress-perf/comp_perf_options_parse.c
index 66eb81fc59..d2b208de35 100644
--- a/app/test-compress-perf/comp_perf_options_parse.c
+++ b/app/test-compress-perf/comp_perf_options_parse.c
@@ -373,7 +373,7 @@ parse_driver_name(struct comp_test_data *test_data, const char *arg)
if (strlen(arg) > (sizeof(test_data->driver_name) - 1))
return -1;
- rte_strlcpy(test_data->driver_name, arg,
+ strlcpy(test_data->driver_name, arg,
sizeof(test_data->driver_name));
return 0;
@@ -385,7 +385,7 @@ parse_test_file(struct comp_test_data *test_data, const char *arg)
if (strlen(arg) > (sizeof(test_data->input_file) - 1))
return -1;
- rte_strlcpy(test_data->input_file, arg, sizeof(test_data->input_file));
+ strlcpy(test_data->input_file, arg, sizeof(test_data->input_file));
return 0;
}
--
2.20.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] app/compress-perf: call generic strlcpy
2019-02-24 22:42 [dpdk-dev] [PATCH] app/compress-perf: call generic strlcpy Thomas Monjalon
@ 2019-02-25 6:22 ` Rami Rosen
2019-02-25 15:51 ` Ferruh Yigit
2019-03-13 13:21 ` Jozwiak, TomaszX
1 sibling, 1 reply; 4+ messages in thread
From: Rami Rosen @ 2019-02-25 6:22 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: Pablo De Lara Guarch, dev, tomaszx.jozwiak
Checked on Fedora 28
Reviewed-by: Rami Rosen <ramirose at gmail.com>
On Mon, Feb 25, 2019 at 12:42 AM Thomas Monjalon <thomas@monjalon.net>
wrote:
> The call to strlcpy uses either libc, libbsd or internal rte_strlcpy.
> No need to call the DPDK flavor explictly.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> app/test-compress-perf/comp_perf_options_parse.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-compress-perf/comp_perf_options_parse.c
> b/app/test-compress-perf/comp_perf_options_parse.c
> index 66eb81fc59..d2b208de35 100644
> --- a/app/test-compress-perf/comp_perf_options_parse.c
> +++ b/app/test-compress-perf/comp_perf_options_parse.c
> @@ -373,7 +373,7 @@ parse_driver_name(struct comp_test_data *test_data,
> const char *arg)
> if (strlen(arg) > (sizeof(test_data->driver_name) - 1))
> return -1;
>
> - rte_strlcpy(test_data->driver_name, arg,
> + strlcpy(test_data->driver_name, arg,
> sizeof(test_data->driver_name));
>
> return 0;
> @@ -385,7 +385,7 @@ parse_test_file(struct comp_test_data *test_data,
> const char *arg)
> if (strlen(arg) > (sizeof(test_data->input_file) - 1))
> return -1;
>
> - rte_strlcpy(test_data->input_file, arg,
> sizeof(test_data->input_file));
> + strlcpy(test_data->input_file, arg, sizeof(test_data->input_file));
>
> return 0;
> }
> --
> 2.20.1
>
>
--
regards,
Rami Rosen
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] app/compress-perf: call generic strlcpy
2019-02-25 6:22 ` Rami Rosen
@ 2019-02-25 15:51 ` Ferruh Yigit
0 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2019-02-25 15:51 UTC (permalink / raw)
To: Rami Rosen, Thomas Monjalon; +Cc: Pablo De Lara Guarch, dev, tomaszx.jozwiak
On 2/25/2019 6:22 AM, Rami Rosen wrote:
> Checked on Fedora 28
>
> On Mon, Feb 25, 2019 at 12:42 AM Thomas Monjalon <thomas@monjalon.net>
> wrote:
>
>> The call to strlcpy uses either libc, libbsd or internal rte_strlcpy.
>> No need to call the DPDK flavor explictly.
>>
>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> Reviewed-by: Rami Rosen <ramirose@gmail.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] app/compress-perf: call generic strlcpy
2019-02-24 22:42 [dpdk-dev] [PATCH] app/compress-perf: call generic strlcpy Thomas Monjalon
2019-02-25 6:22 ` Rami Rosen
@ 2019-03-13 13:21 ` Jozwiak, TomaszX
1 sibling, 0 replies; 4+ messages in thread
From: Jozwiak, TomaszX @ 2019-03-13 13:21 UTC (permalink / raw)
To: Thomas Monjalon, De Lara Guarch, Pablo; +Cc: dev
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Sunday, February 24, 2019 11:42 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Cc: dev@dpdk.org; Jozwiak, TomaszX <tomaszx.jozwiak@intel.com>
> Subject: [PATCH] app/compress-perf: call generic strlcpy
>
> The call to strlcpy uses either libc, libbsd or internal rte_strlcpy.
> No need to call the DPDK flavor explictly.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 2.20.1
Acked-by: Tomasz Jozwiak <tomaszx.jozwiak@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-03-13 13:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-24 22:42 [dpdk-dev] [PATCH] app/compress-perf: call generic strlcpy Thomas Monjalon
2019-02-25 6:22 ` Rami Rosen
2019-02-25 15:51 ` Ferruh Yigit
2019-03-13 13:21 ` Jozwiak, TomaszX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).