DPDK patches and discussions
 help / color / mirror / Atom feed
From: Luke Gorrie <luke@snabb.co>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] vhost: flush used->idx update before reading avail->flags
Date: Wed, 10 Jun 2015 10:30:01 +0200	[thread overview]
Message-ID: <CAA2XHbfY96wCZUxewr32dfE3DYU3MGxhgOpJCac1kEFuPAAFZA@mail.gmail.com> (raw)
In-Reply-To: <20150609084613.GA18121@redhat.com>

On 9 June 2015 at 10:46, Michael S. Tsirkin <mst@redhat.com> wrote:

> By the way, similarly, host side must re-check avail idx after writing
> used flags. I don't see where snabbswitch does it - is that a bug
> in snabbswitch?


Good question.

Snabb Switch does not use interrupts from the guest. We always set
VRING_F_NO_NOTIFY to tell the guest that it need not interrupt us. Then we
run in poll mode and in practice check the avail ring for new descriptors
every 20us or so.

So the argument for not needing this check in both Snabb Switch and DPDK is
that we are running poll mode and don't notice whether interrupts are being
sent or not.

Is that a solid argument or do I misunderstand what the race condition is?

Cheers,
-Luke

  parent reply	other threads:[~2015-06-10  8:30 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-22 16:33 Huawei Xie
2015-04-23 13:57 ` Luke Gorrie
2015-04-24  1:01 ` Linhaifeng
2015-04-24  2:40   ` Xie, Huawei
2015-04-24  7:27   ` Luke Gorrie
2015-06-09  7:04     ` Linhaifeng
2015-06-09  7:45       ` Luke Gorrie
2015-06-09  8:46       ` Michael S. Tsirkin
2015-06-09 13:34         ` Xie, Huawei
2015-06-10  2:36           ` Linhaifeng
2015-06-10  8:30         ` Luke Gorrie [this message]
2015-06-11  0:50           ` Linhaifeng
2015-04-29 11:11 ` [dpdk-dev] [PATCH v2] " Huawei Xie
2015-05-13 10:46   ` Thomas Monjalon
2015-05-15 13:43     ` Nikita Kalyazin
2015-05-15 15:23       ` Michael S. Tsirkin
2015-05-18  6:18         ` Nikita Kalyazin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAA2XHbfY96wCZUxewr32dfE3DYU3MGxhgOpJCac1kEFuPAAFZA@mail.gmail.com \
    --to=luke@snabb.co \
    --cc=dev@dpdk.org \
    --cc=mst@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).