From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Kalesh A P <kalesh-anakkur.purayil@broadcom.com>
Cc: dpdk-dev <dev@dpdk.org>, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix to advance producer index
Date: Wed, 20 May 2020 15:08:10 -0700 [thread overview]
Message-ID: <CACZ4nht64i65T2UHOoKh8AKSoHzEFfjLcitnB2Mv6shbkr7tNA@mail.gmail.com> (raw)
In-Reply-To: <20200520173918.13969-1-kalesh-anakkur.purayil@broadcom.com>
On Wed, May 20, 2020 at 10:23 AM Kalesh A P <
kalesh-anakkur.purayil@broadcom.com> wrote:
> From: Rahul Gupta <rahul.gupta@broadcom.com>
>
> When a queue is started after deferred_start, then increment raw_prod
> irrespective of new mbuf is allocated or old mbufs are used.
>
> Fixes: d256c73c1122 ("net/bnxt: fix memory leak during queue restart")
> Cc: stable@dpdk.org
>
> Signed-off-by: Rahul Gupta <rahul.gupta@broadcom.com>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
Patch applied to dpdk-next-net-brcm. Thanks
> ---
> drivers/net/bnxt/bnxt_rxr.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
> index d2955ba..ee1acb1 100644
> --- a/drivers/net/bnxt/bnxt_rxr.c
> +++ b/drivers/net/bnxt/bnxt_rxr.c
> @@ -987,9 +987,9 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue *rxq)
> rxq->queue_id, i,
> ring->ring_size);
> break;
> }
> - rxr->rx_prod = prod;
> - prod = RING_NEXT(rxr->rx_ring_struct, prod);
> }
> + rxr->rx_prod = prod;
> + prod = RING_NEXT(rxr->rx_ring_struct, prod);
> }
>
> ring = rxr->ag_ring_struct;
> @@ -1005,9 +1005,9 @@ int bnxt_init_one_rx_ring(struct bnxt_rx_queue *rxq)
> rxq->queue_id, i,
> ring->ring_size);
> break;
> }
> - rxr->ag_prod = prod;
> - prod = RING_NEXT(rxr->ag_ring_struct, prod);
> }
> + rxr->ag_prod = prod;
> + prod = RING_NEXT(rxr->ag_ring_struct, prod);
> }
> PMD_DRV_LOG(DEBUG, "AGG Done!\n");
>
> --
> 2.10.1
>
>
prev parent reply other threads:[~2020-05-20 22:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 17:39 Kalesh A P
2020-05-20 22:08 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACZ4nht64i65T2UHOoKh8AKSoHzEFfjLcitnB2Mv6shbkr7tNA@mail.gmail.com \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).