Re: [dpdk-dev] [PATCH 3/4] bnxt: Add support for Async Link Notification

[Ajit Khaparde <ajit.khaparde@broadcom.com>]

On Mon, Oct 10, 2016 at 10:40 AM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:

> Hi Ajit,
>
> On 9/29/2016 6:03 PM, Ajit Khaparde wrote:
> > This patch adds support to get Link notification asynchronously.
> > The HW sends Async notifications on default completion ring. The
> > PMD processes these notifications and logs a message appropriately.
> >
> > Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> > ---
> >  drivers/net/bnxt/Makefile      |   1 +
> >  drivers/net/bnxt/bnxt.h        |   6 +-
> >  drivers/net/bnxt/bnxt_cpr.c    |  21 +++---
> >  drivers/net/bnxt/bnxt_ethdev.c | 114 ++++++++++++++++++++++++++----
> >  drivers/net/bnxt/bnxt_hwrm.c   |  93 ++++++++++++------------
> >  drivers/net/bnxt/bnxt_irq.c    | 156 ++++++++++++++++++++++++++++++
> +++++++++++
> >  drivers/net/bnxt/bnxt_irq.h    |  51 ++++++++++++++
> >  7 files changed, 367 insertions(+), 75 deletions(-)
> >  create mode 100644 drivers/net/bnxt/bnxt_irq.c
> >  create mode 100644 drivers/net/bnxt/bnxt_irq.h
> >
>
> <...>
>
> > +static inline int
> > +rte_bnxt_atomic_read_link_status(struct rte_eth_dev *eth_dev,
> > +                             struct rte_eth_link *link)
> > +{
> > +     struct rte_eth_link *dst = link;
> > +     struct rte_eth_link *src = &eth_dev->data->dev_link;
> > +
> > +     if (rte_atomic64_cmpset((uint64_t *)dst, *(uint64_t *)dst,
> > +                                     *(uint64_t *)src) == 0)
> > +             return 1;
> > +
> > +     return 0;
> > +}
> > +
>
> This creates a compilation error:
> .../drivers/net/bnxt/bnxt_ethdev.c:444:1:
> error: unused function 'rte_bnxt_atomic_read_link_status'
> [-Werror,-Wunused-function]
> rte_bnxt_atomic_read_link_status(struct rte_eth_dev *eth_dev,
> ^
>
> Since the patches in this patchet really not related, it is OK to send a
> ​​
> new version of just this patch.
>
​Sure. Let me respin it. Thanks
​


>
> Thanks,
> ferruh
>
>