From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: dpdk-dev <dev@dpdk.org>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix a segfault during close
Date: Fri, 22 May 2020 17:26:46 -0700 [thread overview]
Message-ID: <CACZ4nhv+hWtDhOKz-QY8-dySEzcWnyNR=Q_JzbgX5NVdPu_BwA@mail.gmail.com> (raw)
In-Reply-To: <20200522212731.94269-1-ajit.khaparde@broadcom.com>
On Fri, May 22, 2020 at 2:27 PM Ajit Khaparde <ajit.khaparde@broadcom.com>
wrote:
> We are freeing flow_stats a little early. This results in a
> segfault when the driver accesses the members during cleanup.
> Move the call to bnxt_free_flow_stats_info() to prevent this.
>
> Fixes: 02a95625fe9c ("net/bnxt: add flow stats in extended stats")
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
Patch applied to dpdk-next-net-brcm.
> ---
> drivers/net/bnxt/bnxt_ethdev.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c
> b/drivers/net/bnxt/bnxt_ethdev.c
> index e63578109..e8b4c058a 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -221,8 +221,6 @@ static void bnxt_free_cos_queues(struct bnxt *bp)
>
> static void bnxt_free_mem(struct bnxt *bp, bool reconfig)
> {
> - bnxt_free_flow_stats_info(bp);
> -
> bnxt_free_filter_mem(bp);
> bnxt_free_vnic_attributes(bp);
> bnxt_free_vnic_mem(bp);
> @@ -5613,6 +5611,7 @@ bnxt_uninit_resources(struct bnxt *bp, bool
> reconfig_dev)
> bnxt_uninit_ctx_mem(bp);
>
> bnxt_uninit_locks(bp);
> + bnxt_free_flow_stats_info(bp);
> rte_free(bp->ptp_cfg);
> bp->ptp_cfg = NULL;
> return rc;
> --
> 2.21.1 (Apple Git-122.3)
>
>
prev parent reply other threads:[~2020-05-23 0:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 21:27 Ajit Khaparde
2020-05-23 0:26 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhv+hWtDhOKz-QY8-dySEzcWnyNR=Q_JzbgX5NVdPu_BwA@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).