Re: [dpdk-dev] [PATCH v10 0/3] deduplicate EAL common functions

[Ravi Kerur <rkerur@gmail.com>]

Hi Olivier,


On Thu, Jul 30, 2015 at 1:12 AM, Olivier MATZ <olivier.matz@6wind.com>
wrote:

> Hi Thomas & Ravi,
>
>
> On 07/27/2015 02:59 AM, Thomas Monjalon wrote:
>
>> 2015-07-27 02:56, Thomas Monjalon:
>>
>>> v9 was a subset of previous deduplications by Ravi Kerur.
>>> This v10 address the comments I've done on v9.
>>>
>>> Ravi Kerur (3):
>>>    eal: deduplicate lcore initialization
>>>    eal: deduplicate timer functions
>>>    eal: deduplicate memory initialization
>>>
>>
>> Applied shortly to integrate this old pending cleanup in RC2.
>>
>>
> When I try to compile the dpdk for x86_x32-native-linuxapp-gcc , I
> get the following compilation error:
>
>   CC eal_common_timer.o
> In file included from /usr/include/sys/sysctl.h:63:0,
>                  from /home/matz/dpdk-pkg-cron/
> dpdk.org/lib/librte_eal/common/eal_common_timer.c:39:
> /usr/include/bits/sysctl.h:19:3: error: #error "sysctl system call is
> unsupported in x32 kernel"
>  # error "sysctl system call is unsupported in x32 kernel"
>    ^
>
> Removing the "#include <sys/sysctl.h>" line fixes the issue without
> impacting the compilation. I think this include is not needed and
> could be removed.
> I can provide a patch if it's ok for you.
>
>
If it compiles fine on FreeBSD then it should be fine. It primarily needed
for eal_timer.c in FreeBSD environment, during code movement it slipped
through my mind. Sorry for the inconvenience.

Thanks,
Ravi


> Regards,
> Olivier
>
>