Re: [dpdk-dev] [dpdk-stable] [PATCH] net/vmxnet3: keep link state consistent

[Chas Williams <3chas3@gmail.com>]

On Tue, Mar 20, 2018 at 10:12 AM, Ferruh Yigit <ferruh.yigit@intel.com>
wrote:

> On 3/18/2018 1:45 AM, Chas Williams wrote:
> > From: Chas Williams <chas3@att.com>
> >
> > The vmxnet3 never attempts link speed negotiation.  As a virtual device
> > the link speed is vague at best.  However, it is important for certain
> > applications, like bonding, to see a consistent link_status.  802.3ad
> > requires that only links of the same cost (link speed) be enslaved.
> > Keeping the link status consistent in vmxnet3 avoids races with bonding
> > enslavement.
> >
> > Author: Thomas Monjalon <thomas@monjalon.net>
> > Date:   Fri Jan 5 18:38:55 2018 +0100
>

Didn't mean for this to be in the commit message.  I will submit a v2.


> >
> > Fixes: 1e3a958f40b3 ("ethdev: fix link autonegotiation value")
> > Cc: stable@dpdk.org
>
> There were a few more PMDs [1] they have been updated from FIXED to
> AUTONEG with
> above commit, do you think should we update them back to FIXED as well?
>

Same comments as above apply.  link_autoneg implies that there is some sort
of
autonegotiation.  Unless there is actually sort some of autonegotiating
happening
there isn't a reason to indicate it.


> [1]
> pcap
> softnic
> vmxnet3
>
> >
> > Signed-off-by: Chas Williams <chas3@att.com>
> > ---
> >  drivers/net/vmxnet3/vmxnet3_ethdev.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/vmxnet3/vmxnet3_ethdev.c
> b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> > index 426008722..48a4d4f98 100644
> > --- a/drivers/net/vmxnet3/vmxnet3_ethdev.c
> > +++ b/drivers/net/vmxnet3/vmxnet3_ethdev.c
> > @@ -1105,7 +1105,7 @@ __vmxnet3_dev_link_update(struct rte_eth_dev *dev,
> >               link.link_status = ETH_LINK_UP;
> >       link.link_duplex = ETH_LINK_FULL_DUPLEX;
> >       link.link_speed = ETH_SPEED_NUM_10G;
> > -     link.link_autoneg = ETH_LINK_AUTONEG;
> > +     link.link_autoneg = ETH_LINK_FIXED;
> >
> >       return rte_eth_linkstatus_set(dev, &link);
> >  }
> >
>
>