DPDK patches and discussions
 help / color / mirror / Atom feed
From: Victor Huertas <vhuertas@gmail.com>
To: dev@dpdk.org
Subject: Re: [dpdk-dev] Tx vlan offload problem with igb and DPDK v17.11
Date: Tue, 4 Sep 2018 13:13:33 +0200	[thread overview]
Message-ID: <CAGxG5chZ1Ogn-ZDL64_7ceRx9OwhveoC-uurg2m0Mf31DnbY8A@mail.gmail.com> (raw)
In-Reply-To: <CAGxG5cie0XnUKXHtfutg5Mio-jGXPFiURb9ammw7nSeWr2WSnw@mail.gmail.com>

Hi all,

I have solved the issue of the  PKT_TX_VLAN_PKT using the SW version
rte_vlan_insert function.
However I would like to tell you what I have seen during my tests. I hope
it can shed a light on the issue you the developers should correct.

When I use m->old_flags |= PKT_TX_VLAN_PKT  my Wireshark captures reveals
that the 802.1q and the vlan tag is attached to the output packet. The
problem is the 'ether_proto' field of the vlan header, which is set again
to 0x8100 (VLAN) instead of 0x0800 (IPv4). Apart from this, the rest of the
packet is correct. So if this is corrected in the driver it will work, I
think.

Regards,

El lun., 3 sept. 2018 a las 19:32, Victor Huertas (<vhuertas@gmail.com>)
escribió:

> Hi all,
>
> I have realized that the PKT_TX_VLAN_PKT flag for Tx Vlan Offload doesn't
> work in my application.
>
> According to the NICs I have (IGB) there seems to be a problem with this
> vlan offload tx feature and this version of DPDK according to the Bug 17 :
> https://bugs.dpdk.org/show_bug.cgi?id=17
>
> I have tested it using vfio_pci and igb_uio drivers as well as SW vlan
> insertion (rte_vlan_insert) and the result is exactly the same.
>
> Have this bug been solved so far?
>
> These are my NICs:
> 04:00.1 Ethernet controller: Intel Corporation 82576 Gigabit Network
> Connection (rev 01)
>     Subsystem: Super Micro Computer Inc Device 10c9
>     Flags: fast devsel, IRQ 17
>     Memory at fafe0000 (32-bit, non-prefetchable) [disabled] [size=128K]
>     Memory at fafc0000 (32-bit, non-prefetchable) [disabled] [size=128K]
>     I/O ports at ec00 [disabled] [size=32]
>     Memory at fafbc000 (32-bit, non-prefetchable) [disabled] [size=16K]
>     [virtual] Expansion ROM at faf80000 [disabled] [size=128K]
>     Capabilities: [40] Power Management version 3
>     Capabilities: [50] MSI: Enable- Count=1/1 Maskable+ 64bit+
>     Capabilities: [70] MSI-X: Enable- Count=10 Masked-
>     Capabilities: [a0] Express Endpoint, MSI 00
>     Capabilities: [100] Advanced Error Reporting
>     Capabilities: [140] Device Serial Number 00-30-48-ff-ff-bb-17-02
>     Capabilities: [150] Alternative Routing-ID Interpretation (ARI)
>     Capabilities: [160] Single Root I/O Virtualization (SR-IOV)
>     Kernel driver in use: vfio-pci
>     Kernel modules: igb
>
> 04:00.0 Ethernet controller: Intel Corporation 82576 Gigabit Network
> Connection (rev 01)
>     Subsystem: Super Micro Computer Inc Device 10c9
>     Flags: fast devsel, IRQ 16
>     Memory at faf60000 (32-bit, non-prefetchable) [disabled] [size=128K]
>     Memory at faf40000 (32-bit, non-prefetchable) [disabled] [size=128K]
>     I/O ports at e880 [disabled] [size=32]
>     Memory at faf3c000 (32-bit, non-prefetchable) [disabled] [size=16K]
>     [virtual] Expansion ROM at faf00000 [disabled] [size=128K]
>     Capabilities: [40] Power Management version 3
>     Capabilities: [50] MSI: Enable- Count=1/1 Maskable+ 64bit+
>     Capabilities: [70] MSI-X: Enable- Count=10 Masked-
>     Capabilities: [a0] Express Endpoint, MSI 00
>     Capabilities: [100] Advanced Error Reporting
>     Capabilities: [140] Device Serial Number 00-30-48-ff-ff-bb-17-02
>     Capabilities: [150] Alternative Routing-ID Interpretation (ARI)
>     Capabilities: [160] Single Root I/O Virtualization (SR-IOV)
>     Kernel driver in use: vfio-pci
>     Kernel modules: igb
>
> Thanks for your attention
>
> Regards,
>
> PD: BTW, I have observed that capturing a, for example, an ARP message in
> an rx queue which the VLAN stripped the answer is sent correctly if I set
> the PKT_TX_VLAN_PKT flag and the VLAN_TCI is the same... However, if I try
> to set the VLAN header from a non-VLAN stripped frame then it doesnt work.
>
>
>
> --
> Victor
>


-- 
Victor

  reply	other threads:[~2018-09-04 11:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-03 17:32 Victor Huertas
2018-09-04 11:13 ` Victor Huertas [this message]
2018-09-04 13:46 ` Victor Huertas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGxG5chZ1Ogn-ZDL64_7ceRx9OwhveoC-uurg2m0Mf31DnbY8A@mail.gmail.com \
    --to=vhuertas@gmail.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).