From: jigsaw <jigsaw@gmail.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] Add support for 82599 Tx->Rx loopback operation.
Date: Wed, 25 Sep 2013 17:56:11 +0300 [thread overview]
Message-ID: <CAHVfvh6GhEo1W8oV5zw=kFsb-6cOoO+z36xa7jx2YC5oRx3BrQ@mail.gmail.com> (raw)
In-Reply-To: <201309251647.26757.thomas.monjalon@6wind.com>
Hi Thomas,
The patch can be made without modifying ixgbe/ at all, I will make
another attempt. Please see the proposal in my previous email.
The question is how to keep the lpbk_mode field in struct rte_eth_conf
future-proof. Or if this is overkill to think about possible future
loopback support at this moment?
thx &
rgds,
-qinglai
On Wed, Sep 25, 2013 at 5:47 PM, Thomas Monjalon
<thomas.monjalon@6wind.com> wrote:
> 25/09/2013 16:12, Venkatesan, Venky :
>> I for one would prefer that the changes not really modify any files in the
>> librte_pmd_ixgbe/ixgbe directory. Those files are derived directly from
>> the BSD driver baseline, and any changes will make future merges of newer
>> code more challenging. The changes should be limited to files in the
>> librte_pmd_ixgbe directory (and ethdev).
>
> I agree with Venky.
> The poll-mode drivers e1000 and ixgbe are based on drivers located in
> subdirectories e1000/ and ixgbe/. And by design, these poll-mode drivers use
> the base drivers without modifying it.
> So please try to restrict your changes to ixgbe_ethdev.c and ixgbe_rxtx.c.
>
> The coding rules are not written. If needed, we could add a file for it.
>
> Thanks for your patch
> --
> Thomas
next prev parent reply other threads:[~2013-09-25 14:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-23 19:16 Qinglai Xiao
2013-09-25 13:11 ` Ivan Boule
2013-09-25 13:56 ` jigsaw
2013-09-25 14:12 ` Venkatesan, Venky
2013-09-25 14:38 ` jigsaw
2013-09-25 15:47 ` Venkatesan, Venky
2013-09-25 16:59 ` jigsaw
2013-09-25 17:37 ` Venkatesan, Venky
2013-09-26 7:27 ` Ivan Boule
2013-09-25 14:47 ` Thomas Monjalon
2013-09-25 14:56 ` jigsaw [this message]
2013-09-25 15:04 ` Ivan Boule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHVfvh6GhEo1W8oV5zw=kFsb-6cOoO+z36xa7jx2YC5oRx3BrQ@mail.gmail.com' \
--to=jigsaw@gmail.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).