From: Usman Tanveer <usman.tanveer@emumba.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
Subject: Re: [PATCH] ethtool: remove a redundant call to rte_eth_dev_stop()
Date: Wed, 6 Jul 2022 14:49:51 +0500 [thread overview]
Message-ID: <CAH_O0by0+yqCPnKvrHXxhFzFgZ3eJGOiveiaHTPzCu7yBZkrhg@mail.gmail.com> (raw)
In-Reply-To: <28911775.czjnFlTdjD@thomas>
It has been there since the file was added (2015). I'm not able to
find any purpose for this.
Although, it's misleading the messages it shows upon calling
rte_ethtool_net_open() as mentioned above. And when this function is
called even when the port is already UP, it should print a message
"device already started", but it's not like that because it first
stops the device and then starts it again.
The above change fixes both misleading messages.
On Mon, Jun 27, 2022 at 2:16 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 27/05/2022 08:42, Usman Tanveer:
> > There is a call to rte_eth_dev_stop() in rte_ethtool_net_open()
> > due to which user gets misleading message upon first open/start call.
> > It says that the
> > device is already stopped, which should not be the case. This patch
> > removes rte_eth_dev_stop() from rte_ethtool_net_open().
>
> Why was it there?
> Any opinion? Is it safe to remove?
>
> > int
> > rte_ethtool_net_open(uint16_t port_id)
> > {
> > - int ret;
> > -
> > - ret = rte_eth_dev_stop(port_id);
> > - if (ret != 0)
> > - return ret;
> > -
> > return rte_eth_dev_start(port_id);
> > }
>
>
>
next prev parent reply other threads:[~2022-07-06 9:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-27 6:42 Usman Tanveer
2022-06-03 11:02 ` Usman Tanveer
2022-06-26 21:16 ` Thomas Monjalon
2022-07-06 9:49 ` Usman Tanveer [this message]
2022-08-18 10:18 ` Usman Tanveer
2023-07-03 22:31 ` Stephen Hemminger
2023-07-06 16:15 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH_O0by0+yqCPnKvrHXxhFzFgZ3eJGOiveiaHTPzCu7yBZkrhg@mail.gmail.com \
--to=usman.tanveer@emumba.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).