From: David Marchand <email@example.com>
To: Jerin Jacob <firstname.lastname@example.org>
Cc: Sunil Kumar Kori <email@example.com>,
Timothy McDaniel <firstname.lastname@example.org>,
Jerin Jacob Kollanukkaran <email@example.com>,
Erik Gabriel Carrillo <firstname.lastname@example.org>,
Gage Eads <email@example.com>,
Van Haaren Harry <firstname.lastname@example.org>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH 1/1] eal: increase TRACE CTF SIZE to recommended size
Date: Wed, 7 Oct 2020 11:04:00 +0200 [thread overview]
Message-ID: <CAJFAV8wPhja9LMH1OMW4A9ocxU3e_VqGVG+kth6pLhxqFJEGQw@mail.gmail.com> (raw)
On Tue, Oct 6, 2020 at 11:58 AM Jerin Jacob <email@example.com> wrote:
> On Tue, Oct 6, 2020 at 3:10 PM David Marchand <firstname.lastname@example.org> wrote:
> > On Tue, Oct 6, 2020 at 11:22 AM Sunil Kumar Kori <email@example.com> wrote:
> > > >On Mon, Oct 5, 2020 at 10:16 PM Timothy McDaniel
> > > ><firstname.lastname@example.org> wrote:
> > > >>
> > > >> Increase TRACE_CTF_FIELD_SIZE to 448, the recommended size.
> > > >
> > > >Repeating the same sentence in the title and the commitlog does not give
> > > >much info.
> > > >
> > > >Plus, what is this "recommendation"?
> > > When analyzed this issue, only one more byte was needed to fix this issue but in future similar issue can occur again.
> > > So increasing this value by 64 bytes which actually equals to a cache line. That’s why we have suggested this size.
> > 384 is aligned to both 64 and 128 bytes cache lines.
> > 448 is only aligned to 64 bytes.
> > Should we care about 128 bytes cache lines systems?
> it is on a slow path. 448 is OK.
Ah yes, this is for the ctf description.
Could it be changed to rely on dynamic allocations and we simply
remove this limit?
> > >
> > > >
> > > >
> > > >> Fixes "CTF field is too long" error when running with trace enabled.
> > > >
> > > >Ok, you hit this limit, but it would help to get some context here.
> > > >Looking at this patch in the future, we won't know why it was necessary.
> > How about following commitlog:
> > """
> > trace: increase trace point buffer size
> > The current buffer size is not big enough to accomodate traces for new
> > additions in the eventdev subsystem.
> > Increase this buffer size by XXX for reason YYY.
> > """
> Looks good to me.
Well in this case, there is no actual reason.
The increased value is deemed "enough for now", unless we change this
to dynamic allocations.
next prev parent reply other threads:[~2020-10-07 9:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-05 20:02 [dpdk-dev] " Timothy McDaniel
2020-10-06 8:45 ` David Marchand
2020-10-06 9:22 ` [dpdk-dev] [EXT] " Sunil Kumar Kori
2020-10-06 9:39 ` David Marchand
2020-10-06 9:58 ` Jerin Jacob
2020-10-07 9:04 ` David Marchand [this message]
2020-10-07 10:07 ` Sunil Kumar Kori
2020-10-07 12:34 ` David Marchand
2020-10-08 7:33 ` [dpdk-dev] " David Marchand
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).