Re: [dpdk-dev] [EXT] Re: [PATCH 1/1] eal: increase TRACE CTF SIZE to recommended size

[Sunil Kumar Kori <skori@marvell.com>]

Regards
Sunil Kumar Kori

>-----Original Message-----
>From: David Marchand <david.marchand@redhat.com>
>Sent: Tuesday, October 6, 2020 2:15 PM
>To: Timothy McDaniel <timothy.mcdaniel@intel.com>
>Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Sunil Kumar Kori
><skori@marvell.com>; dev <dev@dpdk.org>; Erik Gabriel Carrillo
><erik.g.carrillo@intel.com>; Gage Eads <gage.eads@intel.com>; Van Haaren
>Harry <harry.van.haaren@intel.com>
>Subject: [EXT] Re: [dpdk-dev] [PATCH 1/1] eal: increase TRACE CTF SIZE to
>recommended size
>
>External Email
>
>----------------------------------------------------------------------
>On Mon, Oct 5, 2020 at 10:16 PM Timothy McDaniel
><timothy.mcdaniel@intel.com> wrote:
>>
>> Increase TRACE_CTF_FIELD_SIZE to 448, the recommended size.
>
>Repeating the same sentence in the title and the commitlog does not give
>much info.
>
>Plus, what is this "recommendation"?
When analyzed this issue, only one more byte was needed to fix this issue but in future similar issue can occur again.
So increasing this value by 64 bytes which actually equals to a cache line. That’s why we have suggested this size.

>
>
>> Fixes "CTF field is too long" error when running with trace enabled.
>
>Ok, you hit this limit, but it would help to get some context here.
>Looking at this patch in the future, we won't know why it was necessary.
>
>
>>
>> Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
>> ---
>>  lib/librte_eal/common/eal_trace.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/librte_eal/common/eal_trace.h
>> b/lib/librte_eal/common/eal_trace.h
>> index 92c5951..438c2b7 100644
>> --- a/lib/librte_eal/common/eal_trace.h
>> +++ b/lib/librte_eal/common/eal_trace.h
>> @@ -24,7 +24,7 @@
>>
>>  #define TRACE_PREFIX_LEN 12
>>  #define TRACE_DIR_STR_LEN (sizeof("YYYY-mm-dd-AM-HH-MM-SS") +
>> TRACE_PREFIX_LEN) -#define TRACE_CTF_FIELD_SIZE 384
>> +#define TRACE_CTF_FIELD_SIZE 448
>>  #define TRACE_POINT_NAME_SIZE 64
>>  #define TRACE_CTF_MAGIC 0xC1FC1FC1
>>  #define TRACE_MAX_ARGS 32
>> --
>> 2.6.4
>>
>
>
>--
>David Marchand