DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Reshma Pattan <reshma.pattan@intel.com>
Cc: dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] doc: update pdump documentation
Date: Thu, 26 Nov 2020 16:28:51 +0100
Message-ID: <CAJFAV8wQ299iFKSKcGmfZes2601F76p6R__9fkK5o01ajbhtUA@mail.gmail.com> (raw)
In-Reply-To: <1606398674-32351-1-git-send-email-reshma.pattan@intel.com>

On Thu, Nov 26, 2020 at 2:58 PM Reshma Pattan <reshma.pattan@intel.com> wrote:
> Update the pdump library programmers guide and Howto doc
> with the use of multi process channel replacing socket
> based communication.
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>


>  The library APIs ``rte_pdump_disable()`` and ``rte_pdump_disable_by_deviceid()`` disables the packet capture.
> -On each call to these APIs, the library creates a separate client socket, creates the "pdump disable" request and sends
> -the request to the server. The server that is listening on the socket will take the request and disable the packet
> -capture by removing the Ethernet RX and TX callbacks for the given port or device_id and queue combinations. The server
> -also sends the response back to the client about the status of the request that was processed. After the response is
> -received from the server, the client socket is closed.
> +For the calls to these APIs from secondary process, the library creates the "pdump disable" request and sends
> +the request to the primary process over the multi process channel. The primary process takes this request and disables the packet capture by removing the Ethernet RX and TX callbacks for the given port or device_id and queue combinations.

I split this long line to multiple ~100 characters lines like the rest
of the document.

Applied, thanks.

David Marchand

      reply	other threads:[~2020-11-26 15:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-13 14:25 [dpdk-dev] [PATCH] " Reshma Pattan
2020-09-02 11:40 ` Pattan, Reshma
2020-10-07 11:37   ` Pattan, Reshma
2020-11-26 11:41 ` Bruce Richardson
2020-11-26 13:51 ` [dpdk-dev] [PATCH v2] " Reshma Pattan
2020-11-26 15:28   ` David Marchand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8wQ299iFKSKcGmfZes2601F76p6R__9fkK5o01ajbhtUA@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=reshma.pattan@intel.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git